Patch Detail
Show a patch.
GET /api/1.1/patches/20381/?format=api
{ "id": 20381, "url": "https://patchwork.libcamera.org/api/1.1/patches/20381/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20381/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240625062327.50940-4-umang.jain@ideasonboard.com>", "date": "2024-06-25T06:23:26", "name": "[v3,3/4] libcamera: converter: Add DW100 converter class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "632a07a92f52b6f39c40a791ac18b1406744017e", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20381/mbox/", "series": [ { "id": 4414, "url": "https://patchwork.libcamera.org/api/1.1/series/4414/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4414", "date": "2024-06-25T06:23:23", "name": "libcamera: rkisp1: Plumb the ConverterDW100 converter", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4414/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20381/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20381/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FC68C3295\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Jun 2024 06:23:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CEF8654AF;\n\tTue, 25 Jun 2024 08:23:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6C58654AE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jun 2024 08:23:36 +0200 (CEST)", "from fedora.local (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78850BEB;\n\tTue, 25 Jun 2024 08:23:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kntKswFk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719296594;\n\tbh=Ri3VtMyTyWteuj1oFmKyoTBIp8RA9ecgVmLU9Mv3fdE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kntKswFk7H4ANzVXbcB9eg0KINk01R2XGkfkJrakEQT75vIeVxCP/KYYee4MQha8R\n\ttMJvOhGpG5T+WIMgkuPzO8QhZblu9Ifnj2d+5MPN2PLAnG12kYQvOJpX1uNRWhqss3\n\tuvNL2OmFDcEOb5an2urLTEv1LVwJDkkNtu6xYJ3A=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v3 3/4] libcamera: converter: Add DW100 converter class", "Date": "Tue, 25 Jun 2024 11:53:26 +0530", "Message-ID": "<20240625062327.50940-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<20240625062327.50940-1-umang.jain@ideasonboard.com>", "References": "<20240625062327.50940-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "DW100 Dewarp engine is present on i.MX8MP SoC. This patch\nprovides a converter class (inherited from V4L2M2MConverter).\n\nThe DW100 converter will be used for scaling capabilites hence, has\na helper to set scaler crop rectangles. Plumbing in the RkISP1\npipeline-handler is done in the subsequent patch.\n\nThe ConverterDW100 class can be extended later (as additional\ndevelopement) to support the dewarping by setting a dewarp vertex map.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n .../internal/converter/converter_dw100.h | 26 +++++++++\n .../libcamera/internal/converter/meson.build | 1 +\n src/libcamera/converter/converter_dw100.cpp | 56 +++++++++++++++++++\n src/libcamera/converter/meson.build | 1 +\n 4 files changed, 84 insertions(+)\n create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n create mode 100644 src/libcamera/converter/converter_dw100.cpp", "diff": "diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\nnew file mode 100644\nindex 00000000..ae6d0732\n--- /dev/null\n+++ b/include/libcamera/internal/converter/converter_dw100.h\n@@ -0,0 +1,26 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ *i.MX8MP Dewarp Engine integration\n+ */\n+\n+#pragma once\n+\n+#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n+\n+namespace libcamera {\n+\n+class MediaDevice;\n+class Rectangle;\n+class Stream;\n+\n+class ConverterDW100 : public V4L2M2MConverter\n+{\n+public:\n+\tConverterDW100(std::shared_ptr<MediaDevice> media);\n+\n+\tint setScalerCrop(const Stream *stream, Rectangle rect);\n+};\n+\n+} /* namespace libcamera */\ndiff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\nindex 891e79e7..85007a4b 100644\n--- a/include/libcamera/internal/converter/meson.build\n+++ b/include/libcamera/internal/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_internal_headers += files([\n+ 'converter_dw100.h',\n 'converter_v4l2_m2m.h',\n ])\ndiff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\nnew file mode 100644\nindex 00000000..04e6942f\n--- /dev/null\n+++ b/src/libcamera/converter/converter_dw100.cpp\n@@ -0,0 +1,56 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#include \"libcamera/internal/converter/converter_dw100.h\"\n+\n+#include <libcamera/base/log.h>\n+\n+#include <libcamera/geometry.h>\n+\n+#include \"libcamera/internal/media_device.h\"\n+#include \"libcamera/internal/v4l2_videodevice.h\"\n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(Converter)\n+\n+/**\n+ * \\class libcamera::ConverterDW100\n+ * \\brief The i.MX8MP dewarp converter implements the converter interface based\n+ * on V4L2 M2M device.\n+*/\n+\n+/**\n+ * \\fn ConverterDW100::ConverterDW100\n+ * \\brief Construct a ConverterDW100 instance\n+ * \\param[in] media The media device implementing the converter\n+ */\n+ConverterDW100::ConverterDW100(std::shared_ptr<MediaDevice> media)\n+\t: V4L2M2MConverter(media.get())\n+{\n+}\n+\n+/**\n+ * \\brief Set the scaler crop rectangle \\a rect on \\a stream\n+ * \\param[in] stream Pointer to output stream\n+ * \\param[inout] rect The selection rectangle to be applied\n+ *\n+ * \\return 0 on success or a negative error code otherwise\n+ */\n+int ConverterDW100::setScalerCrop(const Stream *stream, Rectangle rect)\n+{\n+\tint ret;\n+\n+\tret = setSelection(stream, V4L2_SEL_TGT_CROP, &rect);\n+\tif (ret < 0)\n+\t\tLOG(Converter, Error) << \"Failed to set scaler crop on dewarper \"\n+\t\t\t\t << strerror(-ret);\n+\n+\treturn ret;\n+}\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\nindex 2aa72fe4..175581b8 100644\n--- a/src/libcamera/converter/meson.build\n+++ b/src/libcamera/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_sources += files([\n+ 'converter_dw100.cpp',\n 'converter_v4l2_m2m.cpp'\n ])\n", "prefixes": [ "v3", "3/4" ] }