Patch Detail
Show a patch.
GET /api/1.1/patches/2037/?format=api
{ "id": 2037, "url": "https://patchwork.libcamera.org/api/1.1/patches/2037/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2037/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190927024417.725906-14-niklas.soderlund@ragnatech.se>", "date": "2019-09-27T02:44:17", "name": "[libcamera-devel,v3,13/13] libcamera: pipeline: rkisp1: Attach to an IPA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7ce3306461040ba33cf7f2434af92139180d00c4", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2037/mbox/", "series": [ { "id": 508, "url": "https://patchwork.libcamera.org/api/1.1/series/508/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=508", "date": "2019-09-27T02:44:04", "name": "libcamera: ipa: Add basic IPA support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/508/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2037/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2037/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E25F56191D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Sep 2019 04:45:37 +0200 (CEST)", "from bismarck.berto.se (unknown [84.172.88.101])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid d2daf8dd-e0d0-11e9-bdc3-005056917a89;\n\tFri, 27 Sep 2019 04:45:10 +0200 (CEST)" ], "X-Halon-ID": "d2daf8dd-e0d0-11e9-bdc3-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Sep 2019 04:44:17 +0200", "Message-Id": "<20190927024417.725906-14-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20190927024417.725906-1-niklas.soderlund@ragnatech.se>", "References": "<20190927024417.725906-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 13/13] libcamera: pipeline: rkisp1:\n\tAttach to an IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 27 Sep 2019 02:45:38 -0000" }, "content": "Add the plumbing to the pipeline handler to interact with an IPA module.\nThis change makes the usage of an IPA module mandatory for the rkisp1\npipeline.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/rkisp1/meson.build | 1 +\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 263 ++++++++++++++++++++-\n src/libcamera/pipeline/rkisp1/rkisp1.h | 81 +++++++\n src/libcamera/pipeline/rkisp1/timeline.cpp | 56 +++++\n 4 files changed, 388 insertions(+), 13 deletions(-)\n create mode 100644 src/libcamera/pipeline/rkisp1/rkisp1.h\n create mode 100644 src/libcamera/pipeline/rkisp1/timeline.cpp", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/meson.build b/src/libcamera/pipeline/rkisp1/meson.build\nindex f1cc4046b5d064cb..d04fb45223e72fa1 100644\n--- a/src/libcamera/pipeline/rkisp1/meson.build\n+++ b/src/libcamera/pipeline/rkisp1/meson.build\n@@ -1,3 +1,4 @@\n libcamera_sources += files([\n 'rkisp1.cpp',\n+ 'timeline.cpp',\n ])\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex de4ab523d0e4fe36..5ca2c93bc7e70100 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -5,11 +5,12 @@\n * rkisp1.cpp - Pipeline handler for Rockchip ISP1\n */\n \n+#include \"rkisp1.h\"\n+\n #include <algorithm>\n #include <array>\n #include <iomanip>\n #include <memory>\n-#include <vector>\n \n #include <linux/media-bus-format.h>\n \n@@ -17,8 +18,8 @@\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n \n-#include \"camera_sensor.h\"\n #include \"device_enumerator.h\"\n+#include \"ipa_manager.h\"\n #include \"log.h\"\n #include \"media_device.h\"\n #include \"pipeline_handler.h\"\n@@ -34,7 +35,7 @@ class RkISP1CameraData : public CameraData\n {\n public:\n \tRkISP1CameraData(PipelineHandler *pipe)\n-\t\t: CameraData(pipe), sensor_(nullptr)\n+\t\t: CameraData(pipe), sensor_(nullptr), frame_(0)\n \t{\n \t}\n \n@@ -43,8 +44,19 @@ public:\n \t\tdelete sensor_;\n \t}\n \n+\tint loadIPA() override;\n+\n \tStream stream_;\n \tCameraSensor *sensor_;\n+\tunsigned int frame_;\n+\tstd::map<unsigned int, Request *> frameInfo_;\n+\tRkISP1Timeline timeline_;\n+\n+private:\n+\tvoid updateSensor(unsigned int frame, V4L2ControlList controls);\n+\tvoid queueBuffer(unsigned int frame, unsigned int type,\n+\t\t\t unsigned int id);\n+\tvoid metaDataReady(unsigned int frame, IPAMetaData metaData);\n };\n \n class RkISP1CameraConfiguration : public CameraConfiguration\n@@ -99,18 +111,94 @@ private:\n \t\t\tPipelineHandler::cameraData(camera));\n \t}\n \n+\tfriend RkISP1CameraData;\n+\n \tint initLinks();\n \tint createCamera(MediaEntity *sensor);\n+\tvoid tryCompleteRequest(Request *request);\n \tvoid bufferReady(Buffer *buffer);\n+\tvoid paramReady(Buffer *buffer);\n+\tvoid statReady(Buffer *buffer);\n \n \tMediaDevice *media_;\n \tV4L2Subdevice *dphy_;\n \tV4L2Subdevice *isp_;\n \tV4L2VideoDevice *video_;\n+\tV4L2VideoDevice *param_;\n+\tV4L2VideoDevice *stat_;\n+\n+\tBufferPool paramPool_;\n+\tBufferPool statPool_;\n+\n+\tstd::map<unsigned int, Buffer *> paramBuffers_;\n+\tstd::map<unsigned int, Buffer *> statBuffers_;\n \n \tCamera *activeCamera_;\n };\n \n+int RkISP1CameraData::loadIPA()\n+{\n+\tipa_ = IPAManager::instance()->createIPA(pipe_, 1, 1);\n+\tif (!ipa_)\n+\t\treturn -ENOENT;\n+\n+\tipa_->updateSensor.connect(this,\n+\t\t\t\t &RkISP1CameraData::updateSensor);\n+\tipa_->queueBuffer.connect(this,\n+\t\t\t\t &RkISP1CameraData::queueBuffer);\n+\tipa_->setDelay.connect(&timeline_,\n+\t\t\t &RkISP1Timeline::setDelay);\n+\tipa_->metaDataReady.connect(this,\n+\t\t\t\t &RkISP1CameraData::metaDataReady);\n+\n+\treturn 0;\n+}\n+\n+void RkISP1CameraData::updateSensor(unsigned int frame, V4L2ControlList controls)\n+{\n+\ttimeline_.scheduleAction(new RkISP1ActionSetSensor(frame, sensor_, controls));\n+}\n+\n+void RkISP1CameraData::queueBuffer(unsigned int frame, unsigned int type,\n+\t\t\t\t unsigned int id)\n+{\n+\tPipelineHandlerRkISP1 *pipe =\n+\t\tstatic_cast<PipelineHandlerRkISP1 *>(pipe_);\n+\n+\tRkISP1ActionType acttype;\n+\tV4L2VideoDevice *device;\n+\tBuffer *buffer;\n+\tswitch (type) {\n+\tcase BUFFER_PARAM:\n+\t\tacttype = QueueParameters;\n+\t\tdevice = pipe->param_;\n+\t\tbuffer = pipe->paramBuffers_[id];\n+\t\tbreak;\n+\tcase BUFFER_STAT:\n+\t\tacttype = QueueStatistics;\n+\t\tdevice = pipe->stat_;\n+\t\tbuffer = pipe->statBuffers_[id];\n+\t\tbreak;\n+\tdefault:\n+\t\tLOG(RkISP1, Error) << \"Unkown IPA buffer type \" << type;\n+\t\treturn;\n+\t}\n+\n+\ttimeline_.scheduleAction(new RkISP1ActionQueueBuffer(frame, acttype,\n+\t\t\t\t\t\t\t device, buffer));\n+}\n+\n+void RkISP1CameraData::metaDataReady(unsigned int frame, IPAMetaData metaData)\n+{\n+\tRequest *request = frameInfo_[frame];\n+\tPipelineHandlerRkISP1 *pipe =\n+\t\tstatic_cast<PipelineHandlerRkISP1 *>(pipe_);\n+\n+\tpipe->processMetaData(request, metaData);\n+\n+\tpipe->tryCompleteRequest(request);\n+}\n+\n RkISP1CameraConfiguration::RkISP1CameraConfiguration(Camera *camera,\n \t\t\t\t\t\t RkISP1CameraData *data)\n \t: CameraConfiguration()\n@@ -202,12 +290,14 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \n PipelineHandlerRkISP1::PipelineHandlerRkISP1(CameraManager *manager)\n \t: PipelineHandler(manager), dphy_(nullptr), isp_(nullptr),\n-\t video_(nullptr)\n+\t video_(nullptr), param_(nullptr), stat_(nullptr)\n {\n }\n \n PipelineHandlerRkISP1::~PipelineHandlerRkISP1()\n {\n+\tdelete param_;\n+\tdelete stat_;\n \tdelete video_;\n \tdelete isp_;\n \tdelete dphy_;\n@@ -317,6 +407,20 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret)\n \t\treturn ret;\n \n+\tV4L2DeviceFormat paramFormat = {};\n+\tparamFormat.fourcc = V4L2_META_FMT_RK_ISP1_PARAMS;\n+\n+\tret = param_->setFormat(¶mFormat);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tV4L2DeviceFormat statFormat = {};\n+\tstatFormat.fourcc = V4L2_META_FMT_RK_ISP1_STAT_3A;\n+\n+\tret = stat_->setFormat(&statFormat);\n+\tif (ret)\n+\t\treturn ret;\n+\n \tif (outputFormat.size != cfg.size ||\n \t outputFormat.fourcc != cfg.pixelFormat) {\n \t\tLOG(RkISP1, Error)\n@@ -332,31 +436,99 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n int PipelineHandlerRkISP1::allocateBuffers(Camera *camera,\n \t\t\t\t\t const std::set<Stream *> &streams)\n {\n+\tRkISP1CameraData *data = cameraData(camera);\n \tStream *stream = *streams.begin();\n+\tint ret;\n \n \tif (stream->memoryType() == InternalMemory)\n-\t\treturn video_->exportBuffers(&stream->bufferPool());\n+\t\tret = video_->exportBuffers(&stream->bufferPool());\n \telse\n-\t\treturn video_->importBuffers(&stream->bufferPool());\n+\t\tret = video_->importBuffers(&stream->bufferPool());\n+\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tparamPool_.createBuffers(stream->configuration().bufferCount + 1);\n+\tret = param_->exportBuffers(¶mPool_);\n+\tif (ret) {\n+\t\tvideo_->releaseBuffers();\n+\t\treturn ret;\n+\t}\n+\n+\tstatPool_.createBuffers(stream->configuration().bufferCount + 1);\n+\tret = stat_->exportBuffers(&statPool_);\n+\tif (ret) {\n+\t\tparam_->releaseBuffers();\n+\t\tvideo_->releaseBuffers();\n+\t\treturn ret;\n+\t}\n+\n+\tfor (unsigned int i = 0; i < stream->configuration().bufferCount + 1; i++) {\n+\t\tparamBuffers_[i] = new Buffer(i);\n+\t\tstatBuffers_[i] = new Buffer(i);\n+\t}\n+\n+\tdata->ipa_->initBuffers(BUFFER_PARAM, paramPool_.buffers());\n+\tdata->ipa_->initBuffers(BUFFER_STAT, statPool_.buffers());\n+\n+\treturn ret;\n }\n \n int PipelineHandlerRkISP1::freeBuffers(Camera *camera,\n \t\t\t\t const std::set<Stream *> &streams)\n {\n+\tfor (auto it : paramBuffers_)\n+\t\tdelete it.second;\n+\n+\tparamBuffers_.clear();\n+\n+\tfor (auto it : statBuffers_)\n+\t\tdelete it.second;\n+\n+\tstatBuffers_.clear();\n+\n+\tif (param_->releaseBuffers())\n+\t\tLOG(RkISP1, Error) << \"Failed to release parameters buffers\";\n+\n+\tif (stat_->releaseBuffers())\n+\t\tLOG(RkISP1, Error) << \"Failed to release stat buffers\";\n+\n \tif (video_->releaseBuffers())\n-\t\tLOG(RkISP1, Error) << \"Failed to release buffers\";\n+\t\tLOG(RkISP1, Error) << \"Failed to release video buffers\";\n \n \treturn 0;\n }\n \n int PipelineHandlerRkISP1::start(Camera *camera)\n {\n+\tRkISP1CameraData *data = cameraData(camera);\n \tint ret;\n \n+\tdata->ipa_->initSensor(data->sensor_->controls());\n+\n+\tret = param_->streamOn();\n+\tif (ret) {\n+\t\tLOG(RkISP1, Error)\n+\t\t\t<< \"Failed to start parameters \" << camera->name();\n+\t\treturn ret;\n+\t}\n+\n+\tret = stat_->streamOn();\n+\tif (ret) {\n+\t\tparam_->streamOff();\n+\t\tLOG(RkISP1, Error)\n+\t\t\t<< \"Failed to start statistics \" << camera->name();\n+\t\treturn ret;\n+\t}\n+\n \tret = video_->streamOn();\n-\tif (ret)\n+\tif (ret) {\n+\t\tparam_->streamOff();\n+\t\tstat_->streamOff();\n+\n \t\tLOG(RkISP1, Error)\n \t\t\t<< \"Failed to start camera \" << camera->name();\n+\t}\n \n \tactiveCamera_ = camera;\n \n@@ -365,6 +537,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n \n void PipelineHandlerRkISP1::stop(Camera *camera)\n {\n+\tRkISP1CameraData *data = cameraData(camera);\n \tint ret;\n \n \tret = video_->streamOff();\n@@ -372,6 +545,18 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n \t\tLOG(RkISP1, Warning)\n \t\t\t<< \"Failed to stop camera \" << camera->name();\n \n+\tret = stat_->streamOff();\n+\tif (ret)\n+\t\tLOG(RkISP1, Warning)\n+\t\t\t<< \"Failed to stop statistics \" << camera->name();\n+\n+\tret = param_->streamOff();\n+\tif (ret)\n+\t\tLOG(RkISP1, Warning)\n+\t\t\t<< \"Failed to stop parameters \" << camera->name();\n+\n+\tdata->timeline_.reset();\n+\n \tactiveCamera_ = nullptr;\n }\n \n@@ -387,12 +572,17 @@ int PipelineHandlerRkISP1::queueRequest(Camera *camera, Request *request)\n \t\treturn -ENOENT;\n \t}\n \n-\tint ret = video_->queueBuffer(buffer);\n-\tif (ret < 0)\n-\t\treturn ret;\n-\n \tPipelineHandler::queueRequest(camera, request);\n \n+\tdata->frameInfo_[data->frame_] = request;\n+\tdata->ipa_->queueRequest(data->frame_, request->controls());\n+\n+\tdata->timeline_.scheduleAction(new RkISP1ActionQueueBuffer(data->frame_,\n+\t\t\t\t\t\t\t\t QueueVideo,\n+\t\t\t\t\t\t\t\t video_,\n+\t\t\t\t\t\t\t\t buffer));\n+\tdata->frame_++;\n+\n \treturn 0;\n }\n \n@@ -435,6 +625,10 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \tstd::unique_ptr<RkISP1CameraData> data =\n \t\tutils::make_unique<RkISP1CameraData>(this);\n \n+\tdata->controlInfo_.emplace(std::piecewise_construct,\n+\t\t\t\t std::forward_as_tuple(AeEnable),\n+\t\t\t\t std::forward_as_tuple(AeEnable, false, true));\n+\n \tdata->sensor_ = new CameraSensor(sensor);\n \tret = data->sensor_->init();\n \tif (ret)\n@@ -478,7 +672,17 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n \tif (video_->open() < 0)\n \t\treturn false;\n \n+\tstat_ = V4L2VideoDevice::fromEntityName(media_, \"rkisp1-statistics\");\n+\tif (stat_->open() < 0)\n+\t\treturn false;\n+\n+\tparam_ = V4L2VideoDevice::fromEntityName(media_, \"rkisp1-input-params\");\n+\tif (param_->open() < 0)\n+\t\treturn false;\n+\n \tvideo_->bufferReady.connect(this, &PipelineHandlerRkISP1::bufferReady);\n+\tstat_->bufferReady.connect(this, &PipelineHandlerRkISP1::statReady);\n+\tparam_->bufferReady.connect(this, &PipelineHandlerRkISP1::paramReady);\n \n \t/* Configure default links. */\n \tif (initLinks() < 0) {\n@@ -504,13 +708,46 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n * Buffer Handling\n */\n \n+void PipelineHandlerRkISP1::tryCompleteRequest(Request *request)\n+{\n+\tif (request->hasPendingBuffers())\n+\t\treturn;\n+\n+\tif (!request->metaData().ready)\n+\t\treturn;\n+\n+\tcompleteRequest(activeCamera_, request);\n+}\n+\n void PipelineHandlerRkISP1::bufferReady(Buffer *buffer)\n {\n \tASSERT(activeCamera_);\n+\tRkISP1CameraData *data = cameraData(activeCamera_);\n \tRequest *request = buffer->request();\n \n+\tdata->timeline_.bufferReady(buffer);\n+\n+\tif (data->frame_ <= buffer->sequence())\n+\t\tdata->frame_ = buffer->sequence() + 1;\n+\n \tcompleteBuffer(activeCamera_, request, buffer);\n-\tcompleteRequest(activeCamera_, request);\n+\ttryCompleteRequest(request);\n+}\n+\n+void PipelineHandlerRkISP1::paramReady(Buffer *buffer)\n+{\n+\tASSERT(activeCamera_);\n+\tRkISP1CameraData *data = cameraData(activeCamera_);\n+\n+\tdata->ipa_->signalBuffer(BUFFER_PARAM, buffer->index());\n+}\n+\n+void PipelineHandlerRkISP1::statReady(Buffer *buffer)\n+{\n+\tASSERT(activeCamera_);\n+\tRkISP1CameraData *data = cameraData(activeCamera_);\n+\n+\tdata->ipa_->signalBuffer(BUFFER_STAT, buffer->index());\n }\n \n REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1);\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.h b/src/libcamera/pipeline/rkisp1/rkisp1.h\nnew file mode 100644\nindex 0000000000000000..aea0eaa6bc838755\n--- /dev/null\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.h\n@@ -0,0 +1,81 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * rkisp1.h - Pipeline handler for Rockchip ISP1\n+ */\n+#ifndef __LIBCAMERA_RKISP1_H__\n+#define __LIBCAMERA_RKISP1_H__\n+\n+#include \"timeline.h\"\n+\n+#include <libcamera/buffer.h>\n+\n+#include \"camera_sensor.h\"\n+#include \"v4l2_videodevice.h\"\n+\n+#define BUFFER_PARAM 1\n+#define BUFFER_STAT 2\n+\n+namespace libcamera {\n+\n+enum RkISP1ActionType {\n+\tSetSensor,\n+\tSOE,\n+\tQueueVideo,\n+\tQueueParameters,\n+\tQueueStatistics,\n+};\n+\n+class RkISP1ActionSetSensor : public FrameAction\n+{\n+public:\n+\tRkISP1ActionSetSensor(unsigned int frame, CameraSensor *sensor, V4L2ControlList controls)\n+\t\t: FrameAction(SetSensor, frame), sensor_(sensor), controls_(controls) {}\n+\n+protected:\n+\tvoid run() override;\n+\n+private:\n+\tCameraSensor *sensor_;\n+\tV4L2ControlList controls_;\n+};\n+\n+class RkISP1ActionQueueBuffer : public FrameAction\n+{\n+public:\n+\tRkISP1ActionQueueBuffer(unsigned int frame, RkISP1ActionType type,\n+\t\t\t\tV4L2VideoDevice *device, Buffer *buffer)\n+\t\t: FrameAction(type, frame), device_(device), buffer_(buffer)\n+\t{\n+\t}\n+\n+protected:\n+\tvoid run() override;\n+\n+private:\n+\tV4L2VideoDevice *device_;\n+\tBuffer *buffer_;\n+};\n+\n+class RkISP1Timeline : public Timeline\n+{\n+public:\n+\tRkISP1Timeline()\n+\t\t: Timeline()\n+\t{\n+\t\tsetDelay(SetSensor, -1, 5);\n+\t\tsetDelay(SOE, 0, -1);\n+\t\tsetDelay(QueueVideo, -1, 10);\n+\t\tsetDelay(QueueParameters, -1, 8);\n+\t\tsetDelay(QueueStatistics, -1, 8);\n+\t}\n+\n+\tvoid bufferReady(Buffer *buffer);\n+\n+\tvoid setDelay(unsigned int type, int frame, int msdelay);\n+};\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_RKISP1_H__ */\ndiff --git a/src/libcamera/pipeline/rkisp1/timeline.cpp b/src/libcamera/pipeline/rkisp1/timeline.cpp\nnew file mode 100644\nindex 0000000000000000..ca0cd96711d84244\n--- /dev/null\n+++ b/src/libcamera/pipeline/rkisp1/timeline.cpp\n@@ -0,0 +1,56 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * timeline.cpp - Timeline handler for Rockchip ISP1\n+ */\n+\n+#include \"rkisp1.h\"\n+\n+#include \"log.h\"\n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(RkISP1)\n+\n+void RkISP1ActionSetSensor::run()\n+{\n+\tsensor_->setControls(&controls_);\n+}\n+\n+void RkISP1ActionQueueBuffer::run()\n+{\n+\tint ret = device_->queueBuffer(buffer_);\n+\tif (ret < 0)\n+\t\tLOG(RkISP1, Error) << \"Failed to queue buffer\";\n+}\n+\n+void RkISP1Timeline::bufferReady(Buffer *buffer)\n+{\n+\t/*\n+\t * Calculate SOE by taking the end of DMA set by the kernel and applying\n+\t * the time offsets provieded by the IPA to find the best estimate of\n+\t * SOE.\n+\t *\n+\t * NOTE: Make sure the IPA do not set a frame offset for the SOE action\n+\t * type as the frame interval is calculated using the interval between\n+\t * two SOE events. So using a frame interval in the SOE estimate creates\n+\t * a recursion.\n+\t */\n+\n+\tASSERT(frameOffset(SOE) == 0);\n+\n+\tutils::time_point soe = std::chrono::time_point<utils::clock>()\n+\t\t+ std::chrono::nanoseconds(buffer->timestamp())\n+\t\t+ timeOffset(SOE);\n+\n+\tnotifyStartOfExposure(buffer->sequence(), soe);\n+}\n+\n+void RkISP1Timeline::setDelay(unsigned int type, int frame, int msdelay)\n+{\n+\tutils::duration delay = std::chrono::milliseconds(msdelay);\n+\tsetRawDelay(type, frame, delay);\n+}\n+\n+} /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v3", "13/13" ] }