Patch Detail
Show a patch.
GET /api/1.1/patches/20368/?format=api
{ "id": 20368, "url": "https://patchwork.libcamera.org/api/1.1/patches/20368/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20368/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240624192941.22943-2-laurent.pinchart@ideasonboard.com>", "date": "2024-06-24T19:29:32", "name": "[01/10] libcamera: base: log: Declare log categories when defining them", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "581e572b74686a326d88799feb5a3a9abe590cf0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20368/mbox/", "series": [ { "id": 4413, "url": "https://patchwork.libcamera.org/api/1.1/series/4413/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4413", "date": "2024-06-24T19:29:31", "name": "libcamera: Enable -Wmissing-declarations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4413/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20368/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20368/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB2B8BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Jun 2024 19:30:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7024A654AE;\n\tMon, 24 Jun 2024 21:30:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B81E654A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Jun 2024 21:30:05 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6368718D7;\n\tMon, 24 Jun 2024 21:29:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Pf4HmrKv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719257383;\n\tbh=dEZ9heUGMM/sZ3NvPDI18wKyL3LpZaNmSCroL7Im9f4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Pf4HmrKvPQ1jEwOi89B18B3jzS5/nNjyqa85kD80S3yJ/I507711XJP+DGU0j26a9\n\tmE/MciNcycu183NfGo0CyRL7Iwi8SNzuTJcvRan7vHikHlYcebup+CKOkUzSlro7VT\n\t7DbsfiX/8RrcfAIooE4qTvk5Z9P2cC7tPW9QNi0Q=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH 01/10] libcamera: base: log: Declare log categories when\n\tdefining them", "Date": "Mon, 24 Jun 2024 22:29:32 +0300", "Message-ID": "<20240624192941.22943-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>", "References": "<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libcamera will enable -Wmissing-declarations to catch mismatches between\nfunction declarations and definitions. There is one offender in log.h:\nwhen a category is defined with LOG_DEFINE_CATEGORY(), it generates a\nfunction with no declaration. Fix it by declaring the function using\nLOG_DECLARE_CATEGORY() as the first step fo the category definition.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/base/log.h | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\nindex b5775e491fee..df27df034d79 100644\n--- a/include/libcamera/base/log.h\n+++ b/include/libcamera/base/log.h\n@@ -48,6 +48,7 @@ private:\n extern const LogCategory &_LOG_CATEGORY(name)();\n \n #define LOG_DEFINE_CATEGORY(name)\t\t\t\t\t\\\n+LOG_DECLARE_CATEGORY(name)\t\t\t\t\t\t\\\n const LogCategory &_LOG_CATEGORY(name)()\t\t\t\t\\\n {\t\t\t\t\t\t\t\t\t\\\n \t/* The instance will be deleted by the Logger destructor. */\t\\\n", "prefixes": [ "01/10" ] }