Patch Detail
Show a patch.
GET /api/1.1/patches/20361/?format=api
{ "id": 20361, "url": "https://patchwork.libcamera.org/api/1.1/patches/20361/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20361/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240621152334.30139-1-laurent.pinchart@ideasonboard.com>", "date": "2024-06-21T15:23:34", "name": "ipa: libipa: matrix: Fix incorrect symbol namespace", "commit_ref": "2119bdac6a011034cc33584e3303e47db4932313", "pull_url": null, "state": "accepted", "archived": false, "hash": "15348dc417984b964596f750e140a6c5c9354b51", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20361/mbox/", "series": [ { "id": 4411, "url": "https://patchwork.libcamera.org/api/1.1/series/4411/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4411", "date": "2024-06-21T15:23:34", "name": "ipa: libipa: matrix: Fix incorrect symbol namespace", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4411/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20361/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20361/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7354BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 21 Jun 2024 15:23:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E786654A9;\n\tFri, 21 Jun 2024 17:23:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9364D654A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Jun 2024 17:23:56 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 933BDB3;\n\tFri, 21 Jun 2024 17:23:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fttr/51V\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718983416;\n\tbh=9vzoMIsO+tFhw/C/Mzece64Exw7cMs1ChgQn+wleU+w=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=fttr/51VchdNOa5lhXxpHB7D5yswaOX/3zJYv4lfP0MsS2ur/55orgPBUFuaOwwcw\n\tKkNX2sRoRoUX2Pp5ZS91tzAg4h0R4VLqHik2zN/BdDmO+VudTmKbqcBQWEyLBwmvGF\n\tznUWS/vmUE2NqSHqVUe7ISL3WXU+d4kmND/e+6HQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace", "Date": "Fri, 21 Jun 2024 18:23:34 +0300", "Message-ID": "<20240621152334.30139-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The matrixVlidateYaml() function is declared in the libcamera::ipa::\nnamespace, but defined in the libcamera:: namespace. This causes a\ndynamic linking error at runtime. Fix it by moving the function\ndefinition.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/matrix.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/libipa/matrix.cpp b/src/ipa/libipa/matrix.cpp\nindex 7f000382d33b..8346f0d34160 100644\n--- a/src/ipa/libipa/matrix.cpp\n+++ b/src/ipa/libipa/matrix.cpp\n@@ -122,8 +122,6 @@ namespace ipa {\n * \\return Matrix sum of matrices \\a m1 and \\a m2\n */\n \n-} /* namespace ipa */\n-\n #ifndef __DOXYGEN__\n /*\n * The YAML data shall be a list of numerical values. Its size shall be equal\n@@ -146,4 +144,6 @@ bool matrixValidateYaml(const YamlObject &obj, unsigned int size)\n }\n #endif /* __DOXYGEN__ */\n \n+} /* namespace ipa */\n+\n } /* namespace libcamera */\n", "prefixes": [] }