Patch Detail
Show a patch.
GET /api/1.1/patches/20351/?format=api
{ "id": 20351, "url": "https://patchwork.libcamera.org/api/1.1/patches/20351/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20351/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240617232525.878530-3-kieran.bingham@ideasonboard.com>", "date": "2024-06-17T23:25:24", "name": "[2/3] ipa: simple: Report the ColourGains in metadata", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5b80ae6edd7ed191990bb0cb0525aa28ea91f934", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20351/mbox/", "series": [ { "id": 4405, "url": "https://patchwork.libcamera.org/api/1.1/series/4405/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4405", "date": "2024-06-17T23:25:22", "name": "ipa: simple: Introduce metadata reporting", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4405/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20351/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20351/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35FB8BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Jun 2024 23:25:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 767BB65498;\n\tTue, 18 Jun 2024 01:25:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 879FA6548B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Jun 2024 01:25:29 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 40555DD9;\n\tTue, 18 Jun 2024 01:25:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GDM6U9pB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718666712;\n\tbh=R12+deRfTEHoHMFdRNStxNheQe4WfA4EzGBJahshAnc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GDM6U9pBGota1jXYNlnmU7Rz27cWu7fO/ffUBf/I4tUXs7ZXFRdwpbPoWCd522l7m\n\tp8vvbBK32bqEtxm9tO2afj8Lea8I///ltNoTQthKwNOSg6PNTJbPP/rMyHNObnBkK8\n\txoZYeh8o2BJEHBaCOY9mjpxhly95dEBjWMHKPYDc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH 2/3] ipa: simple: Report the ColourGains in metadata", "Date": "Tue, 18 Jun 2024 00:25:24 +0100", "Message-Id": "<20240617232525.878530-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240617232525.878530-1-kieran.bingham@ideasonboard.com>", "References": "<20240617232525.878530-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide the determined colour gains back into the metadata\nto add to completed requests.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/simple/soft_simple.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 09c7b575301e..d35d28c26a3b 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -305,6 +305,10 @@ void IPASoftSimple::processStats(const ControlList &sensorControls)\n \t\tparams_->blue[i] = gammaTable_[idx];\n \t}\n \n+\tconst float maxGain = 1024.0;\n+\tconst float gains[] = { gainR / maxGain, gainB / maxGain };\n+\tmetadata.set(controls::ColourGains, gains);\n+\n \tsetIspParams.emit(metadata);\n \n \t/* \\todo Switch to the libipa/algorithm.h API someday. */\n", "prefixes": [ "2/3" ] }