Patch Detail
Show a patch.
GET /api/1.1/patches/20332/?format=api
{ "id": 20332, "url": "https://patchwork.libcamera.org/api/1.1/patches/20332/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20332/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240616163910.5506-5-laurent.pinchart@ideasonboard.com>", "date": "2024-06-16T16:39:02", "name": "[04/12] ipa: rkisp1: Document all AGC parameters in IPAActiveState", "commit_ref": "c414ff9ec26fb02b8e31dfa9f969870466a6d522", "pull_url": null, "state": "accepted", "archived": false, "hash": "e2dc3c8087cb1a97ff49ce0f34652d92cdf9292e", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20332/mbox/", "series": [ { "id": 4400, "url": "https://patchwork.libcamera.org/api/1.1/series/4400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4400", "date": "2024-06-16T16:38:58", "name": "ipa: rkisp1: Miscellaneous AGC fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20332/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20332/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B236DC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 16 Jun 2024 16:39:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45A5F654A5;\n\tSun, 16 Jun 2024 18:39:49 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07ADD65456\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 16 Jun 2024 18:39:37 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9624669\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 16 Jun 2024 18:39:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k4Jq5xve\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718555960;\n\tbh=eaX8jpG3xNBuwdiaUqx/PYZYVBl1gQMkN9FvmnkPYso=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=k4Jq5xveFcxFinyvqQtHALUQnm0OBTQlKygNpt0wkOAs84HOciN/avLGgTg4P+R8Z\n\t8gQ4ixlg+TaImUc0FflwgDnnHgNJjvrzjp9ftZGHaA4Ytf8sAfBlcc4JZSxnxiN/In\n\tA68G7QkoQJbP2k3TVCbxnjH61mYEm9pPUafegPis=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 04/12] ipa: rkisp1: Document all AGC parameters in\n\tIPAActiveState", "Date": "Sun, 16 Jun 2024 19:39:02 +0300", "Message-ID": "<20240616163910.5506-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>", "References": "<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPAActiveState AGC documentation is lagging behind the\nimplementation and misses many variables. Document them.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/ipa_context.cpp | 40 +++++++++++++++++++++++++++++-----\n 1 file changed, 35 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex 65e0c58cb2ca..c4895479204c 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -137,13 +137,43 @@ namespace libcamera::ipa::rkisp1 {\n * \\var IPAActiveState::agc\n * \\brief State for the Automatic Gain Control algorithm\n *\n- * The exposure and gain are the latest values computed by the AGC algorithm.\n+ * The \\a automatic variables track the latest values computed by algorithm\n+ * based on the latest processed statistics. All other variables track the\n+ * consolidated controls requested in queued requests.\n *\n- * \\var IPAActiveState::agc.exposure\n- * \\brief Exposure time expressed as a number of lines\n+ * \\struct IPAActiveState::agc.manual\n+ * \\brief Manual exposure time and analog gain (set through requests)\n *\n- * \\var IPAActiveState::agc.gain\n- * \\brief Analogue gain multiplier\n+ * \\var IPAActiveState::agc.manual.exposure\n+ * \\brief Manual exposure time expressed as a number of lines as set by the\n+ * ExposureTime control\n+ *\n+ * \\var IPAActiveState::agc.manual.gain\n+ * \\brief Manual analogue gain as set by the AnalogueGain control\n+ *\n+ * \\struct IPAActiveState::agc.automatic\n+ * \\brief Automatic exposure time and analog gain (computed by the algorithm)\n+ *\n+ * \\var IPAActiveState::agc.automatic.exposure\n+ * \\brief Automatic exposure time expressed as a number of lines\n+ *\n+ * \\var IPAActiveState::agc.automatic.gain\n+ * \\brief Automatic analogue gain multiplier\n+ *\n+ * \\var IPAActiveState::agc.autoEnabled\n+ * \\brief Manual/automatic AGC state as set by the AeEnable control\n+ *\n+ * \\var IPAActiveState::agc.constraintMode\n+ * \\brief Constraint mode as set by the AeConstraintMode control\n+ *\n+ * \\var IPAActiveState::agc.exposureMode\n+ * \\brief Exposure mode as set by the AeExposureMode control\n+ *\n+ * \\var IPAActiveState::agc.meteringMode\n+ * \\brief Metering mode as set by the AeMeteringMode control\n+ *\n+ * \\var IPAActiveState::agc.maxShutterSpeed\n+ * \\brief Maximum frame duration as set by the FrameDurationLimits control\n */\n \n /**\n", "prefixes": [ "04/12" ] }