Patch Detail
Show a patch.
GET /api/1.1/patches/2028/?format=api
{ "id": 2028, "url": "https://patchwork.libcamera.org/api/1.1/patches/2028/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2028/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190927024417.725906-5-niklas.soderlund@ragnatech.se>", "date": "2019-09-27T02:44:08", "name": "[libcamera-devel,v3,04/13] libcamera: request: Allow read only access to controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "17c9ef2047f1519ccb2c303a964bcf3d1b132eef", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2028/mbox/", "series": [ { "id": 508, "url": "https://patchwork.libcamera.org/api/1.1/series/508/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=508", "date": "2019-09-27T02:44:04", "name": "libcamera: ipa: Add basic IPA support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/508/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2028/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2028/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 080C261919\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Sep 2019 04:45:26 +0200 (CEST)", "from bismarck.berto.se (unknown [84.172.88.101])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid cd30da6a-e0d0-11e9-bdc3-005056917a89;\n\tFri, 27 Sep 2019 04:45:01 +0200 (CEST)" ], "X-Halon-ID": "cd30da6a-e0d0-11e9-bdc3-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Sep 2019 04:44:08 +0200", "Message-Id": "<20190927024417.725906-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20190927024417.725906-1-niklas.soderlund@ragnatech.se>", "References": "<20190927024417.725906-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/13] libcamera: request: Allow read\n\tonly access to controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 27 Sep 2019 02:45:27 -0000" }, "content": "Allow the controls in a Request to be examined from a const\nenvironment.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/request.h | 1 +\n src/libcamera/request.cpp | 6 ++++++\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 9edf1cedc054014f..5eb012e41b4a377b 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -37,6 +37,7 @@ public:\n \t~Request();\n \n \tControlList &controls() { return controls_; }\n+\tconst ControlList &controls() const { return controls_; }\n \tconst std::map<Stream *, Buffer *> &buffers() const { return bufferMap_; }\n \tint addBuffer(std::unique_ptr<Buffer> buffer);\n \tBuffer *findBuffer(Stream *stream) const;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex ee2158fc7a9cf0b9..ebae99b07c696512 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -84,6 +84,12 @@ Request::~Request()\n * \\return A reference to the ControlList in this request\n */\n \n+/**\n+ * \\fn Request::controls() const\n+ * \\brief Retrieve the request's ControlList\n+ * \\sa Request::controls()\n+ */\n+\n /**\n * \\fn Request::buffers()\n * \\brief Retrieve the request's streams to buffers map\n", "prefixes": [ "libcamera-devel", "v3", "04/13" ] }