Patch Detail
Show a patch.
GET /api/1.1/patches/20273/?format=api
{ "id": 20273, "url": "https://patchwork.libcamera.org/api/1.1/patches/20273/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20273/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240613013944.23344-2-laurent.pinchart@ideasonboard.com>", "date": "2024-06-13T01:39:34", "name": "[01/11] libcamera: yaml_parser: Drop std::enable_if_t guards for get() function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e25ae2a648ee9064aa9c24e94bfa416ba42cc64e", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20273/mbox/", "series": [ { "id": 4386, "url": "https://patchwork.libcamera.org/api/1.1/series/4386/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4386", "date": "2024-06-13T01:39:33", "name": "ipa: libipa: Vector and Pwl improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4386/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20273/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20273/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 172CCC3293\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Jun 2024 01:40:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91F2065493;\n\tThu, 13 Jun 2024 03:40:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20BA961A1C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Jun 2024 03:40:06 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D2BABEB;\n\tThu, 13 Jun 2024 03:39:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YuJdYE3w\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718242792;\n\tbh=JRMOX4Cldgs+BbgWKYJ9CEDPYTbUVo4Bnn1TgyrmbL4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YuJdYE3w1YJ5FIFoiq2BiQIYqjQk1dAPA67uzWeZw/AU95YuW9954PGb1WlaWlfBG\n\taRnx6dZMIIy2agnllsahlqinYNAz/TuSlWZe7jVA04dUXc7dpu6aQVj32gweZ3EkTU\n\tLgk7Y8uAekHEP2lMQm/bfS8WmoXZMPjLJKIum/ws=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tNaushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH 01/11] libcamera: yaml_parser: Drop std::enable_if_t guards\n\tfor get() function", "Date": "Thu, 13 Jun 2024 04:39:34 +0300", "Message-ID": "<20240613013944.23344-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240613013944.23344-1-laurent.pinchart@ideasonboard.com>", "References": "<20240613013944.23344-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The YamlObject::get() function template is implemented for a set of\nbasic types through template specializations. The function declaration\nuses std::enable_if_t<> guards to signal incorrect usage at compilation\ntime. This however prevents the API to be extended with additional\nspecializations in other compilation units.\n\nTo prepare for new specializations of the function for the ipa::Vector\nand ipa::Pwl classes types, implemented in their respective compilation\nunits, drop the std::enable_it_t<> guards. Incorrect usage will still be\nreported as link errors.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/yaml_parser.h | 15 ---------------\n 1 file changed, 15 deletions(-)", "diff": "diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\nindex 3ac27e06f69d..81cc0e25ae0f 100644\n--- a/include/libcamera/internal/yaml_parser.h\n+++ b/include/libcamera/internal/yaml_parser.h\n@@ -161,22 +161,7 @@ public:\n \n \tstd::size_t size() const;\n \n-#ifndef __DOXYGEN__\n-\ttemplate<typename T,\n-\t\t std::enable_if_t<\n-\t\t\t std::is_same_v<bool, T> ||\n-\t\t\t std::is_same_v<double, T> ||\n-\t\t\t std::is_same_v<int8_t, T> ||\n-\t\t\t std::is_same_v<uint8_t, T> ||\n-\t\t\t std::is_same_v<int16_t, T> ||\n-\t\t\t std::is_same_v<uint16_t, T> ||\n-\t\t\t std::is_same_v<int32_t, T> ||\n-\t\t\t std::is_same_v<uint32_t, T> ||\n-\t\t\t std::is_same_v<std::string, T> ||\n-\t\t\t std::is_same_v<Size, T>> * = nullptr>\n-#else\n \ttemplate<typename T>\n-#endif\n \tstd::optional<T> get() const;\n \n \ttemplate<typename T, typename U>\n", "prefixes": [ "01/11" ] }