Patch Detail
Show a patch.
GET /api/1.1/patches/20237/?format=api
{ "id": 20237, "url": "https://patchwork.libcamera.org/api/1.1/patches/20237/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20237/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240607082045.2718555-1-paul.elder@ideasonboard.com>", "date": "2024-06-07T08:20:45", "name": "ipa: libipa: vector: Add matrix-vector multiplication", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a98aceba57b946144916fbaebf852d31b812b6fa", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20237/mbox/", "series": [ { "id": 4374, "url": "https://patchwork.libcamera.org/api/1.1/series/4374/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4374", "date": "2024-06-07T08:20:45", "name": "ipa: libipa: vector: Add matrix-vector multiplication", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4374/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20237/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20237/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AA4AC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 7 Jun 2024 08:20:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF3596545E;\n\tFri, 7 Jun 2024 10:20:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BEA365457\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 7 Jun 2024 10:20:54 +0200 (CEST)", "from neptunite.hamster-moth.ts.net\n\t(h175-177-049-156.catv02.itscom.jp [175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B674029F;\n\tFri, 7 Jun 2024 10:20:43 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MmAt+OQZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717748444;\n\tbh=JTlitEFtVtIy9IiWSvD7xcGZkoadTjGxPdtsT43+Uts=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=MmAt+OQZyJPGRveiVqrvanLBgyfwhdpa1YAGiKA11xwzv+/u4+EVR8F19WH9rzGdT\n\tRgFPifcIWvTFXXvW3/gbkQFSqMUcHWmUeMUoJPcjHzN+WI7ccdt+kUEiC1qi81dxz9\n\tS93OK9uAan6Pn4Hlh9+WAxyOmFOun3gAFmtWzCwI=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] ipa: libipa: vector: Add matrix-vector multiplication", "Date": "Fri, 7 Jun 2024 17:20:45 +0900", "Message-Id": "<20240607082045.2718555-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an operation for multiplying a matrix with a vector.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nDepends on v6 of \"ipa: libipa: Add Matrix class\" and v5 of \"ipa: libipa:\nAdd Vector class\"\n---\n src/ipa/libipa/vector.cpp | 12 ++++++++++++\n src/ipa/libipa/vector.h | 22 ++++++++++++++++++++++\n 2 files changed, 34 insertions(+)", "diff": "diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex bdc3c447c..e18426fe5 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -145,6 +145,18 @@ namespace ipa {\n * \\return The length of the vector\n */\n \n+/**\n+ * \\fn Vector<T, R1> operator*(const Matrix<T, R1, C1> &m, const Vector<T, R2> &v)\n+ * \\brief Multiply a matrix by a vector\n+ * \\tparam T Numerical type of the contents of the matrix and vector\n+ * \\tparam R1 The number of rows in the matrix\n+ * \\tparam C1 The number of colums in the matrix\n+ * \\tparam R2 The number of elements in the vector\n+ * \\param m The matrix\n+ * \\param v The vector\n+ * \\return Product of matrix \\a m and vector \\a v\n+ */\n+\n /**\n * \\fn bool operator==(const Vector<T, R> &lhs, const Vector<T, R> &rhs)\n * \\brief Compare vectors for equality\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 87aad28b5..934b44494 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -17,6 +17,8 @@\n \n #include \"libcamera/internal/yaml_parser.h\"\n \n+#include \"matrix.h\"\n+\n namespace libcamera {\n \n LOG_DECLARE_CATEGORY(Vector)\n@@ -166,6 +168,26 @@ private:\n \tstd::array<T, R> data_;\n };\n \n+#ifndef __DOXYGEN__\n+template<typename T,\n+\t unsigned int R1, unsigned int C1,\n+\t unsigned int R2,\n+\t std::enable_if_t<std::is_arithmetic_v<T> && C1 == R2> * = nullptr>\n+#endif /* __DOXYGEN__ */\n+Vector<T, R1> operator*(const Matrix<T, R1, C1> &m, const Vector<T, R2> &v)\n+{\n+\tVector<T, R1> result;\n+\n+\tfor (unsigned int i = 0; i < R1; i++) {\n+\t\tT sum = 0;\n+\t\tfor (unsigned int j = 0; j < C1; j++)\n+\t\t\tsum += m[i][j] * v[j];\n+\t\tresult[i] = sum;\n+\t}\n+\n+\treturn result;\n+}\n+\n #ifndef __DOXYGEN__\n template<typename T, unsigned int R,\n \t std::enable_if_t<std::is_arithmetic_v<T>> * = nullptr>\n", "prefixes": [] }