Patch Detail
Show a patch.
GET /api/1.1/patches/20193/?format=api
{ "id": 20193, "url": "https://patchwork.libcamera.org/api/1.1/patches/20193/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20193/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240603140806.90045-2-stefan.klug@ideasonboard.com>", "date": "2024-06-03T14:06:28", "name": "[v3,1/3] libcamera: Add gamma control id", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8c2942eb3bd3f6dbff3e33e08ec402c5e233c2c7", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20193/mbox/", "series": [ { "id": 4354, "url": "https://patchwork.libcamera.org/api/1.1/series/4354/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4354", "date": "2024-06-03T14:06:27", "name": "libcamera: Add gamma control for rkisp1", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4354/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20193/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20193/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9AA1BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Jun 2024 14:08:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BC99634CD;\n\tMon, 3 Jun 2024 16:08:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54DBA634B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Jun 2024 16:08:43 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6067:153a:95aa:2e07])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55E43BC0;\n\tMon, 3 Jun 2024 16:08:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H3FIKxTb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717423716;\n\tbh=sdNvzbOEJC0veHQ5FTjS/q4Opfi5ToQeXw7PVHyzrm4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=H3FIKxTbHg1bXR9bqcX9gLzPmrJFfE4b/TQcsSB9K3ZzG3fMCo5dw406+gc1SXRrE\n\tKMF8EPMpKxLxzRgThNVFoY7ZLFVANH0bUgmizbDRtS0QypP+Gj5NM3bAjc+F8tNfiM\n\tDk5VutvOBjGPB5oNe/7tpgBIXdislSCYhNbSifyg=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 1/3] libcamera: Add gamma control id", "Date": "Mon, 3 Jun 2024 16:06:28 +0200", "Message-ID": "<20240603140806.90045-2-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240603140806.90045-1-stefan.klug@ideasonboard.com>", "References": "<20240603140806.90045-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A camera gamma of roughly 2.2 is necessary to produce correct output\nimages on a standard monitor. Add a control for that.\n\nFurther information is available here:\nhttps://en.wikipedia.org/wiki/SRGB\nhttps://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nv2 -> v3:\n- no changes\n\nv1 -> v2:\n- small change in description\n\n src/libcamera/control_ids_core.yaml | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex bf1f1a83..303b0d32 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -243,6 +243,13 @@ controls:\n Specify a fixed contrast parameter. Normal contrast is given by the\n value 1.0; larger values produce images with more contrast.\n \n+ - Gamma:\n+ type: float\n+ description: |\n+ Specify a fixed gamma value. Default must be 2.2 which closely mimics \n+ sRGB gamma. Note that this is camera gamma, so it is applied as \n+ 1.0/gamma\n+\n - Lux:\n type: float\n description: |\n", "prefixes": [ "v3", "1/3" ] }