Patch Detail
Show a patch.
GET /api/1.1/patches/20186/?format=api
{ "id": 20186, "url": "https://patchwork.libcamera.org/api/1.1/patches/20186/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20186/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240603094209.13921-1-naush@raspberrypi.com>", "date": "2024-06-03T09:42:09", "name": "ipa: rpi: Disable StatsOutputEnable control by default", "commit_ref": "98071d3109c131820439f61d9380c0bd4cd2119a", "pull_url": null, "state": "accepted", "archived": false, "hash": "7707c97b92476f956ba5d7868433beb42ce4ef9a", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20186/mbox/", "series": [ { "id": 4351, "url": "https://patchwork.libcamera.org/api/1.1/series/4351/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4351", "date": "2024-06-03T09:42:09", "name": "ipa: rpi: Disable StatsOutputEnable control by default", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4351/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20186/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20186/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3616EBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Jun 2024 09:42:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F959634CB;\n\tMon, 3 Jun 2024 11:42:17 +0200 (CEST)", "from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76224634AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Jun 2024 11:42:15 +0200 (CEST)", "by mail-wr1-x435.google.com with SMTP id\n\tffacd0b85a97d-35e1fcd0c0fso2203504f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 03 Jun 2024 02:42:15 -0700 (PDT)", "from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-35dd04cada4sm8269532f8f.40.2024.06.03.02.42.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 03 Jun 2024 02:42:14 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"U/abV3Mx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1717407735; x=1718012535;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=rWGcY0BdCbZuLjGVkZCh+0YomNXKNzqakdUYCS6xl1I=;\n\tb=U/abV3MxPT94BxKogVkEv06Xyqy+3UxBUlvMt3440uhNjDWakjul60cYTfn9slSQCB\n\tN99Q8WNvX7gfIaSDQH3m/BHKX6sjfJKZeeUsWBSU8L15iDJkBKhC9MFMgowWCNxOnBAt\n\tSdm4Mu97rVWpUIlBbduGoyD8VWdZnrCowyl3/YVQEhHa+kAQoD0I7+hy50VnxT90Qn0j\n\tigpJvCIkPyfWLyjRocQUQAGmtOcuureFompOZ2Yw6qhhlWfTknQKWRN4LBJLNElE5l2M\n\tDLVZlXlgmZbDhK2aO9ha+Slw1WukxdP6v2FK2HOx5GhBCVv08Jqv/nimkyfB6NoX9/bA\n\t4yxw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1717407735; x=1718012535;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=rWGcY0BdCbZuLjGVkZCh+0YomNXKNzqakdUYCS6xl1I=;\n\tb=HV0aRKJLM0FF7Ds5mWeMzwVAC6rdFdlocss0bZCV4ucWQu2Ja3ihalFBba7bpug2RF\n\tNHI4PJYeltZytEiiE/ACmtn2TbhqkPz/ngdQZszHAV6KxSPQkbdLwGysqVV6serQrpNJ\n\t4sqrWYi8I+/Tm/PmZ5d/pB7V72rv/St+rIHw+kJJHErK2kGyciemN5uHrpAQZbSPDp3Q\n\t8gu30/wUAPp6ZuJOsCB0y+A0B5ZF4qnXAYnhMxua4ESeh2CiGLM1+aROriAsEYgSgiB/\n\tLDl3VC6oCrJvlHP4zwXaiCe7Zdw0takNAwvBAJOruJEyJVsgM0F8r26DWWLb3SFbyJzn\n\tUWOQ==", "X-Gm-Message-State": "AOJu0YxJoVJ8mFbyj76+E+UOs9a2VvXtOtdUFyFXrwqxuqnqM4FUT2Me\n\tl6goBn1C5TZj7a+RECZ/sHRlMeT1rQk7QcHthcxnOpx6eH5T+Ik9MbBr6TxQ/knNmqkLQ5YggNc\n\te", "X-Google-Smtp-Source": "AGHT+IEzhLT1SZnAI4kmYQg0uY3hZ/UXfbfqr+MyfgcD6vstLZ5564tjOCwsYVUo3tBla+mBHD3n0Q==", "X-Received": "by 2002:a05:6000:1754:b0:354:f6ea:3f88 with SMTP id\n\tffacd0b85a97d-35e0f2599fdmr5298575f8f.1.1717407734563; \n\tMon, 03 Jun 2024 02:42:14 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH] ipa: rpi: Disable StatsOutputEnable control by default", "Date": "Mon, 3 Jun 2024 10:42:09 +0100", "Message-Id": "<20240603094209.13921-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Set the default value of controls::rpi::StatsOutputEnable to false,\ndisabling the functionality. This stops unnecessary copies of the\nstatistics output ending up in the Request metdata if not needed.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 1d12262bda01..6fb90209aa0f 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -73,7 +73,7 @@ const ControlInfoMap::Map ipaControls{\n \t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n \t{ &controls::FrameDurationLimits, ControlInfo(INT64_C(33333), INT64_C(120000)) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n-\t{ &controls::rpi::StatsOutputEnable, ControlInfo(false, true) },\n+\t{ &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) },\n };\n \n /* IPA controls handled conditionally, if the sensor is not mono */\n@@ -103,8 +103,9 @@ LOG_DEFINE_CATEGORY(IPARPI)\n namespace ipa::RPi {\n \n IpaBase::IpaBase()\n-\t: controller_(), frameLengths_(FrameLengthsQueueSize, 0s), stitchSwapBuffers_(false), frameCount_(0),\n-\t mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s })\n+\t: controller_(), frameLengths_(FrameLengthsQueueSize, 0s), statsMetadataOutput_(false),\n+\t stitchSwapBuffers_(false), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0),\n+\t firstStart_(true), flickerState_({ 0, 0s })\n {\n }\n \n", "prefixes": [] }