Patch Detail
Show a patch.
GET /api/1.1/patches/20185/?format=api
{ "id": 20185, "url": "https://patchwork.libcamera.org/api/1.1/patches/20185/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20185/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240601235740.14594-1-laurent.pinchart@ideasonboard.com>", "date": "2024-06-01T23:57:40", "name": "test: ipa: rkisp1-utils: Fix coding style for template arguments", "commit_ref": "1020b6be51f4475a2016d93799af5753014157fa", "pull_url": null, "state": "accepted", "archived": false, "hash": "92c32f20386036d2b0b85fbfb075fbccaeae047b", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20185/mbox/", "series": [ { "id": 4350, "url": "https://patchwork.libcamera.org/api/1.1/series/4350/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4350", "date": "2024-06-01T23:57:40", "name": "test: ipa: rkisp1-utils: Fix coding style for template arguments", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4350/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20185/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20185/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C546BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 1 Jun 2024 23:57:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D123634BA;\n\tSun, 2 Jun 2024 01:57:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9F1161A46\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 2 Jun 2024 01:57:54 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4F8039F;\n\tSun, 2 Jun 2024 01:57:48 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MBG0smVV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717286268;\n\tbh=jp96h1r9TeIzpsVlob8+C+AxBNeaQWiGp6NNOSNwVBk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=MBG0smVVSSvVsDj0nVmiDk8E7qXqBxzIK+P6e8A0U0kProdwRIxmTXTykpfLgrBh2\n\tLkQ5UKQGHmBBMvHT1pmK/yQxy0XfvdTxXIEo8qEq0gzKks/41ctLKa1UoXzz6gwzNj\n\tqDZWmtO4/9YRQl/SQ0Y8slYf1de+VXeA+r8CLvX8=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] test: ipa: rkisp1-utils: Fix coding style for template\n\targuments", "Date": "Sun, 2 Jun 2024 02:57:40 +0300", "Message-ID": "<20240601235740.14594-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The coding style names template arguments using CamelCase with an\nuppercase initial letter. Fix the template arguments in the rkisp1-utils\ntest.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/ipa/rkisp1/rkisp1-utils.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\n\nbase-commit: aad5837d70f8d3dc19f62f88f1434e3c9cf5ffbe", "diff": "diff --git a/test/ipa/rkisp1/rkisp1-utils.cpp b/test/ipa/rkisp1/rkisp1-utils.cpp\nindex 9fff0cdcef15..e48f8d3622d2 100644\n--- a/test/ipa/rkisp1/rkisp1-utils.cpp\n+++ b/test/ipa/rkisp1/rkisp1-utils.cpp\n@@ -21,10 +21,10 @@ using namespace ipa::rkisp1;\n class RkISP1UtilsTest : public Test\n {\n protected:\n-\ttemplate<unsigned int intPrec, unsigned fracPrec, typename T>\n+\ttemplate<unsigned int IntPrec, unsigned FracPrec, typename T>\n \tint testSingleFixedPoint(double input, T expected)\n \t{\n-\t\tT ret = utils::floatingToFixedPoint<intPrec, fracPrec, T>(input);\n+\t\tT ret = utils::floatingToFixedPoint<IntPrec, FracPrec, T>(input);\n \t\tif (ret != expected) {\n \t\t\tcerr << \"Expected \" << input << \" to convert to \"\n \t\t\t << expected << \", got \" << ret << std::endl;\n@@ -35,7 +35,7 @@ protected:\n \t\t * The precision check is fairly arbitrary but is based on what\n \t\t * the rkisp1 is capable of in the crosstalk module.\n \t\t */\n-\t\tdouble f = utils::fixedToFloatingPoint<intPrec, fracPrec, double>(ret);\n+\t\tdouble f = utils::fixedToFloatingPoint<IntPrec, FracPrec, double>(ret);\n \t\tif (std::abs(f - input) > 0.005) {\n \t\t\tcerr << \"Reverse conversion expected \" << ret\n \t\t\t << \" to convert to \" << input\n", "prefixes": [] }