Patch Detail
Show a patch.
GET /api/1.1/patches/20114/?format=api
{ "id": 20114, "url": "https://patchwork.libcamera.org/api/1.1/patches/20114/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20114/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240529070248.12186-3-umang.jain@ideasonboard.com>", "date": "2024-05-29T07:02:46", "name": "[v2,2/4] libcamera: software_isp: Drop unnecessary sanity check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9809a54e0fb1ea11a51b4081956c256b3152728a", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20114/mbox/", "series": [ { "id": 4331, "url": "https://patchwork.libcamera.org/api/1.1/series/4331/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4331", "date": "2024-05-29T07:02:44", "name": "libcamera: converter: Replace usage of stream index by Stream pointer", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4331/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20114/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20114/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C863BBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 29 May 2024 07:03:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6942D634B0;\n\tWed, 29 May 2024 09:03:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44EE961A46\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 May 2024 09:03:02 +0200 (CEST)", "from fedora.local (unknown\n\t[IPv6:2409:4055:4e99:4251:f523:b915:4362:f847])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3EEC3A27;\n\tWed, 29 May 2024 09:02:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RlYcCaYd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716966179;\n\tbh=HtY7NcD0sF9ta2WAQdJt0lftJCBXNGToH9ZxLoTt95M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RlYcCaYd9sZ7faVwgWWktA40QPXvp4OSobo9gpb0QbFg6K9hctvzdZIc1xeWhTOtF\n\tZp22LM9lH6aoaRuxrKxbTk4O7dGL+BVZ1GF5CjcKghLxEQVn6xnjOo00iBJHgTbTCi\n\tD8bPrzUVpGWbn8JxYq+ekfeLvS9YwgNzfTkcuODI=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tAndrey Konovalov <andrey.konovalov@linaro.org>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v2 2/4] libcamera: software_isp: Drop unnecessary sanity\n\tcheck", "Date": "Wed, 29 May 2024 12:32:46 +0530", "Message-ID": "<20240529070248.12186-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<20240529070248.12186-1-umang.jain@ideasonboard.com>", "References": "<20240529070248.12186-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Currently the soft-isp outputs a single output stream. Hence,\ndrop the unnecessary check for stream indexes.\n\nAnother reason to drop is actually the stream indexes is meant to be\nunique in outputs std::map<>, hence checking for unique stream indexes\nis redundant.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/software_isp/software_isp.cpp | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex c9b6be56..ac10d82d 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -267,12 +267,9 @@ int SoftwareIsp::exportBuffers(unsigned int output, unsigned int count,\n int SoftwareIsp::queueBuffers(FrameBuffer *input,\n \t\t\t const std::map<unsigned int, FrameBuffer *> &outputs)\n {\n-\tunsigned int mask = 0;\n-\n \t/*\n \t * Validate the outputs as a sanity check: at least one output is\n-\t * required, all outputs must reference a valid stream and no two\n-\t * outputs can reference the same stream.\n+\t * required, all outputs must reference a valid stream.\n \t */\n \tif (outputs.empty())\n \t\treturn -EINVAL;\n@@ -282,10 +279,6 @@ int SoftwareIsp::queueBuffers(FrameBuffer *input,\n \t\t\treturn -EINVAL;\n \t\tif (index >= 1) /* only single stream atm */\n \t\t\treturn -EINVAL;\n-\t\tif (mask & (1 << index))\n-\t\t\treturn -EINVAL;\n-\n-\t\tmask |= 1 << index;\n \t}\n \n \tprocess(input, outputs.at(0));\n", "prefixes": [ "v2", "2/4" ] }