Patch Detail
Show a patch.
GET /api/1.1/patches/20100/?format=api
{ "id": 20100, "url": "https://patchwork.libcamera.org/api/1.1/patches/20100/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20100/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240525165053.46330-1-pobrn@protonmail.com>", "date": "2024-05-25T16:50:55", "name": "[v1] android: camera_capabilities: Fix GCC 14 warning", "commit_ref": "c79fa47aac9b38865dab5e9f29030903bf460c46", "pull_url": null, "state": "accepted", "archived": false, "hash": "2b4c24456ff8469116a6e75c99f3b80f3de4c6e3", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20100/mbox/", "series": [ { "id": 4326, "url": "https://patchwork.libcamera.org/api/1.1/series/4326/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4326", "date": "2024-05-25T16:50:55", "name": "[v1] android: camera_capabilities: Fix GCC 14 warning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4326/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20100/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20100/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79D75BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 25 May 2024 16:51:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DC86634AF;\n\tSat, 25 May 2024 18:51:12 +0200 (CEST)", "from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CCE261A47\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 25 May 2024 18:51:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"usT8N9af\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1716655860; x=1716915060;\n\tbh=xTR0sL9+RSp7W3ozwYHV74e0uRhqB2FJCVMwI1q1oqE=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=usT8N9af4uh072yHSDDrDoEvQKHvZgsYFFf0yC22Jl4XVbNAozY/9hlaoR2g8V7EU\n\tuagqBOBpfyOxHZHIkYKHq4m5xB9MtimJ5e/f5aLDA/UMSqfZvi3c57uSflEGcsdbr3\n\tDIuw9T2OnWKU4/QbMwVFZek7+snOxbmkC8zZJsgP/r4b3aHcg1eTuMRvnuz26Yjh/V\n\tmY+HRm6LdB5uNzl2PaZH/YixI5bpPu06n9Y/1/erj+UQ2Mhhm9d/Ng4B/5IYOrrb/o\n\tRJysOZHDf9q6Y1yHlkvkIy/BdzRaFmdmrOXqZ2tTkClKuHVluMisnDNLkJuQvGLeYB\n\t4d/k/Z4Q/On4w==", "Date": "Sat, 25 May 2024 16:50:55 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH v1] android: camera_capabilities: Fix GCC 14 warning", "Message-ID": "<20240525165053.46330-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "cb318b70f856f97dd70fb09f80ff5ec77adfd1e5", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "GCC 14 thinks `rects` is a \"possibly dangling reference to a temporary\",\nwhich causes the compilation to fail due to the use of `-Werror`.\n\nFix this by not using a reference.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/android/camera_capabilities.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 6f4d48de..71043e12 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1081,7 +1081,7 @@ int CameraCapabilities::initializeStaticMetadata()\n \t}\n \n \t{\n-\t\tconst Span<const Rectangle> &rects =\n+\t\tconst Span<const Rectangle> rects =\n \t\t\tproperties.get(properties::PixelArrayActiveAreas).value_or(Span<const Rectangle>{});\n \t\tstd::vector<int32_t> data{\n \t\t\tstatic_cast<int32_t>(rects[0].x),\n", "prefixes": [ "v1" ] }