Patch Detail
Show a patch.
GET /api/1.1/patches/20081/?format=api
{ "id": 20081, "url": "https://patchwork.libcamera.org/api/1.1/patches/20081/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20081/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240520120110.110067-3-umang.jain@ideasonboard.com>", "date": "2024-05-20T12:01:10", "name": "[2/2] apps: qcam: Add option to configure sensor", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "8ae77f4e8a8a452c2fef61b1ca8d66b2cca04b9c", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20081/mbox/", "series": [ { "id": 4320, "url": "https://patchwork.libcamera.org/api/1.1/series/4320/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4320", "date": "2024-05-20T12:01:08", "name": "apps: Add option to configure sensor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4320/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20081/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20081/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA5C4C322E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 May 2024 12:01:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6CCE63481;\n\tMon, 20 May 2024 14:01:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E71DB63481\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 May 2024 14:01:20 +0200 (CEST)", "from fedora.local (unknown\n\t[IPv6:2405:201:2015:f873:c173:4b:4a04:3a21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ABB36593;\n\tMon, 20 May 2024 14:01:08 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mkKda7Bt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716206469;\n\tbh=bYFUcPzCfZYsOxJmEAwN9C8yVOH0QZ40cxlffmO0zLc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mkKda7BtaslyQmUyN1T5bOMbBeM6U9U6ZE/3G1SjBZ2Zu6VxQT5Hm9aM1abWwaCji\n\tASR7gfazUgSUDGkF2aSN9bfjr8eppwVQCQR+X1EZJE5qz4tWD0T/TWoYqBj/oNN8LK\n\tU+PkdXuC55npTWmi+MlQGXdvK7jiWQ6VFv0olkgE=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH 2/2] apps: qcam: Add option to configure sensor", "Date": "Mon, 20 May 2024 17:31:10 +0530", "Message-ID": "<20240520120110.110067-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<20240520120110.110067-1-umang.jain@ideasonboard.com>", "References": "<20240520120110.110067-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nAdd a '-f|--sensor_format' option to qcam to allow forcing a sensor\nconfiguration from the command line.\n\nAs an example:\nqcam -f width=3840,height=2160,bitDepth=10\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/apps/qcam/main.cpp | 3 +++\n src/apps/qcam/main_window.cpp | 7 +++++++\n src/apps/qcam/main_window.h | 1 +\n 3 files changed, 11 insertions(+)", "diff": "diff --git a/src/apps/qcam/main.cpp b/src/apps/qcam/main.cpp\nindex 9846fba5..2d0d0c5f 100644\n--- a/src/apps/qcam/main.cpp\n+++ b/src/apps/qcam/main.cpp\n@@ -30,6 +30,7 @@ void signalHandler([[maybe_unused]] int signal)\n OptionsParser::Options parseOptions(int argc, char *argv[])\n {\n \tStreamKeyValueParser streamKeyValue;\n+\tSensorKeyValueParser sensorKeyValue;\n \n \tOptionsParser parser;\n \tparser.addOption(OptCamera, OptionString,\n@@ -42,6 +43,8 @@ OptionsParser::Options parseOptions(int argc, char *argv[])\n \t\t\t \"renderer\", ArgumentRequired, \"renderer\");\n \tparser.addOption(OptStream, &streamKeyValue,\n \t\t\t \"Set configuration of a camera stream\", \"stream\", true);\n+\tparser.addOption(OptSensorFmt, &sensorKeyValue,\n+\t\t\t \"Apply a format to the sensor\", \"sensor_format\", true);\n \tparser.addOption(OptVerbose, OptionNone,\n \t\t\t \"Print verbose log messages\", \"verbose\");\n \ndiff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\nindex d515beed..aa725344 100644\n--- a/src/apps/qcam/main_window.cpp\n+++ b/src/apps/qcam/main_window.cpp\n@@ -414,6 +414,13 @@ int MainWindow::startCapture()\n \t\treturn -EINVAL;\n \t}\n \n+\t/* Apply a sensor configuration if requested. */\n+\tif (SensorKeyValueParser::updateConfiguration(config_.get(),\n+\t\t\t\t\t\t options_[OptSensorFmt])) {\n+\t\tqWarning() << \"Failed to apply sensor configuration\";\n+\t\treturn -EINVAL;\n+\t}\n+\n \tCameraConfiguration::Status validation = config_->validate();\n \tif (validation == CameraConfiguration::Invalid) {\n \t\tqWarning() << \"Failed to create valid camera configuration\";\ndiff --git a/src/apps/qcam/main_window.h b/src/apps/qcam/main_window.h\nindex 4cead734..60c46388 100644\n--- a/src/apps/qcam/main_window.h\n+++ b/src/apps/qcam/main_window.h\n@@ -42,6 +42,7 @@ enum {\n \tOptHelp = 'h',\n \tOptRenderer = 'r',\n \tOptStream = 's',\n+\tOptSensorFmt = 'f',\n \tOptVerbose = 'v',\n };\n \n", "prefixes": [ "2/2" ] }