Patch Detail
Show a patch.
GET /api/1.1/patches/20038/?format=api
{ "id": 20038, "url": "https://patchwork.libcamera.org/api/1.1/patches/20038/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20038/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240510100208.12188-4-naush@raspberrypi.com>", "date": "2024-05-10T10:02:04", "name": "[v3,3/7] include: linux: Add PiSP specific image and config buffer formats", "commit_ref": "b14f06115027abb67f0a1c0767b18899a473a237", "pull_url": null, "state": "accepted", "archived": false, "hash": "d5975a4d993f0e8d09c092138907ca8b88354337", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20038/mbox/", "series": [ { "id": 4305, "url": "https://patchwork.libcamera.org/api/1.1/series/4305/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4305", "date": "2024-05-10T10:02:01", "name": "Pre Raspberry Pi 5 support changes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4305/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20038/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20038/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4F7BBDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 May 2024 10:02:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C763D63469;\n\tFri, 10 May 2024 12:02:18 +0200 (CEST)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DC5363415\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 May 2024 12:02:14 +0200 (CEST)", "by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-41ba1ba55ffso10120345e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 May 2024 03:02:14 -0700 (PDT)", "from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-41fccee9318sm57936385e9.30.2024.05.10.03.02.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 10 May 2024 03:02:12 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Dah99LhO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1715335333; x=1715940133;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ceeICVx/0+mSlumAmTACKoxliPx4dENowVAoNrtHPmc=;\n\tb=Dah99LhO3rtTdS0XnKyOegsavTL9G0GPD/ATuBx/tDf0ElzzQC2sIbiKz0CUrfgXTm\n\tlwcKCn3ZK+hRaaT2tfkaRvwuN0Litw4++g5o1YQ1JS0sLgHKr58/hgnUwWEaGdv4eflC\n\tXf+sxsGG+XLxsPmuWl3Dda+4ZokdjHJMgPso3t3qoPeOdWYJD07wSw39LlRXmAQKt5lO\n\tnMX/eh8j7uDk/lbmoKIWtn2j+uaSLKvcwy39SUPmys2nL4+/3cwem/l2/yTJ/8bScH5i\n\t2DFIWbZX8qZTU3Vz4ynCW7RPIzuqsxdML2kwH9gMwI21hL/EFvpue5I8COPdZ+K9qG9F\n\tBSUg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1715335333; x=1715940133;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=ceeICVx/0+mSlumAmTACKoxliPx4dENowVAoNrtHPmc=;\n\tb=PsVLfIWF2H1s5eFFP4R9wuNHLZEhKC1M+iNSdpq8GIpbvCUrGJ2XcqiaBUYOJ6qNIQ\n\twMr1iitdB0nOEpJwTkBD7dJ2P3qS2Yccgmx+GAcewzy4qdghLvhe3twyRCIzfiHXT0Zy\n\tj0v4dmQjHNclPWtIyaOsnNrk3P9hO2GUlK37/rYGkxj+8EHCV4tjABDRsuIadigKxQNl\n\tDhyJobtF0GcKYW8N2/rlFhrqJJOF+/6G8lpVsY7Hr1gxJ4INVAhwgYiypiu0O72HFYn9\n\tAkx2smOFcchzPr2hnE9xKI/FlcpupDDklyZG+q2hwkaX2dnJuYiqHcirfk/heDV3IEHr\n\tHgVg==", "X-Gm-Message-State": "AOJu0YyNvfsWaQBSnzTLxjJZD/NDsEmJD1SiQNL2D44K+BOSZhzdQaE+\n\tXLt+lUrUS6BMxMwFr+SBUHkiyWGF0WAIwL+N0KlsoSV6hJe5m2ZPGzGgjL1logBzK9SfKRN2Adr\n\tE", "X-Google-Smtp-Source": "AGHT+IFQZgkfC1LP35/IDOubLNXbveaZxW1XSMQf0nlYzdMiUdo3EeDMiPYpqa+IY6lw1ltEuUHUmg==", "X-Received": "by 2002:a05:600c:4f06:b0:418:2981:c70f with SMTP id\n\t5b1f17b1804b1-41fbcfb8473mr45665495e9.19.1715335333353; \n\tFri, 10 May 2024 03:02:13 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v3 3/7] include: linux: Add PiSP specific image and config\n\tbuffer formats", "Date": "Fri, 10 May 2024 11:02:04 +0100", "Message-Id": "<20240510100208.12188-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240510100208.12188-1-naush@raspberrypi.com>", "References": "<20240510100208.12188-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add the Raspberry Pi 5 PiSP specific compressed Bayer format types 1/2:\n- V4L2_PIX_FMT_PISP_COMP1_xxx\n- V4L2_PIX_FMT_PISP_COMP2_xxx\n\nAdd the Raspberry Pi 5 PiSP Frontend and Backend config formats:\n- V4L2_META_FMT_RPI_FE_CFG\n- V4L2_META_FMT_RPI_BE_CFG\n\nAdd the Raspberry Pi 5 PiSP Frontend statistics format:\n- V4L2_META_FMT_RPI_FE_STATS\n\nThe corresponding changes submitted to the linux-media mailing list can\nbe found at:\n(series \"media: raspberrypi: Add support for PiSP Back End\")\nhttps://lore.kernel.org/linux-media/20240502110503.38412-4-jacopo.mondi@ideasonboard.com/\nhttps://lore.kernel.org/linux-media/20240502110503.38412-5-jacopo.mondi@ideasonboard.com/\n\nand for the DRM mailing at:\n(patch \"[RFC] drm/fourcc: Add RPI modifiers\")\nhttps://lore.kernel.org/dri-devel/20240226153854.99471-1-jacopo.mondi@ideasonboard.com/\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/linux/drm_fourcc.h | 4 ++++\n include/linux/videodev2.h | 21 +++++++++++++++++++++\n 2 files changed, 25 insertions(+)", "diff": "diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\nindex 5133a6551a34..b4e1a09271f5 100644\n--- a/include/linux/drm_fourcc.h\n+++ b/include/linux/drm_fourcc.h\n@@ -490,6 +490,7 @@ extern \"C\" {\n #define DRM_FORMAT_MOD_VENDOR_ALLWINNER 0x09\n #define DRM_FORMAT_MOD_VENDOR_AMLOGIC 0x0a\n #define DRM_FORMAT_MOD_VENDOR_MIPI 0x0b\n+#define DRM_FORMAT_MOD_VENDOR_RPI 0x0c\n \n /* add more to the end as needed */\n \n@@ -1670,6 +1671,9 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)\n */\n #define MIPI_FORMAT_MOD_CSI2_PACKED fourcc_mod_code(MIPI, 1)\n \n+#define PISP_FORMAT_MOD_COMPRESS_MODE1 fourcc_mod_code(RPI, 1)\n+#define PISP_FORMAT_MOD_COMPRESS_MODE2 fourcc_mod_code(RPI, 2)\n+\n #if defined(__cplusplus)\n }\n #endif\ndiff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\nindex 4fdd91494041..0b5482a07ae4 100644\n--- a/include/linux/videodev2.h\n+++ b/include/linux/videodev2.h\n@@ -787,6 +787,18 @@ struct v4l2_pix_format {\n #define V4L2_PIX_FMT_IPU3_SGRBG10\tv4l2_fourcc('i', 'p', '3', 'G') /* IPU3 packed 10-bit GRBG bayer */\n #define V4L2_PIX_FMT_IPU3_SRGGB10\tv4l2_fourcc('i', 'p', '3', 'r') /* IPU3 packed 10-bit RGGB bayer */\n \n+/* Raspberry Pi PiSP compressed formats. */\n+#define V4L2_PIX_FMT_PISP_COMP1_RGGB\tv4l2_fourcc('P', 'C', '1', 'R') /* PiSP 8-bit mode 1 compressed RGGB bayer */\n+#define V4L2_PIX_FMT_PISP_COMP1_GRBG\tv4l2_fourcc('P', 'C', '1', 'G') /* PiSP 8-bit mode 1 compressed GRBG bayer */\n+#define V4L2_PIX_FMT_PISP_COMP1_GBRG\tv4l2_fourcc('P', 'C', '1', 'g') /* PiSP 8-bit mode 1 compressed GBRG bayer */\n+#define V4L2_PIX_FMT_PISP_COMP1_BGGR\tv4l2_fourcc('P', 'C', '1', 'B') /* PiSP 8-bit mode 1 compressed BGGR bayer */\n+#define V4L2_PIX_FMT_PISP_COMP1_MONO\tv4l2_fourcc('P', 'C', '1', 'M') /* PiSP 8-bit mode 1 compressed monochrome */\n+#define V4L2_PIX_FMT_PISP_COMP2_RGGB\tv4l2_fourcc('P', 'C', '2', 'R') /* PiSP 8-bit mode 2 compressed RGGB bayer */\n+#define V4L2_PIX_FMT_PISP_COMP2_GRBG\tv4l2_fourcc('P', 'C', '2', 'G') /* PiSP 8-bit mode 2 compressed GRBG bayer */\n+#define V4L2_PIX_FMT_PISP_COMP2_GBRG\tv4l2_fourcc('P', 'C', '2', 'g') /* PiSP 8-bit mode 2 compressed GBRG bayer */\n+#define V4L2_PIX_FMT_PISP_COMP2_BGGR\tv4l2_fourcc('P', 'C', '2', 'B') /* PiSP 8-bit mode 2 compressed BGGR bayer */\n+#define V4L2_PIX_FMT_PISP_COMP2_MONO\tv4l2_fourcc('P', 'C', '2', 'M') /* PiSP 8-bit mode 2 compressed monochrome */\n+\n /* SDR formats - used only for Software Defined Radio devices */\n #define V4L2_SDR_FMT_CU8 v4l2_fourcc('C', 'U', '0', '8') /* IQ u8 */\n #define V4L2_SDR_FMT_CU16LE v4l2_fourcc('C', 'U', '1', '6') /* IQ u16le */\n@@ -816,6 +828,15 @@ struct v4l2_pix_format {\n #define V4L2_META_FMT_RK_ISP1_PARAMS\tv4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 3A Parameters */\n #define V4L2_META_FMT_RK_ISP1_STAT_3A\tv4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A Statistics */\n \n+/* The metadata format identifier for BE configuration buffers. */\n+#define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C')\n+\n+/* The metadata format identifier for FE configuration buffers. */\n+#define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C')\n+\n+/* The metadata format identifier for FE stats buffers. */\n+#define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S')\n+\n /* priv field value to indicates that subsequent fields are valid. */\n #define V4L2_PIX_FMT_PRIV_MAGIC\t\t0xfeedcafe\n \n", "prefixes": [ "v3", "3/7" ] }