Patch Detail
Show a patch.
GET /api/1.1/patches/20017/?format=api
{ "id": 20017, "url": "https://patchwork.libcamera.org/api/1.1/patches/20017/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20017/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240508080401.14850-7-naush@raspberrypi.com>", "date": "2024-05-08T08:04:01", "name": "[v2,6/6] libcamera: shared_mem_object: Remove is_standard_layout restriction", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "09aa490b0df29918fb5884e58331dce9b8fe1369", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20017/mbox/", "series": [ { "id": 4293, "url": "https://patchwork.libcamera.org/api/1.1/series/4293/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4293", "date": "2024-05-08T08:03:55", "name": "Pre Raspberry Pi 5 support changes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4293/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20017/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20017/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9E46C32CB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 May 2024 08:04:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56EF963448;\n\tWed, 8 May 2024 10:04:16 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50A0E63440\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 May 2024 10:04:05 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-41b7a26326eso29417915e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 08 May 2024 01:04:05 -0700 (PDT)", "from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tw16-20020a05600c475000b0041c14061c71sm1351944wmo.15.2024.05.08.01.04.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 May 2024 01:04:04 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"lsGyO3ah\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1715155445; x=1715760245;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=jVX4VhJ4L0dZzf1MZ7MztEMJwO+LuD8IPNPIkNcynTQ=;\n\tb=lsGyO3ahpbgEXKWEJ9h9KFWOGkHFE44jScgonkIFLZ+kWXgcQeeWKxRGtmA2HJh3Hn\n\tHOr3sJp0Zb2T+wH+JTehUpEzZw+FVrM2YZzTxLvB4/5004q4tO9NFEXnGb3LCw2/O2BW\n\trByd6Ng87PioK15xID4qXjz5bOB5+UUfN9UOFBBsyfMedj75F63YFq8vGdaWY7nf/8gb\n\tYpTzcDgwn/lbrBn1gB+GPr5aTdRtEQymgQI38KhtLPDXSUAiVsqxHqZv/+3se6wTONJZ\n\tNFXM2oH0FYfDMrHbJBTaEV9yZxPXt6kUPcjSjqBYxdNLzQcuQZiWCoDY2XzEA/fuCnRN\n\tEWaw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1715155445; x=1715760245;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=jVX4VhJ4L0dZzf1MZ7MztEMJwO+LuD8IPNPIkNcynTQ=;\n\tb=KgMqgqGAgp48mcEGSIDNcqMPRgOZx2+oDwHBJaqZsV2Dz7UBfgV7kp1R/S+Ebf/4tX\n\tfD34PZ78VCdB4tEX8MwjTa7JmTINuQXh2uZL2uNREmAS6WY7YT/7Iz3N8MowSnjsYDtW\n\thqQ0hTUOEMSrpnqRtLRtoa+0IisPMO6kAuLPvtrZyHRyHlw+pTICj6FPBBDZwUTj388P\n\tGnh3v08CqZxB3bZOwfj9BKvFj5kkeAlQjqapopt+HaP4GlvCV52LhFC2lTNBDsJ0D/25\n\tdihEuIRItUNFcKDLSCGIBIA2kwJECaoj0nWht7SzzDXIuDHEg5dvDmpu6JjYXkAbNrv0\n\tFi5A==", "X-Gm-Message-State": "AOJu0Yz9+Smkpl0QudKP4OFcSOaLE5UEkPtVzICoLlRJkCta6VtLKypj\n\twQ0RZIrnRSQAkcP/lDZET4ORb41to8dQRe5ri8gUgm02F8erSypCW7owuE3a1OzTp+inHn80qH7\n\t5", "X-Google-Smtp-Source": "AGHT+IFA8Uj+UtZHyMEP8r1vYhuMDNxv8xuZXrI3rAHZy7jtsbwhFh2rhcLmjxVxXyD9r9y59G4hqg==", "X-Received": "by 2002:a05:600c:5808:b0:41b:cc7d:1207 with SMTP id\n\t5b1f17b1804b1-41f71ec26abmr15538075e9.19.1715155444710; \n\tWed, 08 May 2024 01:04:04 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v2 6/6] libcamera: shared_mem_object: Remove\n\tis_standard_layout restriction", "Date": "Wed, 8 May 2024 09:04:01 +0100", "Message-Id": "<20240508080401.14850-7-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240508080401.14850-1-naush@raspberrypi.com>", "References": "<20240508080401.14850-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The shared_mem_object may be used to construct complex classes, so\nremove the standard layout type restriction.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n include/libcamera/internal/shared_mem_object.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nindex 9b1d939302a8..c9c0482062bd 100644\n--- a/include/libcamera/internal/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -56,7 +56,7 @@ private:\n \tSpan<uint8_t> mem_;\n };\n \n-template<class T, typename = std::enable_if_t<std::is_standard_layout<T>::value>>\n+template<class T>\n class SharedMemObject : public SharedMem\n {\n public:\n", "prefixes": [ "v2", "6/6" ] }