Patch Detail
Show a patch.
GET /api/1.1/patches/20013/?format=api
{ "id": 20013, "url": "https://patchwork.libcamera.org/api/1.1/patches/20013/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20013/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240508080401.14850-3-naush@raspberrypi.com>", "date": "2024-05-08T08:03:57", "name": "[v2,2/6] libcamera: formats: Add PiSP specific image and config buffer formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c69ef1e818f05a115ed9a7de57a1e234bfa0f9d9", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20013/mbox/", "series": [ { "id": 4293, "url": "https://patchwork.libcamera.org/api/1.1/series/4293/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4293", "date": "2024-05-08T08:03:55", "name": "Pre Raspberry Pi 5 support changes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4293/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20013/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20013/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 592D5C32B5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 May 2024 08:04:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB58763442;\n\tWed, 8 May 2024 10:04:05 +0200 (CEST)", "from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19B7D6342A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 May 2024 10:04:02 +0200 (CEST)", "by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-41ba1ba55e9so31634065e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 08 May 2024 01:04:02 -0700 (PDT)", "from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tw16-20020a05600c475000b0041c14061c71sm1351944wmo.15.2024.05.08.01.04.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 May 2024 01:04:00 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ruSEwJnE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1715155441; x=1715760241;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=XkZ5lQWFfvcJQwvAZtcgUvFdmh6Ln9fEiVm7PeXcMJg=;\n\tb=ruSEwJnEZPF/BTWK/YOQJBBxuS4RjzkRzj6qso54khTWWm84iN80dXtiN6kXGzXFob\n\tSHMrr43vMGQwhqTxJ7QW+CqXn6HFu8mWLGkXrZYiKjqVF/JWmHI3lT+OB8T1u3hvb7JB\n\tfTp1ifbZ00rHIfPJYKVx2zWR2oKnmF8ciBkMKCr80CesxdbnSWxRXDYrRwBXsFuFot1g\n\tbJItGo9oGBYG7sltvdY1TtjeIQO+AoX6kzQbHsu9KTnXf2TBjh0p+WV+teeM6LDBfp2L\n\trhuk8US5i3y+4LacuS77+Wt5QmtVLqjp4hLWyaHoPR+v+4f7iT+7b7M/YF3P9fFsKQb4\n\tQtnQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1715155441; x=1715760241;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=XkZ5lQWFfvcJQwvAZtcgUvFdmh6Ln9fEiVm7PeXcMJg=;\n\tb=NW7SAsQoQezqIcsddPGXzDgwxN8+kZaeFhhl07bHIngumkXQ2942QK90+xrWg3pgAA\n\tsPV8gwh8kqQ94T8ne7It7ZJF2uspto6PFIvIwLSmsMEBRZF3cudEDT1y8vj7KaKC51Kl\n\tY39jWfZ5K2gU56IslL5rVlClaBKVQHqeKyWz1SL7jLjdqtFMd9KnmvE6UoYOImEqKviM\n\tqImETzPDJ5LfQ7KatWuamxv9pq37N8YRmfXTi355eKk6KpNfF6uDs/wh7rRe526z6zhy\n\tkvMMVyRN9kmBU7e6FDL3JtpIJqxCXojL10NlpLQ8ooG82AYEPRHC7QCTmtASAU27/hXn\n\tTWHg==", "X-Gm-Message-State": "AOJu0YwvpWB5ISRPGNMWvDCXaHO+AhSyf14kKoZuQR/r23paVOreWFfm\n\tucnzgh62kfMtmvdG6z30HCjCDzHSvXK/7xDfg94DBdzrHGLDRr2qvY5u7mc8s7B0hRcbkCPbWbi\n\t4", "X-Google-Smtp-Source": "AGHT+IFMyuSI4aqvlUSVKqYPe2um/IK5yqkUxBQoyDFMI0nw9ytC6slvnDG/mZtX4//yipZYS19PNg==", "X-Received": "by 2002:a05:600c:3586:b0:418:3eb7:e8c6 with SMTP id\n\t5b1f17b1804b1-41f7120e3demr10913125e9.5.1715155441453; \n\tWed, 08 May 2024 01:04:01 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v2 2/6] libcamera: formats: Add PiSP specific image and\n\tconfig buffer formats", "Date": "Wed, 8 May 2024 09:03:57 +0100", "Message-Id": "<20240508080401.14850-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240508080401.14850-1-naush@raspberrypi.com>", "References": "<20240508080401.14850-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add the Raspberry Pi 5 PiSP specific verification format:\n- V4L2_PIX_FMT_RPI_BE\n\nAdd the Raspberry Pi 5 PiSP specific compressed Bayer format types 1/2:\n- V4L2_PIX_FMT_PISP_COMP1_xxx\n- V4L2_PIX_FMT_PISP_COMP2_xxx\n\nAdd the Raspberry Pi 5 PiSP Frontend and Backend config formats:\n- V4L2_META_FMT_RPI_FE_CFG\n- V4L2_META_FMT_RPI_BE_CFG\n\nAdd the Raspberry Pi 5 PiSP Frontend statistics format:\n- V4L2_META_FMT_RPI_FE_STATS\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/internal/bayer_format.h | 2 +\n include/linux/drm_fourcc.h | 5 +++\n include/linux/videodev2.h | 21 ++++++++++\n src/libcamera/bayer_format.cpp | 14 +++++++\n src/libcamera/formats.cpp | 51 ++++++++++++++++++++++-\n src/libcamera/formats.yaml | 16 +++++++\n src/libcamera/v4l2_pixelformat.cpp | 10 +++++\n 7 files changed, 118 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/bayer_format.h b/include/libcamera/internal/bayer_format.h\nindex 78ba3969913d..164743f7e9f6 100644\n--- a/include/libcamera/internal/bayer_format.h\n+++ b/include/libcamera/internal/bayer_format.h\n@@ -34,6 +34,8 @@ public:\n \t\tNone = 0,\n \t\tCSI2 = 1,\n \t\tIPU3 = 2,\n+\t\tPISP1 = 3,\n+\t\tPISP2 = 4,\n \t};\n \n \tconstexpr BayerFormat()\ndiff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\nindex 5133a6551a34..927095c4e0df 100644\n--- a/include/linux/drm_fourcc.h\n+++ b/include/linux/drm_fourcc.h\n@@ -490,6 +490,7 @@ extern \"C\" {\n #define DRM_FORMAT_MOD_VENDOR_ALLWINNER 0x09\n #define DRM_FORMAT_MOD_VENDOR_AMLOGIC 0x0a\n #define DRM_FORMAT_MOD_VENDOR_MIPI 0x0b\n+#define DRM_FORMAT_MOD_VENDOR_RPI 0x0c\n \n /* add more to the end as needed */\n \n@@ -1670,6 +1671,10 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)\n */\n #define MIPI_FORMAT_MOD_CSI2_PACKED fourcc_mod_code(MIPI, 1)\n \n+#define PISP_FORMAT_MOD_COMPRESS_MODE1 fourcc_mod_code(RPI, 1)\n+#define PISP_FORMAT_MOD_COMPRESS_MODE2 fourcc_mod_code(RPI, 2)\n+#define PISP_FORMAT_MOD_VERIFICATION fourcc_mod_code(RPI, 3)\n+\n #if defined(__cplusplus)\n }\n #endif\ndiff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\nindex 4fdd91494041..0b5482a07ae4 100644\n--- a/include/linux/videodev2.h\n+++ b/include/linux/videodev2.h\n@@ -787,6 +787,18 @@ struct v4l2_pix_format {\n #define V4L2_PIX_FMT_IPU3_SGRBG10\tv4l2_fourcc('i', 'p', '3', 'G') /* IPU3 packed 10-bit GRBG bayer */\n #define V4L2_PIX_FMT_IPU3_SRGGB10\tv4l2_fourcc('i', 'p', '3', 'r') /* IPU3 packed 10-bit RGGB bayer */\n \n+/* Raspberry Pi PiSP compressed formats. */\n+#define V4L2_PIX_FMT_PISP_COMP1_RGGB\tv4l2_fourcc('P', 'C', '1', 'R') /* PiSP 8-bit mode 1 compressed RGGB bayer */\n+#define V4L2_PIX_FMT_PISP_COMP1_GRBG\tv4l2_fourcc('P', 'C', '1', 'G') /* PiSP 8-bit mode 1 compressed GRBG bayer */\n+#define V4L2_PIX_FMT_PISP_COMP1_GBRG\tv4l2_fourcc('P', 'C', '1', 'g') /* PiSP 8-bit mode 1 compressed GBRG bayer */\n+#define V4L2_PIX_FMT_PISP_COMP1_BGGR\tv4l2_fourcc('P', 'C', '1', 'B') /* PiSP 8-bit mode 1 compressed BGGR bayer */\n+#define V4L2_PIX_FMT_PISP_COMP1_MONO\tv4l2_fourcc('P', 'C', '1', 'M') /* PiSP 8-bit mode 1 compressed monochrome */\n+#define V4L2_PIX_FMT_PISP_COMP2_RGGB\tv4l2_fourcc('P', 'C', '2', 'R') /* PiSP 8-bit mode 2 compressed RGGB bayer */\n+#define V4L2_PIX_FMT_PISP_COMP2_GRBG\tv4l2_fourcc('P', 'C', '2', 'G') /* PiSP 8-bit mode 2 compressed GRBG bayer */\n+#define V4L2_PIX_FMT_PISP_COMP2_GBRG\tv4l2_fourcc('P', 'C', '2', 'g') /* PiSP 8-bit mode 2 compressed GBRG bayer */\n+#define V4L2_PIX_FMT_PISP_COMP2_BGGR\tv4l2_fourcc('P', 'C', '2', 'B') /* PiSP 8-bit mode 2 compressed BGGR bayer */\n+#define V4L2_PIX_FMT_PISP_COMP2_MONO\tv4l2_fourcc('P', 'C', '2', 'M') /* PiSP 8-bit mode 2 compressed monochrome */\n+\n /* SDR formats - used only for Software Defined Radio devices */\n #define V4L2_SDR_FMT_CU8 v4l2_fourcc('C', 'U', '0', '8') /* IQ u8 */\n #define V4L2_SDR_FMT_CU16LE v4l2_fourcc('C', 'U', '1', '6') /* IQ u16le */\n@@ -816,6 +828,15 @@ struct v4l2_pix_format {\n #define V4L2_META_FMT_RK_ISP1_PARAMS\tv4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 3A Parameters */\n #define V4L2_META_FMT_RK_ISP1_STAT_3A\tv4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A Statistics */\n \n+/* The metadata format identifier for BE configuration buffers. */\n+#define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C')\n+\n+/* The metadata format identifier for FE configuration buffers. */\n+#define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C')\n+\n+/* The metadata format identifier for FE stats buffers. */\n+#define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S')\n+\n /* priv field value to indicates that subsequent fields are valid. */\n #define V4L2_PIX_FMT_PRIV_MAGIC\t\t0xfeedcafe\n \ndiff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\nindex 20aedfa6d925..ed6f7d62a7a3 100644\n--- a/src/libcamera/bayer_format.cpp\n+++ b/src/libcamera/bayer_format.cpp\n@@ -164,6 +164,14 @@ const std::map<BayerFormat, Formats, BayerFormatComparator> bayerToFormat{\n \t\t{ formats::SGRBG16, V4L2PixelFormat(V4L2_PIX_FMT_SGRBG16) } },\n \t{ { BayerFormat::RGGB, 16, BayerFormat::Packing::None },\n \t\t{ formats::SRGGB16, V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16) } },\n+\t{ { BayerFormat::BGGR, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::BGGR_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_BGGR) } },\n+\t{ { BayerFormat::GBRG, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::GBRG_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GBRG) } },\n+\t{ { BayerFormat::GRBG, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::GRBG_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GRBG) } },\n+\t{ { BayerFormat::RGGB, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::RGGB_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_RGGB) } },\n \t{ { BayerFormat::MONO, 8, BayerFormat::Packing::None },\n \t\t{ formats::R8, V4L2PixelFormat(V4L2_PIX_FMT_GREY) } },\n \t{ { BayerFormat::MONO, 10, BayerFormat::Packing::None },\n@@ -174,6 +182,8 @@ const std::map<BayerFormat, Formats, BayerFormatComparator> bayerToFormat{\n \t\t{ formats::R12, V4L2PixelFormat(V4L2_PIX_FMT_Y12) } },\n \t{ { BayerFormat::MONO, 16, BayerFormat::Packing::None },\n \t\t{ formats::R16, V4L2PixelFormat(V4L2_PIX_FMT_Y16) } },\n+\t{ { BayerFormat::MONO, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::MONO_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_MONO) } },\n };\n \n const std::unordered_map<unsigned int, BayerFormat> mbusCodeToBayer{\n@@ -303,6 +313,10 @@ std::ostream &operator<<(std::ostream &out, const BayerFormat &f)\n \t\tout << \"-CSI2P\";\n \telse if (f.packing == BayerFormat::Packing::IPU3)\n \t\tout << \"-IPU3P\";\n+\telse if (f.packing == BayerFormat::Packing::PISP1)\n+\t\tout << \"-PISP1\";\n+\telse if (f.packing == BayerFormat::Packing::PISP2)\n+\t\tout << \"-PISP2\";\n \n \treturn out;\n }\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 21a7719e84c4..2e2c33075fab 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -547,6 +547,16 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::MONO_PISP_COMP1, {\n+\t\t.name = \"MONO_PISP_COMP1\",\n+\t\t.format = formats::MONO_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_MONO), },\n+\t\t.bitsPerPixel = 8,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 1, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \n \t/* Bayer formats. */\n \t{ formats::SBGGR8, {\n@@ -910,7 +920,46 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 25,\n \t\t.planes = {{ { 32, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n-\n+\t{ formats::BGGR_PISP_COMP1, {\n+\t\t.name = \"BGGR_PISP_COMP1\",\n+\t\t.format = formats::BGGR_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_BGGR), },\n+\t\t.bitsPerPixel = 8,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::GBRG_PISP_COMP1, {\n+\t\t.name = \"GBRG_PISP_COMP1\",\n+\t\t.format = formats::GBRG_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GBRG), },\n+\t\t.bitsPerPixel = 8,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::GRBG_PISP_COMP1, {\n+\t\t.name = \"GRBG_PISP_COMP1\",\n+\t\t.format = formats::GRBG_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GRBG), },\n+\t\t.bitsPerPixel = 8,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::RGGB_PISP_COMP1, {\n+\t\t.name = \"RGGB_PISP_COMP1\",\n+\t\t.format = formats::RGGB_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_RGGB), },\n+\t\t.bitsPerPixel = 8,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t/* Compressed formats. */\n \t{ formats::MJPEG, {\n \t\t.name = \"MJPEG\",\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex bde2cc803b98..fe027a7cce70 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -190,4 +190,20 @@ formats:\n - SBGGR10_IPU3:\n fourcc: DRM_FORMAT_SBGGR10\n mod: IPU3_FORMAT_MOD_PACKED\n+\n+ - RGGB_PISP_COMP1:\n+ fourcc: DRM_FORMAT_SRGGB16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n+ - GRBG_PISP_COMP1:\n+ fourcc: DRM_FORMAT_SGRBG16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n+ - GBRG_PISP_COMP1:\n+ fourcc: DRM_FORMAT_SGBRG16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n+ - BGGR_PISP_COMP1:\n+ fourcc: DRM_FORMAT_SBGGR16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n+ - MONO_PISP_COMP1:\n+ fourcc: DRM_FORMAT_R16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n ...\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex efb6f2940235..977ae5834017 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -207,6 +207,16 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{\n \t\t{ formats::SGRBG16, \"16-bit Bayer GRGR/BGBG\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16),\n \t\t{ formats::SRGGB16, \"16-bit Bayer RGRG/GBGB\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_BGGR),\n+\t\t{ formats::BGGR_PISP_COMP1, \"16-bit Bayer BGBG/GRGR PiSP Compress Mode 1\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GBRG),\n+\t\t{ formats::GBRG_PISP_COMP1, \"16-bit Bayer GBGB/RGRG PiSP Compress Mode 1\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GRBG),\n+\t\t{ formats::GRBG_PISP_COMP1, \"16-bit Bayer GRGR/BGBG PiSP Compress Mode 1\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_RGGB),\n+\t\t{ formats::RGGB_PISP_COMP1, \"16-bit Bayer RGRG/GBGB PiSP Compress Mode 1\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_MONO),\n+\t\t{ formats::MONO_PISP_COMP1, \"16-bit Mono PiSP Compress Mode 1\" } },\n \n \t/* Compressed formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_MJPEG),\n", "prefixes": [ "v2", "2/6" ] }