Patch Detail
Show a patch.
GET /api/1.1/patches/20002/?format=api
{ "id": 20002, "url": "https://patchwork.libcamera.org/api/1.1/patches/20002/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20002/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240506022555.992573-1-qi.hou@nxp.com>", "date": "2024-05-06T02:25:55", "name": "gst: provider: Do not hide v4l2deviceprovider", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "eb97761c62fd3fd9ea031b1514e2415566d1228f", "submitter": { "id": 195, "url": "https://patchwork.libcamera.org/api/1.1/people/195/?format=api", "name": "Qi Hou", "email": "qi.hou@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20002/mbox/", "series": [ { "id": 4289, "url": "https://patchwork.libcamera.org/api/1.1/series/4289/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4289", "date": "2024-05-06T02:25:55", "name": "gst: provider: Do not hide v4l2deviceprovider", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4289/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20002/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20002/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B244BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 May 2024 07:09:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4EEF96342A;\n\tMon, 6 May 2024 09:09:16 +0200 (CEST)", "from EUR03-DBA-obe.outbound.protection.outlook.com\n\t(mail-dbaeur03on20601.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:260d::601])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95405633E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 May 2024 04:26:23 +0200 (CEST)", "from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t(2603:10a6:102:1ca::15)\n\tby AS8PR04MB8962.eurprd04.prod.outlook.com (2603:10a6:20b:42d::13)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34;\n\tMon, 6 May 2024 02:26:22 +0000", "from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd]) by\n\tPAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd%3]) with mapi id 15.20.7544.041;\n\tMon, 6 May 2024 02:26:22 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"KlW/Jblg\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=d+oIEBeViLx0V6RCuhKJRYeosFEGMe8HOLalf5smDPFO8T/ll3EsUXOPc5C6v0NABXFGi4gymJj6Vz1Fkwvti8SZPWNupA+kcCOQNz9sbnVvkjFlxAkZdpCcs8YmesFvoy9hJ+mUORjMWFxHgpl6QaBtPGqNBMTJZZUvaLNRIyU5YckyDoszHfvzb4v5N6mI3ZDRUW8sxqsCkZakbw4ohfWbrdXpV7tRohwQdIU+sVpZTS29mLnght8Au0Gar2+07NHKThrbwWUJ7mPvLL4Dkyk6rllVUgHtqqYEiMC5h2KeCPX2RP/6k3HlyvbkEHdT8ECfPilUS20r4fYBspneIg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=KUAVz7KoeshOOT8NBvHpUDBw5OYKr5JWAneJv3hFdUI=;\n\tb=N7KYOA03YxsjOOqyPdvI73cUtzATtvU5YYxPmRF43qpfXMvq3UrypYQoDrJMt0dfuw6NAilWxO1HEMAfmsG/YGimx5Uwpi3rgx2/gRKt/ruXJYf9IQNT3GySMZx/piTykkSjWZNEJ07It0WxPRJXEc2oTuODnKZFw1ZpS4H1zt2hzc/XhA+PxAhZAEYAfZSSPL+mROWPEEGYLGbcgDXIsCCixU6xlURaoDwHlSbe+x2o1CCHdSfr5DCvKF9RdAiFZcXyZDFEW5CZ+ad1fiIdRTczq2hcB/vrVnv/WlW/xGRLZgrejeJXAgxk9NnVUMbVsyue7N2pyyUKoyzJKu3eVg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=KUAVz7KoeshOOT8NBvHpUDBw5OYKr5JWAneJv3hFdUI=;\n\tb=KlW/JblglXa932Sdeq2vH9Tm4Mvg2jfPVA/QDeDZTQdwLWt65b0A3ChrIm0knc0jE9gmDyYNI3DRZg7zxOWU5sYcrNmgNj5ZuddspJkFxMlYFY7Z1HGFtvF+SpUT3R5bOSTq6xsS+LLvL91IvpFrTvcLskkJ0oCwAgZycXTWXfY=", "From": "Hou Qi <qi.hou@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "jared.hu@nxp.com,\n\tqi.hou@nxp.com", "Subject": "[PATCH] gst: provider: Do not hide v4l2deviceprovider", "Date": "Mon, 6 May 2024 11:25:55 +0900", "Message-Id": "<20240506022555.992573-1-qi.hou@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SI1PR02CA0052.apcprd02.prod.outlook.com\n\t(2603:1096:4:1f5::20) To PAXPR04MB8285.eurprd04.prod.outlook.com\n\t(2603:10a6:102:1ca::15)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "PAXPR04MB8285:EE_|AS8PR04MB8962:EE_", "X-MS-Office365-Filtering-Correlation-Id": "e2c245c1-43da-4129-4db5-08dc6d73eb47", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230031|376005|1800799015|366007|52116005|38350700005; ", "X-Microsoft-Antispam-Message-Info": "l+sqA1pXEq+T1JE0qVLDzYRRBOwid/OQ1WJL81J1G8gJnpBs4ILzuj+dZRwYiPHZFfetaRVi04SOUBN2ejJxwBWeBQqndts7np4xSsPFG9lVdXpPE83i1p18ZgzkRA4mWFJmMwXhZW75FPuqEduNMCy2D8dBosxqWU5esuDWU9miV/GVmdQVWgqs90o2xCHufMciRVEJYsLmr7JNzNK66Jc9Wla62V2/gvjTtJ2sVulpbILVKn5AA0+Un7WmXDxzFSCMUxXLrnMLktaC1Wi0iSbdrn4lWvwRPMnNBo6zCyL+ioWxTsxSAp5IIQRCs5EvBLuid0Wop3fZRR8JpOOb4mQ6UDcyx/7X+n6p+o8ksRiFGLUUvqPiyBvPNZBW9oHSroWOT0py88WwFCRfNkMgS5nBolLPpMgg7P1cnnuXtYY0hTk81Ji7cHaLdER/hmNfENpPwN5gTa+VB/SuOZE40hWWVjOy1DpyNuQ0qUbKidnoeSYDfNocqtfeqThXtP1cdKScl+Sduedp6pYMc4CBxEdJACBYiQoVN4BxNIQtlcIiRoMS6UdArRNOXQ+alDVQaKDjUDoGRCluCRvKFvGwxTD6ZCuT5AoXKjpu++KYHTzT4MyT+IrTsE9t8U0QynrI6aorqcW4tn7GaViWbNTGUV5KcYUNPne7sZx0aDlPkSG6EkZTXba/+r1IcpeYVWI+JS00j3VVN3ymmPB4Zbmq6DeL0r/lK6j8x4YIVFJBULwRzlCVhQCNuNQkiypXPv2BGu59oH3cIV+9Wp5alfQ1QucSxBcXtGTyNiPO4Uq8Zv0CARUE256WrcIKcavG+Hs/Ie6XaHUa4g6MwX3Tisqih3Z1tD1/TAosroulL38BS7eciFeehScY+vZZsuRmhQqtnmq86JBZMS4DixubvXnJS4PPENN24J9FGtHtqUlB7u4C/LERZd0Ie5HIMlfUBkQW017EoW5mf6LTFEZU2KnnZhw+m4DmJknmZvVTEfRLFjhlpRmUhsbmJ3odiAvGEqbq0ZfsbyUsAXIe65RyPhxbt3tbglQPdYa+gSlElZAV+ajBMdylQs6WpELjsWwCjPazTj8Ev5G0uqstV/eV7w2VeSUlSB5hjlW//frJUsWX3IA3TGGsYUe+Y5XAkpRfCaOrb6PKC+qXnn6gpT0pidRKoqJYj73WjXYJPBtASDe0nHqlpQj1orDr3iMvY2u5soq1EPKZyBXzp7aD+QFRbWCgAWnwZEKOsD30NN/o80qbX8EvLTm0IUu/wJXazdlb/PGL+jtDn3SzICsUwJveY0KwvA30I9htfc3Mjpz9ljEWps1vhkmyCn87BOCkfUFdKnEWOvKpuOdG2ljYkGy9sl57iQ==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PAXPR04MB8285.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230031)(376005)(1800799015)(366007)(52116005)(38350700005);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "aKCaCxUgUtjgmUS5WMB/3f9BekeywUVHFoQZQx9l6Kq5CZNnnsUC+Z5anPJUiKU6ae8DD4wE7+0Lzu/kDfz1TK7HDX6YTrpibD2/WoBPS/xYur+d5+kdcDqjYsYcfSkPqF1lfCvxSDrvv2tVnQL89Sf/eIjPW8i1KdL1fQ2mcemEScEPpU0wP7thFaJvAl4gW6P+rWAuD367NQn1pBLtfy/xK0d5zwSWs1DwGNBOJinuJmdHfvFvqexHYHyAP4i985y0VpMfDAKl4J5AsUy6Mz2mnbhtDbQNpbAiSuPQQ+ty7hwqqw+S5dafAbA4mpHQhW2U648ibEknqMSIg571Gck2J8BDw9WvYQEcFx5Yd8qMGgPa68JZ9wVNRGR2eQdow/20vQRquoXyTyu/NqxFp1aUG7m9nPVwT6TzZvuaSI0NbJUH+ZlzHM9O5Q3ZSzgaCNTTd9Wuy8xja0z8UIAviFyatgdIugx37gj21ucp3sOyYRu1/ouOwhqwD18o8AGq2zIiwD/tFEDYV6ajPYCJHu9BOSWpFy5Aq2XApatcT5rwoyK/FMvv7gIJ6MozIcHa9zx4sadfjJvhyFV/aCQO4U3LVKkSxm+YAVH0DVXgh0u2YZkppZkCD5w+h/ICB6Z/h4cn5YxQ7Mk2NQT1Da9Izb2FvV32IlKHsUWrWMGrFLgFtAIbU7xhfwY5/+EUibeul9VFfeheUcsIjM9iEza+/9OQz+piTaDePmrqGzl2/CSWMhztcquKhHUYWr7ELsRq8I0Db/MF6Es5QnrGj4Yy20bvc+oMQdwC6MnM0DqNYcp/QJCl5pkYq2HAALhATTd7LgQ4TSIZZJGmh9hB0SNZe5CkGtQswUSQ9mvAGPGf5Q9Jxe3ot5VuMVLmDgyBp1WtdTZ2Nydd232C5+lGXyGiP0iJa0yawd+yA6eZCMOsxc6XetaRIwsiYK+waAqQ3VdSscHP8ZUny0fB61kahbpOm6GhsTcwCLnt80FM2sn5+UKO5bIHYG3UWl3RIQYCEaSwWWxOigUuCE9dLyZUb190u4byKnGyI/+tp9eH8Xjwm1cYA1atsmnvo5DZ12yCmpZJ+R8jGXALvKJlUXm7A0bomkD7FGGD0DUe5y51rgrOrUhc4fDX3M0fIgZohJ1lrbxB9n3jy8IStPKcTtc5Bo7khr/2E7qHfIe/29TLhjxbeg/E44+JzP82K5d57uM68X4V/xXaoOX8Lm04NWNvO0Kw1FQI0rCDebTtXNT/uLZ4wGulCcoQU1vNHq8jiecoeix83SkDkf4UKWCMLggSJPY/kHBKGV8Ifo6mdacx40eifLfrTA+Ntbd3b5c5lo1UeoEXr4skB2Iid3FQ8rYGY3Hiw3PVCVyS6/PkuVSnyMF8Z0mFjM0BINkL7zZ6fkbyY3oasDCqzYZbzq4LYGSHXwC7fRzf/OEwJTVzbNFeJS5kEshqt9yfJStfNDoo48N+P0vILth+Buewx+FfRM39PDLDb3Ig3OyMYt8eCL7aAS9XFc+NkEAMB4errzGypA5UiWEhSYo6DKLzEWhAAquk/bO4OVg5zZFHUHKTZ1wb6nnTkxM=", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "e2c245c1-43da-4129-4db5-08dc6d73eb47", "X-MS-Exchange-CrossTenant-AuthSource": "PAXPR04MB8285.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 May 2024 02:26:22.0682\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "+9msC/oQZRdIzWJBJTaT+gZfgoGcKjNtsvgjJ563adm6AcyHu+B8z1yJHNBZxuup", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AS8PR04MB8962", "X-Mailman-Approved-At": "Mon, 06 May 2024 09:09:13 +0200", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Currently libcameraprovider hides \"v4l2deviceprovider\" to avoid devices\nbeing duplicated. When running \"gst-gst-device-monitor-1.0 Video\",\ndevice monitor probes device providers one by one and sends bus message\nto gst-device-monitor to print device information.\n\nThere is one case that libcameraprovider and v4l2deviceprovider both\nexit, libcameraprovider fails to probe device while v4l2deviceprovider\nprobes successfully. \"gst-device-monitor Video\" will show nothing as\nv4l2deviceprovider is hidden and the bus message it uses to convey\ndevice information is dropped.\n\nTo fix this issue, not to hide v4l2deviceprovider when do\ngst_libcamera_provider_init().\n\nSigned-off-by: Hou Qi <qi.hou@nxp.com>\n---\n src/gstreamer/gstlibcameraprovider.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex ce3e0a08..454e7aaa 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -227,10 +227,6 @@ gst_libcamera_provider_probe(GstDeviceProvider *provider)\n static void\n gst_libcamera_provider_init(GstLibcameraProvider *self)\n {\n-\tGstDeviceProvider *provider = GST_DEVICE_PROVIDER(self);\n-\n-\t/* Avoid devices being duplicated. */\n-\tgst_device_provider_hide_provider(provider, \"v4l2deviceprovider\");\n }\n \n static void\n", "prefixes": [] }