Patch Detail
Show a patch.
GET /api/1.1/patches/19995/?format=api
{ "id": 19995, "url": "https://patchwork.libcamera.org/api/1.1/patches/19995/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19995/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240503025205.2814-5-laurent.pinchart@ideasonboard.com>", "date": "2024-05-03T02:52:05", "name": "[4/4] meson: Deprecate bitwise operations between different enumeration type", "commit_ref": "bf4695266bfca8cc21bcf10a3281e874ebce0d27", "pull_url": null, "state": "accepted", "archived": false, "hash": "248fe53ae9daad4c70ee4ebe332a66ccade83c13", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19995/mbox/", "series": [ { "id": 4285, "url": "https://patchwork.libcamera.org/api/1.1/series/4285/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4285", "date": "2024-05-03T02:52:01", "name": "libcamera: Assorted cleanups and fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4285/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19995/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19995/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7A03C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 May 2024 02:52:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B84A6341F;\n\tFri, 3 May 2024 04:52:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15C726341B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 May 2024 04:52:18 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07EC1675\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 May 2024 04:51:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Icy2OHTi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714704680;\n\tbh=zR3Qe61inIbjdZrwugcRVD2FeALZgtjBGiF+qCJ2eA8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Icy2OHTilWwfDIhyljVVLRSeC6J6qYZHZyxZpP69di9lY5AT0XoDSpF8o5SKU27cW\n\tvz5ENc/DjWoPymob7i07xuyV2FadZq9p+ej+ud2Gb4iV1jZ/o0wdqGtiCxniq/Vnxu\n\tCw3aLwE+37nz/+s1nNNYH8AObiKh5nC3A9mmo5BY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 4/4] meson: Deprecate bitwise operations between different\n\tenumeration type", "Date": "Fri, 3 May 2024 05:52:05 +0300", "Message-ID": "<20240503025205.2814-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.2", "In-Reply-To": "<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>", "References": "<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "C++20 deprecates bitwise operations between different enumeration types.\nThis is a bad practice even in C++17, so enable the deprecation warning.\nDoing so ensures no such operations will be added.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n meson.build | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/meson.build b/meson.build\nindex 39e4947f8c97..89320adbde1f 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -178,6 +178,15 @@ if cc.has_argument('-Wno-c99-designator')\n ]\n endif\n \n+# Enable the C++20 deprecated enum-enum conversion warning if the compiler\n+# supports it. This helps avoiding C++20 regressions, and should be removed\n+# when switching to C++20 as the warning will then be enabled by default.\n+if cxx.has_argument('-Wdeprecated-enum-enum-conversion')\n+ cpp_arguments += [\n+ '-Wdeprecated-enum-enum-conversion',\n+ ]\n+endif\n+\n c_arguments += common_arguments\n cpp_arguments += common_arguments\n \n", "prefixes": [ "4/4" ] }