Patch Detail
Show a patch.
GET /api/1.1/patches/19980/?format=api
{ "id": 19980, "url": "https://patchwork.libcamera.org/api/1.1/patches/19980/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19980/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240502080925.31730-6-naush@raspberrypi.com>", "date": "2024-05-02T08:09:25", "name": "[v1,5/5] libcamera: shared_mem_object: Remove is_standard_layout restriction", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "09aa490b0df29918fb5884e58331dce9b8fe1369", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19980/mbox/", "series": [ { "id": 4283, "url": "https://patchwork.libcamera.org/api/1.1/series/4283/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4283", "date": "2024-05-02T08:09:20", "name": "Pre Raspberry Pi 5 support changes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4283/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19980/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19980/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90833C32CA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 May 2024 08:09:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D250C63425;\n\tThu, 2 May 2024 10:09:42 +0200 (CEST)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFF2F6341E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 May 2024 10:09:37 +0200 (CEST)", "by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-41ba1ba55e8so44019735e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 02 May 2024 01:09:37 -0700 (PDT)", "from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12-20020a05600c1d8c00b0041bcb898984sm1049970wms.31.2024.05.02.01.09.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 02 May 2024 01:09:36 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"lP2O6mgN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1714637377; x=1715242177;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=jVX4VhJ4L0dZzf1MZ7MztEMJwO+LuD8IPNPIkNcynTQ=;\n\tb=lP2O6mgNFvGNl8haOHfDDTsWz/F8DctT2QSv8hdqgJLRFFT5UqJmL7qMTygbMbt8Sq\n\tQrGQnO1buKJ1qZ6w3DtopUEr5eYlmn6saqY+UgXzwklo+hnCeZEmWHjGjTmPS6XibogX\n\tKjg/xLFER/91p4ed9qpmCVURA4IrlHqqMJJnjV+ugZ4gV3qVP1GuqONYxHBV8tqjhuNc\n\tC4FCU7Cee5P65Ttkm55UL45b92eSpndK/LMZrLLeL4yetWqAxscKk4IU8Gv25MwdzJkT\n\tBTlYcQyVXwlr/kz8Pmiq3F70NTFgn3VJtGQuSI2SBft01MYuAOBPctKIuRyaIkyg3Md0\n\tvziA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1714637377; x=1715242177;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=jVX4VhJ4L0dZzf1MZ7MztEMJwO+LuD8IPNPIkNcynTQ=;\n\tb=rpqRQm3UFeALrD6njNg4CsoY/NDX7gyGTmjiJ6hc2lTOZ/oLbIBlLDG1qCR+zJ3IcP\n\tqt0/Glg1Rpx77H68YnMYXsOLFACvcTcZ0dAgoRX8QYcSGDTODd3vXX8K1GHfNhhAyGKG\n\tnzbHGrEli9K0PXDRCK6pOGBADUG0BJi27Hg3Fd6W9vbGkJxE3pnWx7MJ31ORrMyrqD8n\n\tUv2AHwE+kFhvFUmKbMQwtHic1/JhJuVaSYImXU6bk0X6rltg1F1ehyreWdPqUx0fudlf\n\txpaUXHeR/gr7CCJZnjSGQ96yKQX/wvSusSN9+Vh7Y+cDKxpl7ycqibcd6pG9uSbwvWeP\n\tyf8Q==", "X-Gm-Message-State": "AOJu0Yy6RWtQS7cbJ3slMPG+n0hYucuGHMtAJJB58G2hdnhr/7wwt293\n\tAm5T2m/X/tbclPS7cxw2d6JCXy8uWwHRF8upbEkT6Kk4RnfGaGvtu9LEhKlnyTuToPA/n7HQhsw\n\tS", "X-Google-Smtp-Source": "AGHT+IFnu/ZGxFtU0fZgEFtwEj9pwWLxAf59CCgxjKrv0kSHvS/D7JLrGd3yjOoVCXmpwitEflqhUw==", "X-Received": "by 2002:a05:600c:46ce:b0:41b:e609:bc97 with SMTP id\n\tq14-20020a05600c46ce00b0041be609bc97mr3543180wmo.2.1714637377304; \n\tThu, 02 May 2024 01:09:37 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v1 5/5] libcamera: shared_mem_object: Remove\n\tis_standard_layout restriction", "Date": "Thu, 2 May 2024 09:09:25 +0100", "Message-Id": "<20240502080925.31730-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240502080925.31730-1-naush@raspberrypi.com>", "References": "<20240502080925.31730-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The shared_mem_object may be used to construct complex classes, so\nremove the standard layout type restriction.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n include/libcamera/internal/shared_mem_object.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nindex 9b1d939302a8..c9c0482062bd 100644\n--- a/include/libcamera/internal/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -56,7 +56,7 @@ private:\n \tSpan<uint8_t> mem_;\n };\n \n-template<class T, typename = std::enable_if_t<std::is_standard_layout<T>::value>>\n+template<class T>\n class SharedMemObject : public SharedMem\n {\n public:\n", "prefixes": [ "v1", "5/5" ] }