Patch Detail
Show a patch.
GET /api/1.1/patches/19966/?format=api
{ "id": 19966, "url": "https://patchwork.libcamera.org/api/1.1/patches/19966/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19966/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240430171728.18073-2-hdegoede@redhat.com>", "date": "2024-04-30T17:17:27", "name": "[1/2] libcamera: v4l2_videodevice: Fix devices which set both V4L2_CAP_VIDEO and V4L2_CAP_META", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b16ee55f3be9b4a5130e0f7e4dd553780be33e31", "submitter": { "id": 102, "url": "https://patchwork.libcamera.org/api/1.1/people/102/?format=api", "name": "Hans de Goede", "email": "hdegoede@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19966/mbox/", "series": [ { "id": 4279, "url": "https://patchwork.libcamera.org/api/1.1/series/4279/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4279", "date": "2024-04-30T17:17:26", "name": "libcamera: Make simplepipeline + softisp work with intel-ipu6", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4279/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19966/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19966/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B1F9C32A2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Apr 2024 17:17:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A89AD633F3;\n\tTue, 30 Apr 2024 19:17:39 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B57D633F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Apr 2024 19:17:37 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n\t[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-621-oWWAt2mBPHO-hatcOVL_OQ-1; Tue, 30 Apr 2024 13:17:32 -0400", "from smtp.corp.redhat.com\n\t(int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E2BA1827143;\n\tTue, 30 Apr 2024 17:17:32 +0000 (UTC)", "from x1.localdomain.com (unknown [10.39.192.122])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 20338477F80;\n\tTue, 30 Apr 2024 17:17:31 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"GHo1F7ny\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1714497456;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=3rEzp/DtvvekktVDG8t1Ty/1n/7cZyy0N4cu5NFv/38=;\n\tb=GHo1F7nyCYdhtlosFEbplwRW/CNMTDT4wmxBV0rDDhCiQcwstzXcbYcmBpCXFvfTwhhgr+\n\tmFXI8pWBdTPIGZrhg9NRC0GBN3mfRpwpSR9aAib06j5wKKi/J4UvkPyqY0HemSFtwI4vas\n\tW5G4jnPhAfnjge7kvx9MBWmg0p2VLQc=", "X-MC-Unique": "oWWAt2mBPHO-hatcOVL_OQ-1", "From": "Hans de Goede <hdegoede@redhat.com>", "To": "libcamera-devel@lists.libcamera.org,\n\tSakari Ailus <sakari.ailus@linux.intel.com>", "Cc": "Maxime Ripard <mripard@redhat.com>, Milan Zamazal <mzamazal@redhat.com>, \n\tDennis Bonke <admin@dennisbonke.com>, Hans de Goede <hdegoede@redhat.com>", "Subject": "[PATCH 1/2] libcamera: v4l2_videodevice: Fix devices which set both\n\tV4L2_CAP_VIDEO and V4L2_CAP_META", "Date": "Tue, 30 Apr 2024 19:17:27 +0200", "Message-ID": "<20240430171728.18073-2-hdegoede@redhat.com>", "In-Reply-To": "<20240430171728.18073-1-hdegoede@redhat.com>", "References": "<20240430171728.18073-1-hdegoede@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.10", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The /dev/video# nodes of the IPU6 driver set both V4L2_CAP_VIDEO_CAPTURE\nand V4L2_CAP_META_CAPTURE.\n\nThis was resulting in V4L2VideoDevice::getFormat() / tryFormat() /\nsetFormat() calling the metadata related ioctls instead of the videocap\nioctls causing things to not work.\n\nFix this by making V4L2Capability::isMeta() return false when the device\nalso has one of the video capabilities.\n\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\n---\n include/libcamera/internal/v4l2_videodevice.h | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex d157a447..5816c18d 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -92,6 +92,10 @@ struct V4L2Capability final : v4l2_capability {\n \t}\n \tbool isMeta() const\n \t{\n+\t\t/* Treat devs which combine video and meta as video not meta */\n+\t\tif (isVideo())\n+\t\t\treturn false;\n+\n \t\treturn device_caps() & (V4L2_CAP_META_CAPTURE |\n \t\t\t\t\tV4L2_CAP_META_OUTPUT);\n \t}\n", "prefixes": [ "1/2" ] }