Patch Detail
Show a patch.
GET /api/1.1/patches/19949/?format=api
{ "id": 19949, "url": "https://patchwork.libcamera.org/api/1.1/patches/19949/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19949/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240424234224.9658-5-laurent.pinchart@ideasonboard.com>", "date": "2024-04-24T23:42:22", "name": "[v1,4/6] test: fence: Increase timeout for fence test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f84d244d64d64f6bf8baed1fb9a37cf34199912f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19949/mbox/", "series": [ { "id": 4271, "url": "https://patchwork.libcamera.org/api/1.1/series/4271/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4271", "date": "2024-04-24T23:42:18", "name": "vimc scaling improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4271/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19949/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19949/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C771DC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Apr 2024 23:42:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 629136340C;\n\tThu, 25 Apr 2024 01:42:45 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E29E633F2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Apr 2024 01:42:34 +0200 (CEST)", "from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E4F4B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Apr 2024 01:41:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iYvFSwo+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714002102;\n\tbh=tGpmxDogLQh4fFVS0jnV03J4D0q89NHJjSUHqBWaGfw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=iYvFSwo+tw+2ABgpf5DrftCVYucOMvaYnMUOQY5jwAowRzlU3ihl6+wobPSwoZ4NJ\n\ttmQ6V5oEg+7kxgkb5QecGm3/m+rT37FoCP/aWnY4xkULgkbW5KiSo8rK8VJzQOAf9r\n\tMslfJ31dbx/gkrCWcL3QvkERe3cKNOnuh/8m9zkU=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 4/6] test: fence: Increase timeout for fence test", "Date": "Thu, 25 Apr 2024 02:42:22 +0300", "Message-ID": "<20240424234224.9658-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.2", "In-Reply-To": "<20240424234224.9658-1-laurent.pinchart@ideasonboard.com>", "References": "<20240424234224.9658-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "On slower machines, a 1s timeout to capture frames with vimc can be too\nshort and cause test failures. Make the timeout proportional to the\nnumber of frames expected to be captured, using a conservative low\nestimate of the frame rate at 2fps.\n\nBy itself, that change could increase the test time quite substantially\non fast platforms, so break from the capture loop as soon as we capture\nenough frames.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/fence.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/fence.cpp b/test/fence.cpp\nindex 7949bfbb176b..4ce6dfa23590 100644\n--- a/test/fence.cpp\n+++ b/test/fence.cpp\n@@ -315,8 +315,9 @@ int FenceTest::run()\n \n \t/* Loop for one second. */\n \tTimer timer;\n-\ttimer.start(1000ms);\n-\twhile (timer.isRunning() && expectedCompletionResult_) {\n+\ttimer.start(500ms * (signalledRequestId_ + 1));\n+\twhile (timer.isRunning() && expectedCompletionResult_ &&\n+\t completedRequestId_ <= signalledRequestId_ + 1) {\n \t\tif (completedRequestId_ == signalledRequestId_ - 1 && setFence_)\n \t\t\t/*\n \t\t\t * signalledRequestId_ has just completed and it has\n", "prefixes": [ "v1", "4/6" ] }