Patch Detail
Show a patch.
GET /api/1.1/patches/19930/?format=api
{ "id": 19930, "url": "https://patchwork.libcamera.org/api/1.1/patches/19930/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19930/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240423182000.1527425-2-mzamazal@redhat.com>", "date": "2024-04-23T18:19:56", "name": "[1/5] libcamera: software_isp: Use a specific integer type for black level", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cc848efa109682427c46eb068ede199bb7c6bf54", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19930/mbox/", "series": [ { "id": 4268, "url": "https://patchwork.libcamera.org/api/1.1/series/4268/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4268", "date": "2024-04-23T18:19:55", "name": "Software ISP levels cleanup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4268/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19930/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19930/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0166BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Apr 2024 18:20:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7D89633EC;\n\tTue, 23 Apr 2024 20:20:22 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EA6661AC9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Apr 2024 20:20:21 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n\t[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-227-WcX68h_iOFOJ9vT1dNlL_Q-1; Tue, 23 Apr 2024 14:20:18 -0400", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id A09901049C93\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Apr 2024 18:20:18 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.63])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E2187151EF;\n\tTue, 23 Apr 2024 18:20:17 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"VsEsCQNp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1713896420;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ej4J5SFxOLBaVAU2/GxZbptxItgAs3voArS0ckiAhY4=;\n\tb=VsEsCQNp63ayZflM6eQOnzShfVxuq8gTvjAfCYpIl5L5tyWtaa3Hqsp3XAA0npUrwJonfl\n\tAxz2GBUsyhDXS0dX+iwfK/OqwHpps3Xzxpmi7phiMgYNifHE30fnRsCEE8BnWNtXftaNVa\n\t6/E1szXtRYw6EO5tflah+c5oNwnzLM4=", "X-MC-Unique": "WcX68h_iOFOJ9vT1dNlL_Q-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH 1/5] libcamera: software_isp: Use a specific integer type for\n\tblack level", "Date": "Tue, 23 Apr 2024 20:19:56 +0200", "Message-ID": "<20240423182000.1527425-2-mzamazal@redhat.com>", "In-Reply-To": "<20240423182000.1527425-1-mzamazal@redhat.com>", "References": "<20240423182000.1527425-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.1", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The documented range of values corresponds to uint8_t, so let's use that\ntype.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/black_level.cpp | 3 ++-\n src/ipa/simple/black_level.h | 4 ++--\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp\nindex c7e8d8b7..a9ab12a3 100644\n--- a/src/ipa/simple/black_level.cpp\n+++ b/src/ipa/simple/black_level.cpp\n@@ -8,6 +8,7 @@\n #include \"black_level.h\"\n \n #include <numeric>\n+#include <stdint.h>\n \n #include <libcamera/base/log.h>\n \n@@ -43,7 +44,7 @@ BlackLevel::BlackLevel()\n * \\return The black level, in the range from 0 (minimum) to 255 (maximum).\n * If the black level couldn't be determined yet, return 0.\n */\n-unsigned int BlackLevel::get() const\n+uint8_t BlackLevel::get() const\n {\n \treturn blackLevelSet_ ? blackLevel_ : 0;\n }\ndiff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h\nindex 7e37757e..85bc5d8e 100644\n--- a/src/ipa/simple/black_level.h\n+++ b/src/ipa/simple/black_level.h\n@@ -17,11 +17,11 @@ class BlackLevel\n {\n public:\n \tBlackLevel();\n-\tunsigned int get() const;\n+\tuint8_t get() const;\n \tvoid update(SwIspStats::Histogram &yHistogram);\n \n private:\n-\tunsigned int blackLevel_;\n+\tuint8_t blackLevel_;\n \tbool blackLevelSet_;\n };\n \n", "prefixes": [ "1/5" ] }