Patch Detail
Show a patch.
GET /api/1.1/patches/19873/?format=api
{ "id": 19873, "url": "https://patchwork.libcamera.org/api/1.1/patches/19873/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19873/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240416091357.211951-5-mzamazal@redhat.com>", "date": "2024-04-16T09:13:40", "name": "[v8,04/18] libcamera: internal: Move SharedMemObject class to a common directory", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "abaf62badf7ac72e0baeccd10728c9de66c07b69", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19873/mbox/", "series": [ { "id": 4257, "url": "https://patchwork.libcamera.org/api/1.1/series/4257/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4257", "date": "2024-04-16T09:13:36", "name": "libcamera: introduce Software ISP and Software IPA", "version": 8, "mbox": "https://patchwork.libcamera.org/series/4257/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19873/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19873/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9D7FBE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Apr 2024 09:14:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 836AB63369;\n\tTue, 16 Apr 2024 11:14:38 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 090216334D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Apr 2024 11:14:34 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-627-_mOkiit7OT-gGuKjCyDqhw-1;\n\tTue, 16 Apr 2024 05:14:30 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id 440791C29EB4;\n\tTue, 16 Apr 2024 09:14:30 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.245])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DA7F32026962;\n\tTue, 16 Apr 2024 09:14:27 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"agA6tYoE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1713258874;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=HKjchIFecaz1loknLMl14BZTZgvdVBCGqo09CuAHeFs=;\n\tb=agA6tYoEvxpbI9CVuhHyur+IVg0YpYo6wBlXIQsdFGYZJfFS3e0hzsCvcemrqR2WL1tiyE\n\t/qdEPieRbGYwG9+xKHkJ2CuyqIAF/JcSA2ZZ96S891mSBZudXSrELkxUCgxFf31A5mVrj8\n\tJZQ0v8SBI3DIygnWcAHvjnUB5fcPLP4=", "X-MC-Unique": "_mOkiit7OT-gGuKjCyDqhw-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Andrey Konovalov <andrey.konovalov@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tAndrei Konovalov <andrey.konovalov.ynk@gmail.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMaxime Ripard <mripard@redhat.com>, Pavel Machek <pavel@ucw.cz>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v8 04/18] libcamera: internal: Move SharedMemObject class to\n\ta common directory", "Date": "Tue, 16 Apr 2024 11:13:40 +0200", "Message-ID": "<20240416091357.211951-5-mzamazal@redhat.com>", "In-Reply-To": "<20240416091357.211951-1-mzamazal@redhat.com>", "References": "<20240416091357.211951-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Andrey Konovalov <andrey.konovalov@linaro.org>\n\nMove SharedMemObject class out of RPi namespace and put it into\ninclude/libcamera/internal so that everyone could use it.\n\nTested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> # sc8280xp Lenovo x13s\nTested-by: Pavel Machek <pavel@ucw.cz>\nReviewed-by: Pavel Machek <pavel@ucw.cz>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\n---\n include/libcamera/internal/meson.build | 1 +\n .../libcamera/internal}/shared_mem_object.h | 6 +-----\n 2 files changed, 2 insertions(+), 5 deletions(-)\n rename {src/libcamera/pipeline/rpi/common => include/libcamera/internal}/shared_mem_object.h (97%)", "diff": "diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex 33eb0fb3..5807dfd9 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -39,6 +39,7 @@ libcamera_internal_headers = files([\n 'process.h',\n 'pub_key.h',\n 'request.h',\n+ 'shared_mem_object.h',\n 'source_paths.h',\n 'sysfs.h',\n 'v4l2_device.h',\ndiff --git a/src/libcamera/pipeline/rpi/common/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nsimilarity index 97%\nrename from src/libcamera/pipeline/rpi/common/shared_mem_object.h\nrename to include/libcamera/internal/shared_mem_object.h\nindex aa56c220..98636b44 100644\n--- a/src/libcamera/pipeline/rpi/common/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -6,8 +6,8 @@\n */\n #pragma once\n \n-#include <cstddef>\n #include <fcntl.h>\n+#include <stddef.h>\n #include <string>\n #include <sys/mman.h>\n #include <sys/stat.h>\n@@ -19,8 +19,6 @@\n \n namespace libcamera {\n \n-namespace RPi {\n-\n template<class T>\n class SharedMemObject\n {\n@@ -123,6 +121,4 @@ private:\n \tT *obj_;\n };\n \n-} /* namespace RPi */\n-\n } /* namespace libcamera */\n", "prefixes": [ "v8", "04/18" ] }