Patch Detail
Show a patch.
GET /api/1.1/patches/19868/?format=api
{ "id": 19868, "url": "https://patchwork.libcamera.org/api/1.1/patches/19868/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19868/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240412144331.29858-1-laurent.pinchart@ideasonboard.com>", "date": "2024-04-12T14:43:31", "name": "[v2] utils: ipc: Fix async main interface functions with no parameters", "commit_ref": "1c5830a9a40c0f93e4f115254436518988d4b1ad", "pull_url": null, "state": "accepted", "archived": false, "hash": "cedd849aff6786e49b37ee3f422bbcf18baff409", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19868/mbox/", "series": [ { "id": 4256, "url": "https://patchwork.libcamera.org/api/1.1/series/4256/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4256", "date": "2024-04-12T14:43:31", "name": "[v2] utils: ipc: Fix async main interface functions with no parameters", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4256/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19868/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19868/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B953CBE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Apr 2024 14:43:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF51C61BAE;\n\tFri, 12 Apr 2024 16:43:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37B1461BAE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Apr 2024 16:43:43 +0200 (CEST)", "from pendragon.ideasonboard.com (ip-185-104-138-69.ptr.icomera.net\n\t[185.104.138.69])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06C1DA12;\n\tFri, 12 Apr 2024 16:42:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pwTX3aqb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712932979;\n\tbh=R2jwGjx2Rw1ClpxCMsu3y/JnbuksznlAUB2U0QtUJjA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=pwTX3aqbxmZprZaYbP39dUZ/LRLreDUnuR7xMnDYgbfjrZP/znjYM6lE15+eAXVxE\n\twu/DPrMVGdl5JOmhIphSgGKnNUwOmCzlD3RMQASpc3ZN3RC2SQZmc5MDyrwhX+TrVV\n\teVoaFGnz9FXt3A/kwXaT+1wFACNSMOSPZwm9PQrE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2] utils: ipc: Fix async main interface functions with no\n\tparameters", "Date": "Fri, 12 Apr 2024 17:43:31 +0300", "Message-ID": "<20240412144331.29858-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Paul Elder <paul.elder@ideasonboard.com>\n\nIf an async main interface function is defined with no parameters, there\nwould be a compilation error complaining about an extra comma. Fix this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: 9dc601cf7a689fe6eef23189edf0c8a9c38dcfe1", "diff": "diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex 238cf4a59435..f64c3c93bfcb 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -175,9 +175,9 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n );\n {% elif method|is_async %}\n \tASSERT(state_ == ProxyRunning);\n-\tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued,\n+\tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued\n \t{%- for param in method|method_param_names -%}\n-\t\t{{param}}{{- \", \" if not loop.last}}\n+\t\t, {{param}}\n \t{%- endfor -%}\n );\n {%- endif %}\n", "prefixes": [ "v2" ] }