Patch Detail
Show a patch.
GET /api/1.1/patches/19867/?format=api
{ "id": 19867, "url": "https://patchwork.libcamera.org/api/1.1/patches/19867/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19867/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240412091700.1817754-4-paul.elder@ideasonboard.com>", "date": "2024-04-12T09:17:00", "name": "[3/3] ipa: rkisp1: agc: Plumb lux", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3cdfc8951cb1c9b06cf29a4404ec002737854c45", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19867/mbox/", "series": [ { "id": 4255, "url": "https://patchwork.libcamera.org/api/1.1/series/4255/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4255", "date": "2024-04-12T09:16:57", "name": "ipa: rkisp1: Add lux estimation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4255/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19867/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19867/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5609DC3285\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Apr 2024 09:17:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F15E663360;\n\tFri, 12 Apr 2024 11:17:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A52976334D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Apr 2024 11:17:18 +0200 (CEST)", "from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 27EC6D7E;\n\tFri, 12 Apr 2024 11:16:33 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bmxVlSm2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712913395;\n\tbh=F4b1sisvNS2PUQCIik4PqmaTBBn9n/VFZAshk+gxS4M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bmxVlSm2pjn0AoSHUq2IMmoBszUXWBHbE0k8Wo2/w4qtMMQ5DniTVBXqWrT78YzYe\n\t5jtCRgBT1Whrui0bfDqCUoooun4NBksCCI56lL4hMKVDJTPRhf5XuAtgfb9zZz7kI6\n\tcA4Jqn/i37oCOzKLSD2poKl+3wawLoEHI5tHvWFQ=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH 3/3] ipa: rkisp1: agc: Plumb lux", "Date": "Fri, 12 Apr 2024 18:17:00 +0900", "Message-Id": "<20240412091700.1817754-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240412091700.1817754-1-paul.elder@ideasonboard.com>", "References": "<20240412091700.1817754-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that the rkisp1 IPA has a lux algorithm module, use the lux value\nthat comes from that as opposed to hardcoding it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex ed4d6330..5371ae48 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -424,8 +424,7 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \tdouble analogueGain = frameContext.sensor.gain;\n \tutils::Duration effectiveExposureValue = exposureTime * analogueGain;\n \n-\t/* \\todo Plumb in the lux value. Requires a lux algo + tuning */\n-\tdouble lux = 400;\n+\tdouble lux = frameContext.agc.lux;\n \n \tutils::Duration shutterTime;\n \tdouble aGain, dGain;\n", "prefixes": [ "3/3" ] }