Patch Detail
Show a patch.
GET /api/1.1/patches/19863/?format=api
{ "id": 19863, "url": "https://patchwork.libcamera.org/api/1.1/patches/19863/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19863/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240412024256.651465-1-paul.elder@ideasonboard.com>", "date": "2024-04-12T02:42:56", "name": "utils: ipc: Fix async main interface functions with no parameters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fc5001bfb93993061d43fe3558243e5bdbee549a", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19863/mbox/", "series": [ { "id": 4254, "url": "https://patchwork.libcamera.org/api/1.1/series/4254/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4254", "date": "2024-04-12T02:42:56", "name": "utils: ipc: Fix async main interface functions with no parameters", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4254/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19863/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19863/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26571C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Apr 2024 02:43:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2025563352;\n\tFri, 12 Apr 2024 04:43:10 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4587A61B4F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Apr 2024 04:43:08 +0200 (CEST)", "from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EAFA8E1;\n\tFri, 12 Apr 2024 04:42:23 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TmgRqLFz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712889744;\n\tbh=XxHrqYpM8iqieX4XMNSotwk6X//ndiqBYgx+g9F7Qwo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=TmgRqLFzIjFtroiMeElaWNDqwWnneP3FjgolPKnvNp2hz5+8TzhSlV5ts8zzDLkQ9\n\tr69dNPFj6U8sr2ZODffNF8ugD5l3kahT6De/EcSmNUAY0Xj3DPW9ZwspXIFhb+bmCq\n\trFkZ1lRhwIeqmB1DdzXsX+m1twRd79JawAdcIwME=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "laurent.pinchart@ideasonboard.com,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] utils: ipc: Fix async main interface functions with no\n\tparameters", "Date": "Fri, 12 Apr 2024 11:42:56 +0900", "Message-Id": "<20240412024256.651465-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If an async main interface function is defined with no parameters, there\nwould be a compilation error complaining about an extra comma. Fix this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex 238cf4a5..01fe9c51 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -175,7 +175,8 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n );\n {% elif method|is_async %}\n \tASSERT(state_ == ProxyRunning);\n-\tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued,\n+\tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued\n+\t{%- if method|method_param_names|length > 0 -%}, {% endif -%}\n \t{%- for param in method|method_param_names -%}\n \t\t{{param}}{{- \", \" if not loop.last}}\n \t{%- endfor -%}\n", "prefixes": [] }