Patch Detail
Show a patch.
GET /api/1.1/patches/19818/?format=api
{ "id": 19818, "url": "https://patchwork.libcamera.org/api/1.1/patches/19818/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19818/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240327172731.434048-2-julien.vuillaumier@nxp.com>", "date": "2024-03-27T17:27:30", "name": "[v3,1/2] libcamera: pipeline: Add a get factory by name helper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dadc0048209fc0a103eb5a5af05f02716f95c6be", "submitter": { "id": 190, "url": "https://patchwork.libcamera.org/api/1.1/people/190/?format=api", "name": "Julien Vuillaumier", "email": "julien.vuillaumier@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19818/mbox/", "series": [ { "id": 4245, "url": "https://patchwork.libcamera.org/api/1.1/series/4245/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4245", "date": "2024-03-27T17:27:29", "name": "Add environment variable to order pipelines match", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4245/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19818/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19818/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DCD7BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 27 Mar 2024 17:28:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42D7561C41;\n\tWed, 27 Mar 2024 18:28:09 +0100 (CET)", "from EUR04-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur04on20601.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:260f::601])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBA6761C41\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Mar 2024 18:28:07 +0100 (CET)", "from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)\n\tby AM0PR04MB6913.eurprd04.prod.outlook.com (2603:10a6:208:184::24)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31;\n\tWed, 27 Mar 2024 17:28:06 +0000", "from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::2208:ff47:a8fe:dea6]) by\n\tAM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::2208:ff47:a8fe:dea6%5]) with mapi id 15.20.7409.031;\n\tWed, 27 Mar 2024 17:28:06 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"CLg7nvJ+\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=PO2E9VIXYLkNNtqRyJPboTQSiuQXw0ieTzkcxYX7DnDitnAuGQKXjdfyLHry1NuWrQryOOLt2b+8r5sZdLcqsPoe70w+9YogXA8ui5Om9/mJkSjqZH+1pejj5cKZrN6Y+NJ+EfGAW7BvZkQdca+b4oNbPez/lvkzIIPkFDzWpcntR3MCAGy4+McIrVenkp2tpmJhqKKVKfgr3Mf/6S/gb/qnZy0Ko7X1CHwhtY2+k6W87QqNEzA1rXOKK3tTTCjpMn3F0/3qikMBrjqbnl32iL1SdzuvfZxrZ31CZS4YhmyKwsGobZCwUyaLjlsOvnkH7CLtL48YgHY8ywh0KzQG3Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=cbZY5mDsaoIkvG7DsMeYN5dwsnE9gUW1PuIC2hgbtJw=;\n\tb=RsYc7stwsxhRlU+xmL/ay+iHw6JMws8KRRuAcXfB79VQoWCmRPRfarvqGg2lbCRDEYrVOyKktS7Zck3nDzznqSNVS6vFZ7BBvGXZ04ug2EoV8/kB9qM2VzfFmY1nH3ZIiCvHmURfRIOWm36Bkjt5R0AboGJ466jk1EMKubjK95fOWGFpMzKac62KDgbIJO+D5lzTbJpEqY0d9KpkhLgysnxvND+T2/NgnuvAXRW6uCZf9gp39GxoLYB7j/LC9NHMoozxLwwHo8x3w9OaPyZeRziJhHet12i/62di5TAjuQmwLNsWz9k5a7c2le7nxH4cPG8k69t2tWNmLx2lr95xTA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=cbZY5mDsaoIkvG7DsMeYN5dwsnE9gUW1PuIC2hgbtJw=;\n\tb=CLg7nvJ+lgw4OQcerSgNRZDl2g2VL5x4fVo6OFGgjIx01dDQsYO2ExVHFWpD1kA1v4h1VtQuOtt3Plil3Duf+ZXGZfU9+dQzAdUBG+wlEHc2oHvp5NWumfJa08iPgSFPqvMVcWNjSYlxYm/mzUeBKhwMNSfW3W0+/72Z5WkxYHM=", "From": "Julien Vuillaumier <julien.vuillaumier@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "julien.vuillaumier@nxp.com, Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v3 1/2] libcamera: pipeline: Add a get factory by name helper", "Date": "Wed, 27 Mar 2024 18:27:30 +0100", "Message-Id": "<20240327172731.434048-2-julien.vuillaumier@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240327172731.434048-1-julien.vuillaumier@nxp.com>", "References": "<20240327172731.434048-1-julien.vuillaumier@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM0PR02CA0167.eurprd02.prod.outlook.com\n\t(2603:10a6:20b:28d::34) To AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AM9PR04MB8147:EE_|AM0PR04MB6913:EE_", "X-MS-Office365-Filtering-Correlation-Id": "73554931-df74-44f5-3a5d-08dc4e834347", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "5rAds6swk2wwI7PVDvRfdt98xE1aR/qzSy8gfiphZBpOQDyov+Z6sZhV3BcbsxcW+rSI47h+wFhlgcgP4BAfliVu9SRerDexE8peg1bE/FDKjEl5ahbk2pUWf4b+Mh0cZoKf2xbdSiopl4cg0A+ohjuKU6JjQnBhXFV75XXyz4b+VjzATr804QpYyqW6sT42kO3+RqFb04W+DCir24FbcILB0BSovwF30MNHHwsfLnmhTRGjMVFmBAHbFuROK3t/q/iooE5692mQbY5l7AITHOk18Knvov4rxOOvuqtqAg43LCz83025J8TRNijQZQXipAv+Hp5R3slXa5MNZykOyvOuAHRJChpMZJ802X0UNAKXdAcfQP563RMEe+ZizYDrOC5qiXk3kTtwvdN15pt4ZuSUh7PRQh0+DQljKY84U5uc777QPyLXioVsWooVt+icV6tAcaaE9w5TbZ2Bqpw7FPkpMdVHxQPua+ADbuyU7GIgszlA/q5F9C9ce9tuw//oWE12nr6G53Mya+hhQkkAzGDWkncAVp0Mt6uL7dcMTE1Jo9hwc3/ScANjmPgBBu90ZNuqkQiZH49SbYbZ5i83jadSEx47GnKWw1PwbWrMAO9F7N+dkNGtEnrHW790ffMtGQiZjZvAQ0caXJC/LJ+QJImYKNuESLtxLggeGzkUI9j+1T3z1Ed3vrup+3bv1Q5SFsSUBf+oM6hdKPwrdSK465CuBs7cZBTrsfHMndUKVL8=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AM9PR04MB8147.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230031)(376005)(366007)(1800799015)(52116005)(38350700005);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "BGqk8eqtN1U3JsqFnpDwZgdU5CMxcYqDlj1vmvrf8e+CYK2/ol26KSUwKxmSQTSrd6xLB3ahmLif9dlQfImf0nqidXbZos50d6ymV+31VOsjJ2yBht/u+UI0C1MmcyU1PLJJVNWrX7ACCIY1I69bAy+az+L9dEQDTrc7h2dGtJeNIMnR6f3jFqW/OauTKPU7bEsq9gheMrPFYTOry1Xnyq8d2pFyRXEXzX/qjqQ1OpEdof5U09udDe1AfPseHOpqJaG+/cEwFcESFgtW3lPVEEVUzfxeh9evd23aNsrqBp4bRDz/JUJvg2zqa/LsJIswN1SDyKrZ4AVpQ1e8KPQCrhiGsnn5v9jtqs7BwEVfYAuFt3NylbiI0mmnDieESOBFudoIEjByrj8ORNHf8wQlGFoWQBaaWZyG072C/iAFAwx/PuN3vtWD8l/iWk3/jBPTsh+81g/fR6OwNy+7s7B0RBKbvYLMGD0XEf5uG/TJpJtTW7RAyvlqDpQI2/m8p1jbjuPVIbHsFyFdVX+74GHnZD1lW6DSIgOQKAZe4exIxy9HWQGbRSp0FFbhYX+vaoOBNYOLsYyT19rUmdOvdL6eg9OxUxXoaA3ZWm10IftosTtDa8Hal3ndWvYPLRzajOsbheNaqnJq7NJkDHfatIaYFRyMeCuZMxOLBExHRgFdFgMvL2WI4yZGY2tkyLfIrb4AL801sqB0yKYQxDyUHPxW3rniUpo8PnwbBTAS8XBWiG5DuA1tpLzv+mR2hcMU7e8A5b15JXKYgS+jcqPH2A82GTJwWvhRBamxZorn+YbcBupJ6bZxsscWk0Z0WoB38UcPGM5SpAL9cpE4B+REja8zYxFajaZodK2iBl+PWZWP5524vHNEOwBSxxnG52CeMwjduu5hUMYtxVej0DyRhCH0Bh8chasjG/d/hBa4IBpCxqYGC0S+m9nVunrq2kfP2z8697T6le7wJmhDLkzAmRpBNPh343rfe4jl6Kvz36Sj2oEMJpVeB4KJL1Oi+vTsCVTnj/oxjI8NJW7Ljm0ycQfxeodDGPx/nAYXWIP8KMd3Nc++OzShcDO4YhhDZmUxnQwETPWbCcBBNNxbCOu2cxByQVcrG3pa25TISoRYqI2GfbeNHdum8xFtrp+K6/uzo0YrVy62X2anlqK0rqKqDTD41UfkohjUzucmz7U7WDmPawXFGAhRLQmMeZc3cFHSwNfnVYh5h5CDcT9d53hutK6umB4yzLXBzQZc8cW4rmz4reAkjuzEO+SV5cOgGySD/AS08ogoT7/ECixwfj94/a67jolIqGl9+5ZzQfeHGPtsliQ6wKZqxaN4WFQM6eRy0RS1oS1NIsgMVGEHyLjjqvKi8o5kPwegkcZx95mXQ/pOcBHC+jVfTdE6Q9mPVRUX6OGGYKTh5nOuuG3hefEVKQJ5FWP7QkJmoqsNMZwhfJqui4mBijK+UWkMm2Q/9hSaLD/ZYMfhMnlfVtlOmTf1pqEsE2+4YrhUZVJbhsEGzid3ZsKGvCv7yQAh3ob4BX4+WIO8/hFHNhlkCGe1UloMhUmhEG+gGi7B0AfM/LkGd153FugbpvTJjAXfW0afTEQbG/ztLnJYu09jL/tcYi/qLqDcFQ==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "73554931-df74-44f5-3a5d-08dc4e834347", "X-MS-Exchange-CrossTenant-AuthSource": "AM9PR04MB8147.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "27 Mar 2024 17:28:06.2691\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "f+UUkEwvlsww7SMhqw88BAs2FPQAIVii44b01ETM9TX6P+Fgb20kkD7NA1k1Rkfy1bx0Xppp2YwCloJavNyKziR3wJ1/Vza6Zx1pQdiZw3M=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR04MB6913", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a static helper to the PipelineHandlerFactoryBase class to\nallow retrieving a pipeline by name.\n\nSigned-off-by: Julien Vuillaumier <julien.vuillaumier@nxp.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/internal/pipeline_handler.h | 1 +\n src/libcamera/pipeline_handler.cpp | 22 +++++++++++++++++++\n 2 files changed, 23 insertions(+)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex c96944f4..19361a40 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -114,6 +114,7 @@ public:\n \tconst std::string &name() const { return name_; }\n \n \tstatic std::vector<PipelineHandlerFactoryBase *> &factories();\n+\tstatic const PipelineHandlerFactoryBase *getFactoryByName(const std::string &name);\n \n private:\n \tstatic void registerType(PipelineHandlerFactoryBase *factory);\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 29e0c98a..c926f454 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -794,6 +794,28 @@ std::vector<PipelineHandlerFactoryBase *> &PipelineHandlerFactoryBase::factories\n \treturn factories;\n }\n \n+/**\n+ * \\brief Return the factory for the pipeline handler with name \\a name\n+ * \\param[in] name The pipeline handler name\n+ * \\return The factory of the pipeline with name \\a name, or nullptr if not found\n+ */\n+const PipelineHandlerFactoryBase *PipelineHandlerFactoryBase::getFactoryByName(const std::string &name)\n+{\n+\tconst std::vector<PipelineHandlerFactoryBase *> &factories =\n+\t\tPipelineHandlerFactoryBase::factories();\n+\n+\tauto iter = std::find_if(factories.begin(),\n+\t\t\t\t factories.end(),\n+\t\t\t\t [&name](const PipelineHandlerFactoryBase *f) {\n+\t\t\t\t\treturn f->name() == name;\n+\t\t\t\t });\n+\n+\tif (iter != factories.end())\n+\t\treturn *iter;\n+\n+\treturn nullptr;\n+}\n+\n /**\n * \\class PipelineHandlerFactory\n * \\brief Registration of PipelineHandler classes and creation of instances\n", "prefixes": [ "v3", "1/2" ] }