Patch Detail
Show a patch.
GET /api/1.1/patches/19785/?format=api
{ "id": 19785, "url": "https://patchwork.libcamera.org/api/1.1/patches/19785/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19785/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240320165840.35902-1-dylan.aissi@collabora.com>", "date": "2024-03-20T16:58:40", "name": "v4l2: unset _TIME_BITS in addition to _FILE_OFFSET_BITS", "commit_ref": "705601781b6ab4f3035719ddaf1e442f4a5e8737", "pull_url": null, "state": "accepted", "archived": false, "hash": "2d5b882686c2484b21e1bbb0750156e37d818dd8", "submitter": { "id": 191, "url": "https://patchwork.libcamera.org/api/1.1/people/191/?format=api", "name": "Dylan Aïssi", "email": "dylan.aissi@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19785/mbox/", "series": [ { "id": 4235, "url": "https://patchwork.libcamera.org/api/1.1/series/4235/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4235", "date": "2024-03-20T16:58:40", "name": "v4l2: unset _TIME_BITS in addition to _FILE_OFFSET_BITS", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4235/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19785/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19785/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEC50C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 20 Mar 2024 20:50:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAE9F63075;\n\tWed, 20 Mar 2024 21:50:24 +0100 (CET)", "from madrid.collaboradmins.com (madrid.collaboradmins.com\n\t[IPv6:2a00:1098:ed:100::25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F731603AC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Mar 2024 17:59:22 +0100 (CET)", "from XPS13-9310.home (cola.collaboradmins.com [195.201.22.229])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: daissi)\n\tby madrid.collaboradmins.com (Postfix) with ESMTPSA id 9CE2337804B2; \n\tWed, 20 Mar 2024 16:59:21 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=collabora.com header.i=@collabora.com\n\theader.b=\"xblgoOiu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1710953961;\n\tbh=aovGW4ZJNHjLg2gUMafJRQzjeJfweQw84XhAAntIyNo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=xblgoOiuwClRh9i27x/IzIZMbuC3cKEYxv6iJB4tWBSbw+pKC5J5EayZAwsNXAdpe\n\th2lv8u7heqxKDJWiBxphjJc8VJhUdrbyptkPxbw8htBNWBi5dx76hFvEKojz61tWPa\n\tIiyfiimkaptGLc0Pw6j3bAv4IXVkUXh/li75vD6+zv1KUOTtmCLWCFmxvAItKUzQWo\n\tlkv9WfXoG/QcARe3H1V8RUvCCHX9sA5Tj+nUoG0AfbVT2YqGVFlNk5VB0kdr4zriXm\n\tP/KPuV+GVH/64iQF7rD9jpCIF6sXsdmsUsn1oIb/YeZziJAh5L7fVizSBr3DIoq7EA\n\tp9ZJgWqbNP+0A==", "From": "=?utf-8?q?Dylan_A=C3=AFssi?= <dylan.aissi@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Steve Langasek <steve.langasek@canonical.com>, =?utf-8?b?RHlsYW4gQcOv?=\n\t=?utf-8?q?ssi?= <dylan.aissi@collabora.com>", "Subject": "[PATCH] v4l2: unset _TIME_BITS in addition to _FILE_OFFSET_BITS", "Date": "Wed, 20 Mar 2024 17:58:40 +0100", "Message-Id": "<20240320165840.35902-1-dylan.aissi@collabora.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 20 Mar 2024 21:50:23 +0100", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Steve Langasek <steve.langasek@canonical.com>\n\nlibcamera fails to build from source in Debian/Ubuntu on 32-bit\narchitectures under 64-bit time_t (to avoid the 'year 2038\nproblem'), because its v4l2 module legitimately un-sets\n_FILE_OFFSET_BITS for building but this is not allowed without\nalso unsetting _TIME_BITS.\n\nHaving verified that nothing in this module is sensitive to 64-bit\ntime_t (none of the functions it intercepts handle time), we also\nunset _TIME_BITS to allow this to build as before.\n\nSigned-off-by: Steve Langasek <steve.langasek@canonical.com>\nReviewed-by: Dylan Aïssi <dylan.aissi@collabora.com>\n---\n src/v4l2/meson.build | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\nindex e88e0b33..12d1e2a4 100644\n--- a/src/v4l2/meson.build\n+++ b/src/v4l2/meson.build\n@@ -23,6 +23,7 @@ v4l2_compat_cpp_args = [\n # file operations, disable transparent large file support.\n '-U_FILE_OFFSET_BITS',\n '-D_FILE_OFFSET_BITS=32',\n+ '-U_TIME_BITS',\n '-D_LARGEFILE64_SOURCE',\n '-fvisibility=hidden',\n ]\n", "prefixes": [] }