Patch Detail
Show a patch.
GET /api/1.1/patches/19746/?format=api
{ "id": 19746, "url": "https://patchwork.libcamera.org/api/1.1/patches/19746/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19746/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240319120517.362082-7-stefan.klug@ideasonboard.com>", "date": "2024-03-19T12:05:07", "name": "[v3,06/16] libcamera: delayed_controls: Make listSize unsigned", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f66e65816ad503e57304a062c1c3084044bff750", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19746/mbox/", "series": [ { "id": 4230, "url": "https://patchwork.libcamera.org/api/1.1/series/4230/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4230", "date": "2024-03-19T12:05:01", "name": "Preparation for per-frame-controls and initial tests", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4230/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19746/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19746/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9E5EC32C4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Mar 2024 12:05:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D3FE62CAE;\n\tTue, 19 Mar 2024 13:05:37 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4D1A62CAC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Mar 2024 13:05:28 +0100 (CET)", "from jasper.fritz.box (unknown\n\t[IPv6:2a00:6020:448c:6c00:1478:344b:8fcb:baf5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35D7BF02;\n\tTue, 19 Mar 2024 13:05:02 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jtES7uPO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710849902;\n\tbh=ogedsUNacptSc0oIPMfSH3q1GS42oyNh/snuUSKDJSg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jtES7uPOy8o9BAvpCvFVO01KqqNzDdFQlXx8Ilbe/JmW4VUMEo7jrPQs37iwIpuCF\n\tj7dk/fQA7XTkya33tibsuZHoS9qUdVUFxeFvjG161mTYGs9OPmj/bNj2Luj86KIaM6\n\twnVYN5ysSkQPsqaT4qUlgJSBivPTdboHYrCCwKXc=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v3 06/16] libcamera: delayed_controls: Make listSize unsigned", "Date": "Tue, 19 Mar 2024 13:05:07 +0100", "Message-Id": "<20240319120517.362082-7-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20240319120517.362082-1-stefan.klug@ideasonboard.com>", "References": "<20240319120517.362082-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Make listSize unsigned, so that later calculations with other unsigned\nints don't require casts.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n include/libcamera/internal/delayed_controls.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\nindex 4f8d2424..0e28106a 100644\n--- a/include/libcamera/internal/delayed_controls.h\n+++ b/include/libcamera/internal/delayed_controls.h\n@@ -52,7 +52,7 @@ private:\n \t};\n \n \t/* \\todo Make the listSize configurable at instance creation time. */\n-\tstatic constexpr int listSize = 16;\n+\tstatic constexpr unsigned int listSize = 16;\n \tclass ControlRingBuffer : public std::array<Info, listSize>\n \t{\n \tpublic:\n", "prefixes": [ "v3", "06/16" ] }