Patch Detail
Show a patch.
GET /api/1.1/patches/19739/?format=api
{ "id": 19739, "url": "https://patchwork.libcamera.org/api/1.1/patches/19739/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19739/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240319105403.4045592-3-paul.elder@ideasonboard.com>", "date": "2024-03-19T10:54:03", "name": "[2/2] ipa: rkisp1: agc: Fix histogram construction", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5c9932816ff80368f9188463323909a2958885e1", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19739/mbox/", "series": [ { "id": 4229, "url": "https://patchwork.libcamera.org/api/1.1/series/4229/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4229", "date": "2024-03-19T10:54:01", "name": "ipa: rkisp1: Fix histogram", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4229/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19739/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19739/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FEADBD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Mar 2024 10:54:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73DBA62CA8;\n\tTue, 19 Mar 2024 11:54:33 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FD0B61C61\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Mar 2024 11:54:31 +0100 (CET)", "from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3C3216F9;\n\tTue, 19 Mar 2024 11:54:03 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ji/KpOHd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710845644;\n\tbh=hmyiyluaTru7FETWqIyVy4DT/sC1/kVnyoXatr5Jqy0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ji/KpOHdFiwNib1sNbKBxgf9sX36tZFzc5TcLi+LXd2WdMv+odv106P5SEEOJuG+n\n\tpmH5WasDG8/FqdAeBcVkEIO/e15Looxq9jtGpT8jmg+f3a7h1E22dJSYcdSjLfmaGU\n\thV0dmRtp5O13CqzmV3rU8gBMFZ0Yf7fOSVhIri3M=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH 2/2] ipa: rkisp1: agc: Fix histogram construction", "Date": "Tue, 19 Mar 2024 19:54:03 +0900", "Message-Id": "<20240319105403.4045592-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240319105403.4045592-1-paul.elder@ideasonboard.com>", "References": "<20240319105403.4045592-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The histogram reported by the rkisp1 hardware is 20 bits, where the\nupper 16 bits are meaningful integer data and the lower 4 bits are\nfractional and meant to be discarded. Remove these 4 bits when\nconstructing the histogram.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 47a6f7b2..278903a5 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -352,7 +352,7 @@ double Agc::estimateLuminance(Span<const uint8_t> expMeans, double gain)\n */\n double Agc::measureBrightness(Span<const uint32_t> hist) const\n {\n-\tHistogram histogram{ hist };\n+\tHistogram histogram{ hist, 4 };\n \t/* Estimate the quantile mean of the top 2% of the histogram. */\n \treturn histogram.interQuantileMean(0.98, 1.0);\n }\n", "prefixes": [ "2/2" ] }