Patch Detail
Show a patch.
GET /api/1.1/patches/19651/?format=api
{ "id": 19651, "url": "https://patchwork.libcamera.org/api/1.1/patches/19651/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19651/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240310143023.752559-3-pobrn@protonmail.com>", "date": "2024-03-10T14:30:38", "name": "[v2,2/3] libcamera: framebuffer_allocator: Use default destructor", "commit_ref": "ab5816a5406c3e269a0a5449f682cc3be6a50a1b", "pull_url": null, "state": "accepted", "archived": false, "hash": "43a1ed822fd46ef0d1d19e20f2d868d1c2874023", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19651/mbox/", "series": [ { "id": 4209, "url": "https://patchwork.libcamera.org/api/1.1/series/4209/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4209", "date": "2024-03-10T14:30:38", "name": "couple FrameBufferAllocator changes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4209/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19651/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19651/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA01FBD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 10 Mar 2024 14:30:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22E98628AC;\n\tSun, 10 Mar 2024 15:30:45 +0100 (CET)", "from mail-40131.protonmail.ch (mail-40131.protonmail.ch\n\t[185.70.40.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4256861C81\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 10 Mar 2024 15:30:44 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"P5/BRMm1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1710081043; x=1710340243;\n\tbh=IK4eeGV6FPOsisExRqFI1ZwgwtNoZJ0iwaa/NHmZOkQ=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=P5/BRMm1DkeNTbB/qH+BjEEgme4Tfn2rVMtwSVaZ4YHRAeKEQEm/lKYThss+vOCZB\n\tERmN0KuYEn6IKZxDbPcfS7a7VHe9UYroOVlh/zVpIl7hfaBBT3rxNSQOKVHlaItKWZ\n\thPU0rUwHUpPXRcELSGAvO/9DOzHGa7imzcxABErqAHXr/872nbVVE3De73rbVum8Y1\n\tUCy8eg142iz7+IslZpG65L+ej1V+xVs+AcOeMUSUlJsfhs7YkIYmWcISDRPoeUFmqO\n\tb3PJ8x7yNGJGJ46a/XxoNMmbg9cLHHt2titT0xb3dqN8s/WT9jwK8aptuezAf78bmj\n\th3CKvhI0Yki9Q==", "Date": "Sun, 10 Mar 2024 14:30:38 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH v2 2/3] libcamera: framebuffer_allocator: Use default\n\tdestructor", "Message-ID": "<20240310143023.752559-3-pobrn@protonmail.com>", "In-Reply-To": "<20240310143023.752559-1-pobrn@protonmail.com>", "References": "<20240310143023.752559-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The compiler generated destructor works fine, so use that.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/libcamera/framebuffer_allocator.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp\nindex 8cf45ab2..fc19a33a 100644\n--- a/src/libcamera/framebuffer_allocator.cpp\n+++ b/src/libcamera/framebuffer_allocator.cpp\n@@ -63,10 +63,7 @@ FrameBufferAllocator::FrameBufferAllocator(std::shared_ptr<Camera> camera)\n {\n }\n \n-FrameBufferAllocator::~FrameBufferAllocator()\n-{\n-\tbuffers_.clear();\n-}\n+FrameBufferAllocator::~FrameBufferAllocator() = default;\n \n /**\n * \\brief Allocate buffers for a configured stream\n", "prefixes": [ "v2", "2/3" ] }