Patch Detail
Show a patch.
GET /api/1.1/patches/1964/?format=api
{ "id": 1964, "url": "https://patchwork.libcamera.org/api/1.1/patches/1964/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1964/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190913180132.31000-1-laurent.pinchart@ideasonboard.com>", "date": "2019-09-13T18:01:32", "name": "[libcamera-devel] qcam: Fix compilation errors with gcc-9 and Qt < 5.13", "commit_ref": "304574420d0dd5949e73df9e238eb136a21af1a3", "pull_url": null, "state": "accepted", "archived": false, "hash": "153a552017a0dac79b7b96d090b39d27cbdfaea9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1964/mbox/", "series": [ { "id": 488, "url": "https://patchwork.libcamera.org/api/1.1/series/488/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=488", "date": "2019-09-13T18:01:32", "name": "[libcamera-devel] qcam: Fix compilation errors with gcc-9 and Qt < 5.13", "version": 1, "mbox": "https://patchwork.libcamera.org/series/488/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1964/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1964/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10F9C60BB2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Sep 2019 20:01:43 +0200 (CEST)", "from pendragon.lan (unknown\n\t[IPv6:2001:8a0:6be4:9301:a728:6099:33:a27c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 524A5325;\n\tFri, 13 Sep 2019 20:01:42 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1568397702;\n\tbh=jL5LyMjccshYxR31rgW55lpDFlPhRlXrIlaClW2ZH+g=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=t6oTAiZ2gAe7oUN97KWI009FOW/XIF02Ez1UWIQ2w74uiJOF/1AiedS4MdWUahYv1\n\tpdbUGBHi/OUcvnHy1LdySrbp/+wpEseEIq9eDaMV4SJbc66GWgQX8r6SWZRvUcXDqv\n\t+ghHP4bHrcQlvNuTM1W1wxCtg/sD7kuDnTqLzlMU=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 13 Sep 2019 21:01:32 +0300", "Message-Id": "<20190913180132.31000-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] qcam: Fix compilation errors with gcc-9\n\tand Qt < 5.13", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 13 Sep 2019 18:01:43 -0000" }, "content": "gcc-9 has introduced a deprecated-copy warning that is triggered by Qt\nheader files. The issue has been fixed in Qt 5.13. Fix compilation with\nearlier Qt versions by disabling the warning. In order to still benefit\nfrom the warning when possible, only disable it for gcc-9 and Qt < 5.13.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/meson.build | 14 +++++++++++++-\n 1 file changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/qcam/meson.build b/src/qcam/meson.build\nindex 21f91f25cec0..1e71f20fa15e 100644\n--- a/src/qcam/meson.build\n+++ b/src/qcam/meson.build\n@@ -18,11 +18,23 @@ qt5_dep = dependency('qt5',\n required : false)\n \n if qt5_dep.found()\n+ qt5_cpp_args = [ '-DQT_NO_KEYWORDS' ]\n+\n+ # gcc 9 introduced a deprecated-copy warning that is triggered by Qt until\n+ # Qt 5.13. Disable it manually.\n+ if cc.get_id() == 'gcc'\n+ gcc_version = cc.version().split('.')\n+ qt5_version = qt5_dep.version().split('.')\n+ if qt5_version[1].to_int() < 13 and gcc_version[0].to_int() >= 9\n+ qt5_cpp_args += [ '-Wno-deprecated-copy' ]\n+ endif\n+ endif\n+\n moc_files = qt5.preprocess(moc_headers: qcam_moc_headers,\n dependencies: qt5_dep)\n \n qcam = executable('qcam', qcam_sources, moc_files,\n install : true,\n dependencies : [libcamera_dep, qt5_dep],\n- cpp_args : '-DQT_NO_KEYWORDS')\n+ cpp_args : qt5_cpp_args)\n endif\n", "prefixes": [ "libcamera-devel" ] }