Patch Detail
Show a patch.
GET /api/1.1/patches/19625/?format=api
{ "id": 19625, "url": "https://patchwork.libcamera.org/api/1.1/patches/19625/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19625/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240304094917.1144992-1-hui.fang@nxp.com>", "date": "2024-03-04T09:49:17", "name": "android: camera_device: Fix camera blocked issue when stopping capture", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "eaa906bc9bdb0edc9e2e62c8b4d8d76ba44950e3", "submitter": { "id": 186, "url": "https://patchwork.libcamera.org/api/1.1/people/186/?format=api", "name": "Fang Hui", "email": "hui.fang@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19625/mbox/", "series": [ { "id": 4199, "url": "https://patchwork.libcamera.org/api/1.1/series/4199/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4199", "date": "2024-03-04T09:49:17", "name": "android: camera_device: Fix camera blocked issue when stopping capture", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4199/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19625/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19625/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78AABC326B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 4 Mar 2024 10:21:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99D076286F;\n\tMon, 4 Mar 2024 11:21:46 +0100 (CET)", "from EUR03-DBA-obe.outbound.protection.outlook.com\n\t(mail-dbaeur03on20601.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:260d::601])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0702961C8F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 4 Mar 2024 11:21:45 +0100 (CET)", "from DB9PR04MB9284.eurprd04.prod.outlook.com (2603:10a6:10:36c::8)\n\tby PAXPR04MB9090.eurprd04.prod.outlook.com (2603:10a6:102:227::17)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38;\n\tMon, 4 Mar 2024 10:21:41 +0000", "from DB9PR04MB9284.eurprd04.prod.outlook.com\n\t([fe80::f658:f649:f731:17cb]) by\n\tDB9PR04MB9284.eurprd04.prod.outlook.com\n\t([fe80::f658:f649:f731:17cb%7]) with mapi id 15.20.7339.035;\n\tMon, 4 Mar 2024 10:21:41 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"ahkk2P+f\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=GyWkCb8RgxbutpWQ8poahEgRwax4wLYnMVRCF2qfEB5xmK8s2chDPnsueDBh21thdawiRUUP3Xu0/DEVOnMPQGbLyK603iuPosF7Cp1/EkAvAki8RatdCRwW10FoF0Q/ww1LbNzWXts7SXidEZbDwCZXl6cy/FWaJ0QfeuFLG0285QGXNxvqsdDtsDeaVT36YEAJVcu7TcEoCJ0SR3xKqQspB5jClqi0RLG9d+7D2fDNaIF0J4EoorglxeiNoUbzYnwKoWUnw4tt7GAuYKA7C2xDfTf6wd4QZc3J7B8qg9T2l5ewzkK6zUb6cMyBKHEW3+78xmh6Xr6rqLp/L3flSQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=iKxfIQ+8a38j9sWaq/2F3rnMjtE8oZJc4hBVhwYRhAw=;\n\tb=bE4W1DdDknGFmDjLkvlbV7JJ/HAPFSr8MPCxJ4sfUPjLtiiFDdFKvyIqJo71XiwlJ+TnxKXQXfLVpbRJLogDDWwlt5lj0kHtP0y/dmrsewIpGFWOPmFd254ORdqYFRxWALCCUrNvuELQIjFwkxKnrDj/GeX3ZSgq+oWGf+vB/pfifSSgFRy1ejdg28g1MDV36Hj+qcqvQJZad9TN1jbbzOl8ZR8+rQC+lvn5+MgVJqiUUtk7xrbpB7CDhS8tWtRHRYuWvwaxc96189e6Ig0vzhI0RhqJNYryjpZRsgeu5T5zQ+SFanezRXYV9VJzO02ED3/ZxRxAIdCxkS+RU02+ow==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=iKxfIQ+8a38j9sWaq/2F3rnMjtE8oZJc4hBVhwYRhAw=;\n\tb=ahkk2P+fpvQpb8MtaYEdXaRT2EsXkrFJ6W2aE718ld7MTL2x9WQRzJev3DGDRF/1OA4MNNUbJs/4AkDPelJeGF7XxTAqG7APyxDhwRplOy+wM7XWEyOIokOGJi/NjyvEzK8I0uVjKMU13Jufik7IIafNX8TN4M71BmW5NzTyfww=", "From": "Fang Hui <hui.fang@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] android: camera_device: Fix camera blocked issue when\n\tstopping capture", "Date": "Mon, 4 Mar 2024 17:49:17 +0800", "Message-Id": "<20240304094917.1144992-1-hui.fang@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "SG2PR02CA0008.apcprd02.prod.outlook.com\n\t(2603:1096:3:17::20) To DB9PR04MB9284.eurprd04.prod.outlook.com\n\t(2603:10a6:10:36c::8)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DB9PR04MB9284:EE_|PAXPR04MB9090:EE_", "X-MS-Office365-Filtering-Correlation-Id": "9bef80d5-c68e-405e-97a9-08dc3c34e22b", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "FjXgL8bfVHQbH6lsuSVly7egjDZwi1mvhT6hxBBlylOXfUhNMQNIfAqU70oIuGfxu6fuOfxVpZmby2Q5Kn9bWTxIHDDf811wrRY/WBD8p+hPJNZmhWUR04ZsCalKeh1YH3svIHcJutqMWhg/9eeLtyDLnCQMMXYAm+Z/xrBSW72k8cjNZ1ZRpaI1evldb40tlXOKjimroHijS2eJItNNN1J/MAKYX/Ipgp7kEnZuAfyCZ/VVLmQgmCRq28j1JZmrGg8jBTnku6o2A9+gs0iB1mQYP4xe3uwv6Xrv+bpnOFnBb9oo6suWQRF+Ifq+If7Rxnspy7/Gdnb3YLErHH+S5Nx81WrQVsPnr18W2WbrukmE40pduIdmh4nDblI7WgxJFPjzvk95VPI+/RB1bfsTrgqyDzRX4i+fJ2zYaN1LZuxpVwvp20lsR8HFgYPokD7pUz8/GJZovn0ApM91Auydtr2DX3QAQfVHMbYsff8xghRYyStjyeQylozk+o0UJLMzLwlHBuYoGvokHSTQ6b02CpX73v3DOJxyEaneRq8WC15C5DiFMNYPb+4DCn4PQKECJfScmYAHk2ntv/Xl6sk3JZVOGQokcq4M8Rqs4XPhSHfhssWdblIGBhEiR5UZec9pMxXghokByhSl4SAhUFSSO/QfwKpQ4uV8VuqBuzmrXidNWZcxbh1nNfId6V8F8fIa9cavt6xrn9En5Wq9SRz5fA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:DB9PR04MB9284.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230031)(376005)(38350700005); DIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?1+Z77yvHMfd6MoLFpHL3F/oDu?=\n\t=?utf-8?q?iip+e1yqQODnUdBq01KYoo60WBe7FwH2uUttGg+z8yl7V+RmbylOzw1B?=\n\t=?utf-8?q?CXm0Dfei69nrVpfgvHgbTxkyMN1JqpwFLdxYs9fsK3Aq4Jc7fHiqTSZt?=\n\t=?utf-8?q?96WkjMATC5pJlhR0arKDL0a4wbARcFHcPmaGLWpWYUfqdK5Ghax2LJIs?=\n\t=?utf-8?q?nXzTb0gvwGdJbC9nnNB+YoUYGrlKzqbkIoP16gq/56DkeCinu2e8+WYY?=\n\t=?utf-8?q?hhrvT4+sif3lZGuTMlaSDYCcvONcH2VyQBWR9z+YzOWfiueX32rP57fN?=\n\t=?utf-8?q?3xkHR51o9By1cMS4oQNzwJniiHhDawOVLy2PZp6K9vsy+a3QcW/bsJEI?=\n\t=?utf-8?q?2eNmQf3/DB9tW8c1l01ywBxzXKNaPVfZiJZeQZ+tFh5iuSS1tFHpGfHI?=\n\t=?utf-8?q?YvQH1+AJOtd2lP4l1oCt1Ij24jCt9cbLM2u52bfA9pncpiAzK/JAPUEf?=\n\t=?utf-8?q?6vgN3y7IdCrEJNxb1P38BjkjtbXyXDiaJLqKxH7ENqXivW8EDLDaDcZ3?=\n\t=?utf-8?q?oPbIUrKWCATBcA9XyY0mH3KMtlzBdDweHeBMIVzLk2ogtlZA8S6P4yIZ?=\n\t=?utf-8?q?75FLz27cliK1kcEuf5y7bo/jOx3k0kf0TWe3ttw1An2P8Q+NitJPNrXQ?=\n\t=?utf-8?q?A7nsqaJkx8ah3K0QlyEmoZPOJCJyZ32nPzDFJTb7EYdFgaZVaHZJ34Iq?=\n\t=?utf-8?q?C70LHP1BK9H6CzYhuP3xCdobrJVx2DmY6lO/NvnmJNZ5E7npg1MxKNX0?=\n\t=?utf-8?q?Lr8Epfya6cABxFShCHtNfcqteJghO/IjJOryQaifEsvKgsgJAFz/4rG+?=\n\t=?utf-8?q?4iaNteMBbS1qkN9v33jYyxHNWhfgWRssyYqIcWklscshpuTmk8JxFcxg?=\n\t=?utf-8?q?cpMd+BSwKpPk1PjVt19mmjEDe0B9WzX1SXmcnV9hlN0xH3MBJyPecJrL?=\n\t=?utf-8?q?sLPiBAfh3OQP1hir84iPW8+M7BznDKI+stqTjyH65nbcMbr2QrnpEACZ?=\n\t=?utf-8?q?IjkaNIwCValbMfQ5GnnQCndW9Ji1rNrNdZ7JlTt05Rl8tu4oJhc0sq25?=\n\t=?utf-8?q?gZ1B+0p8HVjWfPBpI6ogtkfQF0QZkkGU/X6IXVABg48akkckbVrIZb5C?=\n\t=?utf-8?q?qe1a4IP3ZGmXK3notrZ2IOHcR7e5ZAX30qNFtZWCgqG8JhaY7fKvxOEt?=\n\t=?utf-8?q?HSeOQuGjjGBZwMxYAuNTEda2g4g04wELADMLy5o2UfMf90Lbx0XV0UBq?=\n\t=?utf-8?q?0VkrCxodZTZfTHelKxs1B/2paiK7DHXUe23mYPnyHWquwuRlTntbyXAv?=\n\t=?utf-8?q?VjgKFuVThUFz/cjDpjMzq8+OV4CUkcD/QbwPVEuh4s0/3t+BvIHVGAB7?=\n\t=?utf-8?q?eS40QsnvOh/9NeHFbkU3OJkHADjPwJpyfBdJ9AbuzmPGHobr7H9vCvpy?=\n\t=?utf-8?q?FDWPLB2yyVcWLb2BKvHBGeSMXJqo1Ln+iGlZK/UwGDAP5nYvr4sofkDh?=\n\t=?utf-8?q?CPSgUGUw4GJEKdmaIDyH75kAvC0I1IP730e7FBWGNGB7TSx8EtF+toTD?=\n\t=?utf-8?q?u6pTBDg8kKJaj2NllX0CI5q6HnbRJ69dkEpiY6R3Q6eytgx0WGxS0DCc?=\n\t=?utf-8?q?aR9O1/mKRqNBXl52/lDTEwXWP+OYFMtaUGqVF+Fp+3lLOhSab71aGSey?=\n\t=?utf-8?q?YoigjFx?=", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "9bef80d5-c68e-405e-97a9-08dc3c34e22b", "X-MS-Exchange-CrossTenant-AuthSource": "DB9PR04MB9284.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Mar 2024 10:21:41.4195\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "zuHUKdCMeVffESlzWyp34/zqvp4RrGu7dGCehIJbfPJi4i2PPsNrhiMmTpsem4DRKpr4Suo+tY7UQ3+O1ozZGQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PAXPR04MB9090", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "anle.pan@nxp.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Anle Pan <anle.pan@nxp.com>\n\nThe issue occurs when stopping capture soon after starting capture.\n\nIn this case, no frame get from the device, the\nrelated capture request has been pushed to the\nqueue descriptors_, but the queuedRequests_ was\nstill empty due to no requests will be queue to\nthe device since the stream will be stopped soon，\nso there will be no camera->requestComplete called\nlater, then the descriptors_ can not pop normally,\nthis will cause the pending if we want to start capture next time.\n\nTo fix the issue, ensure the descriptors_ is\nempty after the camera device is stopped.\n\nSigned-off-by: Anle Pan <anle.pan@nxp.com>\n---\n src/android/camera_device.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 25cedd44..d452992d 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -433,8 +433,11 @@ void CameraDevice::flush()\n void CameraDevice::stop()\n {\n \tMutexLocker stateLock(stateMutex_);\n-\tif (state_ == State::Stopped)\n+\tif (state_ == State::Stopped) {\n+\t\tMutexLocker descriptorsLock(descriptorsMutex_);\n+\t\tdescriptors_ = {};\n \t\treturn;\n+\t}\n \n \tcamera_->stop();\n \n", "prefixes": [] }