Patch Detail
Show a patch.
GET /api/1.1/patches/19615/?format=api
{ "id": 19615, "url": "https://patchwork.libcamera.org/api/1.1/patches/19615/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19615/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240301212121.9072-25-laurent.pinchart@ideasonboard.com>", "date": "2024-03-01T21:21:13", "name": "[PATCH/RFC,24/32] pipeline: raspberrypi: common: Configure sensor embedded data", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "f70c31bf5970af301a0525bcb629c79d8042ca75", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19615/mbox/", "series": [ { "id": 4197, "url": "https://patchwork.libcamera.org/api/1.1/series/4197/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4197", "date": "2024-03-01T21:20:49", "name": "libcamera: Support the upstream Unicam driver", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4197/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19615/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19615/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82A27BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 1 Mar 2024 21:21:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 386B862873;\n\tFri, 1 Mar 2024 22:21:57 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E5EE6295D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Mar 2024 22:21:55 +0100 (CET)", "from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CEB153372;\n\tFri, 1 Mar 2024 22:21:40 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IKmk01+j\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709328101;\n\tbh=ZUpjYlW9wGcZZwE1ZW6TDDGbT2XWigdxfyoyDQwt30E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IKmk01+jSf11ru0RJ/E+OATcu87r3iIx10umthpeOhi56SeiSEpF7hNwGOyl/ypft\n\tuZmQafMDFJmYid79bVyyvH4xS+EcrvBNk52LxLBHiTG2w0ZAdn3eV9AoE/eC/JDo9H\n\tsqmtZYopUx75IxwqrNbdXYaUhmKv5IJxk2RHcMZM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH/RFC 24/32] pipeline: raspberrypi: common: Configure sensor\n\tembedded data", "Date": "Fri, 1 Mar 2024 23:21:13 +0200", "Message-ID": "<20240301212121.9072-25-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>", "References": "<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Sakari Ailus <sakari.ailus@iki.fi>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that the CameraSensor class implements support for embedded data,\nuse the corresponding API to enable or disable the embedded data stream.\n\nThis changes requires sensor kernel drivers that implement the upstream\nembedded data API based on V4L2 streams. As the API is under development\nand not merged in the upstream kernel yet, this breaks compatibility\nwith the downstream Raspberry Pi kernel.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex d662c8f12145..9a2b8b90d5af 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -527,6 +527,18 @@ int PipelineHandlerBase::configure(Camera *camera, CameraConfiguration *config)\n \tif (ret)\n \t\treturn ret;\n \n+\t/*\n+\t * Configure embedded data on the sensor. Only check for errors when\n+\t * enabling embedded data, as some sensors don't support disabling it,\n+\t * and Unicam will simply drop the embedded data packets if we don't\n+\t * capture them.\n+\t */\n+\tret = data->sensor_->setEmbeddedDataEnabled(data->sensorMetadata_);\n+\tif (ret && data->sensorMetadata_) {\n+\t\tLOG(RPI, Error) << \"Unable to enable embedded data: \" << ret;\n+\t\treturn ret;\n+\t}\n+\n \t/*\n \t * Platform specific internal stream configuration. This also assigns\n \t * external streams which get configured below.\n", "prefixes": [ "PATCH/RFC", "24/32" ] }