Patch Detail
Show a patch.
GET /api/1.1/patches/19605/?format=api
{ "id": 19605, "url": "https://patchwork.libcamera.org/api/1.1/patches/19605/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19605/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240301212121.9072-15-laurent.pinchart@ideasonboard.com>", "date": "2024-03-01T21:21:03", "name": "[PATCH/RFC,14/32] libcamera: camera_sensor: Move related classes to subdirectory", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "5463900f2b845737da3cce91d56e152bf706f36f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19605/mbox/", "series": [ { "id": 4197, "url": "https://patchwork.libcamera.org/api/1.1/series/4197/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4197", "date": "2024-03-01T21:20:49", "name": "libcamera: Support the upstream Unicam driver", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4197/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19605/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19605/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F225BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 1 Mar 2024 21:21:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A6C462B3D;\n\tFri, 1 Mar 2024 22:21:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F06962876\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Mar 2024 22:21:40 +0100 (CET)", "from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBF1B2D6B;\n\tFri, 1 Mar 2024 22:21:25 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sZmJGuyK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709328086;\n\tbh=5d87m6A4rdpGH5Moa/arL79EQkJ5SF5QdsOgZxFAExs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sZmJGuyKLkTaqNwPo3Zpy2wunwuPKe2jTts52jdcmOrYqTtJ0IyZmUxa0EQA+bs5F\n\t+t+apKLe626511PdSFXPubs5kHCRJVDuhzSwg4iEIxCn+uzJYzN1ykGeIpZd2g2suS\n\tjV+W43zLZfgbVu4tvttNVYoLkQnugzewHv4ICb4w=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH/RFC 14/32] libcamera: camera_sensor: Move related classes to\n\tsubdirectory", "Date": "Fri, 1 Mar 2024 23:21:03 +0200", "Message-ID": "<20240301212121.9072-15-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>", "References": "<20240301212121.9072-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Sakari Ailus <sakari.ailus@iki.fi>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In preparation for adding alternative implementations of the\nCameraSensor class, move the code to a subdirectory to avoid cluttering\nthe main src/libcamera/ directory.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/meson.build | 3 +--\n src/libcamera/{ => sensor}/camera_sensor.cpp | 0\n src/libcamera/{ => sensor}/camera_sensor_properties.cpp | 0\n src/libcamera/sensor/meson.build | 6 ++++++\n 4 files changed, 7 insertions(+), 2 deletions(-)\n rename src/libcamera/{ => sensor}/camera_sensor.cpp (100%)\n rename src/libcamera/{ => sensor}/camera_sensor_properties.cpp (100%)\n create mode 100644 src/libcamera/sensor/meson.build", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 45f63e932e4f..2e7b0c77e63c 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -7,8 +7,6 @@ libcamera_sources = files([\n 'camera_controls.cpp',\n 'camera_lens.cpp',\n 'camera_manager.cpp',\n- 'camera_sensor.cpp',\n- 'camera_sensor_properties.cpp',\n 'color_space.cpp',\n 'controls.cpp',\n 'control_serializer.cpp',\n@@ -69,6 +67,7 @@ subdir('converter')\n subdir('ipa')\n subdir('pipeline')\n subdir('proxy')\n+subdir('sensor')\n \n null_dep = dependency('', required : false)\n \ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nsimilarity index 100%\nrename from src/libcamera/camera_sensor.cpp\nrename to src/libcamera/sensor/camera_sensor.cpp\ndiff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nsimilarity index 100%\nrename from src/libcamera/camera_sensor_properties.cpp\nrename to src/libcamera/sensor/camera_sensor_properties.cpp\ndiff --git a/src/libcamera/sensor/meson.build b/src/libcamera/sensor/meson.build\nnew file mode 100644\nindex 000000000000..bf4b131a94b1\n--- /dev/null\n+++ b/src/libcamera/sensor/meson.build\n@@ -0,0 +1,6 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+libcamera_sources += files([\n+ 'camera_sensor.cpp',\n+ 'camera_sensor_properties.cpp',\n+])\n", "prefixes": [ "PATCH/RFC", "14/32" ] }