Patch Detail
Show a patch.
GET /api/1.1/patches/19590/?format=api
{ "id": 19590, "url": "https://patchwork.libcamera.org/api/1.1/patches/19590/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19590/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240301101135.18822-1-jacopo.mondi@ideasonboard.com>", "date": "2024-03-01T10:11:35", "name": "guides: pipeline-handler: Fix controlInfo_ initialization", "commit_ref": "1bf2d707e4becb51fc04ccdb0a8032290ec81fdb", "pull_url": null, "state": "accepted", "archived": false, "hash": "9f559d0828a9de7869ee4ea905df1b5ca40292e5", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19590/mbox/", "series": [ { "id": 4196, "url": "https://patchwork.libcamera.org/api/1.1/series/4196/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4196", "date": "2024-03-01T10:11:35", "name": "guides: pipeline-handler: Fix controlInfo_ initialization", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4196/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19590/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19590/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F955BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 1 Mar 2024 10:11:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6F2461C8D;\n\tFri, 1 Mar 2024 11:11:53 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D097B61C8D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Mar 2024 11:11:51 +0100 (CET)", "from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EE3E899;\n\tFri, 1 Mar 2024 11:11:37 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FLkRJ8qk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1709287897;\n\tbh=J3kj6Oks+bT46+fKgQ6q91TaKYqqKpZ1CUzbCN8swfc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FLkRJ8qkcr7+Z6Wbkvgh92vlgzlKTsRHmDUsw45xekTJ2hMKrtkDxsWu8PATAoMHp\n\tmlk+GE6qEnobWnuI/+fb/zBpwMnqrrsVe7dMCkuylSXqIBBeYrvDe22ORvydZxLLlr\n\tbsSZxcuHHBntYToYtaGwXkg9en13faLW9AH8hhXo=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] guides: pipeline-handler: Fix controlInfo_ initialization", "Date": "Fri, 1 Mar 2024 11:11:35 +0100", "Message-ID": "<20240301101135.18822-1-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since commit b48db3c489d3 (\"libcamera: controls: Create ControlInfoMap\nwith ControlIdMap\"), instances of the ControlInfoMap class need to be\ncreated with an instance of an unordered_map of ControlId to ControlInfo\nand with a ControlIdMap instance.\n\nThe pipeline handler developer guide was never updated to reflect the\nchange. Fix it.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n Documentation/guides/pipeline-handler.rst | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\nindex 10b9c75c2a7f..5396eb6d0c56 100644\n--- a/Documentation/guides/pipeline-handler.rst\n+++ b/Documentation/guides/pipeline-handler.rst\n@@ -651,7 +651,7 @@ inline in our VividCameraData init:\n ctrls.emplace(id, info);\n }\n \n- controlInfo_ = std::move(ctrls);\n+ controlInfo_ = ControlInfoMap(std::move(ctrls), controls::controls);\n \n The ``properties_`` field is a list of ``ControlId`` instances\n associated with immutable values, which represent static characteristics that can\n", "prefixes": [] }