Patch Detail
Show a patch.
GET /api/1.1/patches/1957/?format=api
{ "id": 1957, "url": "https://patchwork.libcamera.org/api/1.1/patches/1957/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1957/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190910090418.30502-4-kieran.bingham@ideasonboard.com>", "date": "2019-09-10T09:04:18", "name": "[libcamera-devel,3/3] test: process: Extend timeout duration", "commit_ref": "ff09b6d3788731eadc31b6f73252243577b3d3d3", "pull_url": null, "state": "accepted", "archived": false, "hash": "e408e30b5fbd062a2eda01848242a61945cbb77d", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1957/mbox/", "series": [ { "id": 485, "url": "https://patchwork.libcamera.org/api/1.1/series/485/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=485", "date": "2019-09-10T09:04:15", "name": "test: process: Cleanup to process test", "version": 1, "mbox": "https://patchwork.libcamera.org/series/485/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1957/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1957/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9183C60BCF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Sep 2019 11:04:26 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36F44DAD;\n\tTue, 10 Sep 2019 11:04:26 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1568106266;\n\tbh=5rcwvtbiWsOCeHPp+GvhSqGv0opTRe9bziOjq8I6b0o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YcoUUZ5ybevk+xRRv3KeWN1PrSsmxHoqdETdzjN6enEgjdW26c1ipa49E8/V3MuEa\n\tEjcyZVeoWJAHK6rH+Svh4019Z3mA+reRlxXfW8amNhnBn5Xnh4DgysrOSKTqkqp7x0\n\tPiJuS8CguU9XPJDb6cr6WofeBueWxSCd936StHvs=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 10 Sep 2019 10:04:18 +0100", "Message-Id": "<20190910090418.30502-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190910090418.30502-1-kieran.bingham@ideasonboard.com>", "References": "<20190910090418.30502-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/3] test: process: Extend timeout duration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 10 Sep 2019 09:04:26 -0000" }, "content": "The process test runs for just 100mS. The spawned process runs for at\nleast 50mS. Ordinarily this should allow plenty of time for both the\nprocess to be spawned and run, but when adding extra debug\ninstrumentation, the processes can be slowed down, leading to a false\nnegative test failure.\n\nExtend the timeout to 2 seconds to allow the short process to be run\ncorrectly - but use the now initialised exitStatus_ to exit the event\nloop as soon as the process has completed.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n test/process/process_test.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp\nindex f3cabe0a36c7..7e7b3c2c8bf3 100644\n--- a/test/process/process_test.cpp\n+++ b/test/process/process_test.cpp\n@@ -56,8 +56,8 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\ttimeout.start(100);\n-\t\twhile (timeout.isRunning())\n+\t\ttimeout.start(2000);\n+\t\twhile (timeout.isRunning() && exitStatus_ == Process::NotExited)\n \t\t\tdispatcher->processEvents();\n \n \t\tif (exitStatus_ != Process::NormalExit) {\n", "prefixes": [ "libcamera-devel", "3/3" ] }