Patch Detail
Show a patch.
GET /api/1.1/patches/19537/?format=api
{ "id": 19537, "url": "https://patchwork.libcamera.org/api/1.1/patches/19537/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19537/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240225164348.10073-3-laurent.pinchart@ideasonboard.com>", "date": "2024-02-25T16:43:47", "name": "[2/2] libcamera: Use utils::to_underlying()", "commit_ref": "dae4a4406779ba1bc1687446d20c82a1f96b5258", "pull_url": null, "state": "accepted", "archived": false, "hash": "554357996367be8d9d3a72e667669059fd7e417f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19537/mbox/", "series": [ { "id": 4179, "url": "https://patchwork.libcamera.org/api/1.1/series/4179/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4179", "date": "2024-02-25T16:43:45", "name": "libcamera: Add utils::to_underlying() helper", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4179/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19537/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19537/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3D45BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 25 Feb 2024 16:43:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5703762865;\n\tSun, 25 Feb 2024 17:43:51 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1887C61CA1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 25 Feb 2024 17:43:48 +0100 (CET)", "from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 364EA4E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 25 Feb 2024 17:43:37 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qCVtiqfr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708879417;\n\tbh=9DQ/QJLS/r5TGcwuNFIFsbzRr4Jo65LM9kI6MEw4Png=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=qCVtiqfroOOxnjjBQtsH2Irm/nfLVsMrKOpm5eNEdyT1mBGWx6hGacYYptObJip3G\n\t+g1sL1tgFu7bBGmZVJ7U4vOmdn8/QKGnc2DdrZO6Bm7Qgt2KZQ08Tbsg+k7R905yNQ\n\trFXs3aNJXFv4BDIU9OS9J9/TK14esDmT/wX8ukZc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 2/2] libcamera: Use utils::to_underlying()", "Date": "Sun, 25 Feb 2024 18:43:47 +0200", "Message-ID": "<20240225164348.10073-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240225164348.10073-1-laurent.pinchart@ideasonboard.com>", "References": "<20240225164348.10073-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace manual implementations of the utils::to_underlying() helper with\ncalls to the function.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rpi/controller/rpi/sdn.cpp | 3 ++-\n src/libcamera/pipeline/rpi/common/rpi_stream.h | 10 +++-------\n src/libcamera/stream.cpp | 2 +-\n 3 files changed, 6 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/ipa/rpi/controller/rpi/sdn.cpp b/src/ipa/rpi/controller/rpi/sdn.cpp\nindex 6743919e6b36..2f777dd725e2 100644\n--- a/src/ipa/rpi/controller/rpi/sdn.cpp\n+++ b/src/ipa/rpi/controller/rpi/sdn.cpp\n@@ -6,6 +6,7 @@\n */\n \n #include <libcamera/base/log.h>\n+#include <libcamera/base/utils.h>\n \n #include \"../denoise_status.h\"\n #include \"../noise_status.h\"\n@@ -60,7 +61,7 @@ void Sdn::prepare(Metadata *imageMetadata)\n \tstatus.noiseConstant = noiseStatus.noiseConstant * deviation_;\n \tstatus.noiseSlope = noiseStatus.noiseSlope * deviation_;\n \tstatus.strength = strength_;\n-\tstatus.mode = static_cast<std::underlying_type_t<DenoiseMode>>(mode_);\n+\tstatus.mode = utils::to_underlying(mode_);\n \timageMetadata->set(\"denoise.status\", status);\n \tLOG(RPiSdn, Debug)\n \t\t<< \"programmed constant \" << status.noiseConstant\ndiff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.h b/src/libcamera/pipeline/rpi/common/rpi_stream.h\nindex fc2bdfe25d4a..48ed41abea01 100644\n--- a/src/libcamera/pipeline/rpi/common/rpi_stream.h\n+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.h\n@@ -14,6 +14,7 @@\n #include <vector>\n \n #include <libcamera/base/flags.h>\n+#include <libcamera/base/utils.h>\n \n #include <libcamera/stream.h>\n \n@@ -180,19 +181,14 @@ private:\n template<typename E, std::size_t N>\n class Device : public std::array<class Stream, N>\n {\n-private:\n-\tconstexpr auto index(E e) const noexcept\n-\t{\n-\t\treturn static_cast<std::underlying_type_t<E>>(e);\n-\t}\n public:\n \tStream &operator[](E e)\n \t{\n-\t\treturn std::array<class Stream, N>::operator[](index(e));\n+\t\treturn std::array<class Stream, N>::operator[](utils::to_underlying(e));\n \t}\n \tconst Stream &operator[](E e) const\n \t{\n-\t\treturn std::array<class Stream, N>::operator[](index(e));\n+\t\treturn std::array<class Stream, N>::operator[](utils::to_underlying(e));\n \t}\n };\n \ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex f3e00ead5ac6..540a428eacdd 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -433,7 +433,7 @@ std::ostream &operator<<(std::ostream &out, StreamRole role)\n \t\t\"Viewfinder\",\n \t};\n \n-\tout << names[static_cast<std::underlying_type_t<StreamRole>>(role)];\n+\tout << names[utils::to_underlying(role)];\n \treturn out;\n }\n \n", "prefixes": [ "2/2" ] }