Patch Detail
Show a patch.
GET /api/1.1/patches/1952/?format=api
{ "id": 1952, "url": "https://patchwork.libcamera.org/api/1.1/patches/1952/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1952/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190905190457.19745-1-fontaine.fabrice@gmail.com>", "date": "2019-09-05T19:04:57", "name": "[libcamera-devel] src/libcamera/meson.build: link with atomic when needed", "commit_ref": "5d05418d9b53e1838692f687a6dc373dad45355c", "pull_url": null, "state": "accepted", "archived": false, "hash": "0ec720b80dd17d3120631f190dd2c8ff776c47e2", "submitter": { "id": 22, "url": "https://patchwork.libcamera.org/api/1.1/people/22/?format=api", "name": "Fabrice Fontaine", "email": "fontaine.fabrice@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1952/mbox/", "series": [ { "id": 483, "url": "https://patchwork.libcamera.org/api/1.1/series/483/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=483", "date": "2019-09-05T19:04:57", "name": "[libcamera-devel] src/libcamera/meson.build: link with atomic when needed", "version": 1, "mbox": "https://patchwork.libcamera.org/series/483/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1952/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1952/checks/", "tags": {}, "headers": { "Return-Path": "<fontaine.fabrice@gmail.com>", "Received": [ "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 253C560BF6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Sep 2019 21:04:41 +0200 (CEST)", "by mail-wm1-x336.google.com with SMTP id y135so5671151wmc.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 05 Sep 2019 12:04:41 -0700 (PDT)", "from kali.home (lfbn-ren-1-605-248.w81-53.abo.wanadoo.fr.\n\t[81.53.181.248]) by smtp.gmail.com with ESMTPSA id\n\tg201sm5526282wmg.34.2019.09.05.12.04.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 05 Sep 2019 12:04:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Y0em7KE65E4vw8avDXZfP2Rm3jNkrhDEGXXPchWpQiw=;\n\tb=Y0RzOppTI6OuHIuscZP+Bi8L6TR08ZF9X/PIF196zlrx2eEcFA3FSL46bcdH7SS2xh\n\tEHZ5RCgFzANpO/iwxLJiObT9xeKtuNAu7okDaeJ551NhHSJGbkhcHE/X/4cMJzatJhYX\n\tYava07RGqfBAPIQB4KNZ3iVPjNbkAaVs8LV8gNNC8A6JlNblkzyD99nybTtMuFptR1HX\n\tZeomfnQ/RkMHqPnfxLMvOdLRo9MdJZJQj18tlphHuNJGXjmUFGWB/+fdJBaX2A5Ny3PF\n\tv1bXD847XlIRpdR+CjZhx0O9Ve4OfTKrXf823lcze5U3auXWdkCwDTcZgfmDF8PiSXOj\n\t8SDw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Y0em7KE65E4vw8avDXZfP2Rm3jNkrhDEGXXPchWpQiw=;\n\tb=uc6NY5VP11fhykREpRHlSMm1AIv46vgayYzvrqj7nnK7bw+N6xh550mRHUmxa+kUy8\n\t1x1KOF/BtWRjePccV5YVxUCYldoUxTGauORgUJOl7lobxy8imOkdyildNgAppzXaowoG\n\tpj5KyEbXaibVqOa1avtuCyy6kZN2ZorA/VOh+Fin5BJLRJzMg3+hiSY3AJfTyUG/6G8k\n\tZmsk91Fthm9smFtXDB9Co5RNydTPbMl/khe1NcdzFPHSKk+Aoz1nJEYxeNjSo/ZQR/km\n\t+VCglFXg5nZTJzuPRyoWWQhdI2Q3DQA/zySH2FznThJDdZ6yzDXYPUAvsTdxu0Fo1vxt\n\tMkrg==", "X-Gm-Message-State": "APjAAAXBrgEz5fWs9FrOFCkPSNNyyU5KDzpP5FnafeHiauS1QrxcqetE\n\t6QPjlmSITXoi9QK1jlut2ytZsd0NC6o=", "X-Google-Smtp-Source": "APXvYqz7Iuyvw8swAEgwXnOjK8oscbo6bwcVv6qy9SnJ9NvSy8Z0MRz6YyFaqAuc18LZq/JQ9xSkGQ==", "X-Received": "by 2002:a1c:c013:: with SMTP id q19mr3793389wmf.87.1567710280486;\n\tThu, 05 Sep 2019 12:04:40 -0700 (PDT)", "From": "Fabrice Fontaine <fontaine.fabrice@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Fabrice Fontaine <fontaine.fabrice@gmail.com>", "Date": "Thu, 5 Sep 2019 21:04:57 +0200", "Message-Id": "<20190905190457.19745-1-fontaine.fabrice@gmail.com>", "X-Mailer": "git-send-email 2.23.0.rc1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 06 Sep 2019 01:28:29 +0200", "Subject": "[libcamera-devel] [PATCH] src/libcamera/meson.build: link with\n\tatomic when needed", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 05 Sep 2019 19:04:41 -0000" }, "content": "On some architectures, atomic binutils are provided by the libatomic\nlibrary from gcc. Linking with libatomic is therefore necessary,\notherwise the build fails with:\n\n/home/buildroot/autobuild/run/instance-3/output/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: src/libcamera/4ab8042@@camera@sha/v4l2_videodevice.cpp.o: in function `libcamera::V4L2VideoDevice::queueBuffer(libcamera::Buffer*)':\nv4l2_videodevice.cpp:(.text+0x1470): undefined reference to `__atomic_fetch_add_4'\n\nThis is often for example the case on sparc v8 32 bits.\n\nFixes:\n - http://autobuild.buildroot.org/results/1f0b8338f5f39aa86b9d432598dae2f53c5f7c84\n\nSigned-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>\n---\n src/libcamera/meson.build | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex c5d8f11..0706a08 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -99,6 +99,7 @@ version_cpp = vcs_tag(command : [gen_version, meson.build_root()],\n libcamera_sources += version_cpp\n \n libcamera_deps = [\n+ cc.find_library('atomic', required: false),\n cc.find_library('dl'),\n libudev,\n dependency('threads'),\n", "prefixes": [ "libcamera-devel" ] }