Patch Detail
Show a patch.
GET /api/1.1/patches/19519/?format=api
{ "id": 19519, "url": "https://patchwork.libcamera.org/api/1.1/patches/19519/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19519/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240221024638.1486832-1-raj.khem@gmail.com>", "date": "2024-02-21T02:46:38", "name": "rpi: Use alloca instead of variable length arrays", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ec7371a5a1ac278c9bb2621a00b2f88175ba0a96", "submitter": { "id": 62, "url": "https://patchwork.libcamera.org/api/1.1/people/62/?format=api", "name": "Khem Raj", "email": "raj.khem@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19519/mbox/", "series": [ { "id": 4173, "url": "https://patchwork.libcamera.org/api/1.1/series/4173/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4173", "date": "2024-02-21T02:46:38", "name": "rpi: Use alloca instead of variable length arrays", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4173/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19519/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19519/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 058BDBD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Feb 2024 02:46:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24DCE62809;\n\tWed, 21 Feb 2024 03:46:46 +0100 (CET)", "from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com\n\t[IPv6:2607:f8b0:4864:20::102c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A085E62800\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Feb 2024 03:46:43 +0100 (CET)", "by mail-pj1-x102c.google.com with SMTP id\n\t98e67ed59e1d1-29938dcb711so2830978a91.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Feb 2024 18:46:43 -0800 (PST)", "from apollo.hsd1.ca.comcast.net ([2601:646:9d80:4380::696f])\n\tby smtp.gmail.com with ESMTPSA id\n\tx11-20020a170902e04b00b001d987bfdd5fsm7039013plx.253.2024.02.20.18.46.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Feb 2024 18:46:41 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"X7rwsihW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1708483602; x=1709088402;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=PlDLnEUHIahZtWdAcvzxq1nZyoq7DXBxomPDzG2q9JU=;\n\tb=X7rwsihWcWMdNv1ahT1j2qoW3G2Q5VeF6LtL2TqTQjm3r8Ai5PRKzPogyfVbNG9aPF\n\tekRRmmcZ0EljzGpLllHJJESSxf+A9l+KbDzZKh8WwGt5bwg6b5Zln7gUABZbELdOs0L5\n\tO+oEh86toL5esuotf/pxIUcwL657hFbMUvDr3EDOlMnkhp5SHmb0vdr654DcIYX7m9bj\n\tcONAMyqhNPtFCwSs55z3W5zh8t4tdzKjjEmfJxNB8tBRq4beJ4kVBwyedm7zpiyrglAh\n\tI0nYhBINVF+kLfQNKb+klrowVqjcukL1UhadjLBXsNbTqXNh6OU2zjKiEiHPpz8OjA2A\n\tPMDw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1708483602; x=1709088402;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=PlDLnEUHIahZtWdAcvzxq1nZyoq7DXBxomPDzG2q9JU=;\n\tb=JORxQHSGx/RYjuNHYrG0qfO1lMLxgxhwH7ZvoKAQDpk1oupOpkT8c02a2ceDCkINc0\n\t+aKfQNh98GzNG0jU2Ls+LMcw18o0F3a6RvzkW19R7Bp0mFPkH2WxrdirqcuFDGjBn3gs\n\tV7ATGMKF5b/sg8BraDLg7GuotqWo3q/UQ4mR4rk5m4m8jlqr4rY3pWZtIzYJl1rEY4lO\n\tZSJPG/dKmtQ5zKL4wTl/LHnXpRKXc9u2cG9TdbqemeYPXxzg+HpWbkc8dwEqa+muGxqs\n\trZkYa7jy1Hv9Ja+NIdiDJJN4sjNhvn6DZFqSqg+3U7hFq6kPlxirstlP4FAtotja0saA\n\tcDXA==", "X-Gm-Message-State": "AOJu0Yzfge4PxKE8TvcQmwnXF7b3M7gWLYjI4ObkXOSoX8tHoQngq96O\n\tktqGVcLecRsx4Re6ZAwoz7YbsrmyvCLucWUb69AbS+FWb1df6IUZ0Oj2i0Lr4kk=", "X-Google-Smtp-Source": "AGHT+IGa12+d08PxgZjI+Iqk6UqIpxAlXizuntPQ6v6ke2V9eaXEzqlY7gL9U17zt0XY5UQz2HJAAA==", "X-Received": "by 2002:a17:90a:6c42:b0:299:4d76:be4f with SMTP id\n\tx60-20020a17090a6c4200b002994d76be4fmr8272811pjj.2.1708483601620; \n\tTue, 20 Feb 2024 18:46:41 -0800 (PST)", "From": "Khem Raj <raj.khem@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] rpi: Use alloca instead of variable length arrays", "Date": "Tue, 20 Feb 2024 18:46:38 -0800", "Message-ID": "<20240221024638.1486832-1-raj.khem@gmail.com>", "X-Mailer": "git-send-email 2.43.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Khem Raj <raj.khem@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Clang-18+ diagnoses this as error\n\n| ../git/src/ipa/rpi/controller/rpi/alsc.cpp:499:10: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension] | 499 | int xLo[X], xHi[X];\n| | ^\n\nSigned-off-by: Khem Raj <raj.khem@gmail.com>\n---\n src/ipa/rpi/controller/rpi/alsc.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rpi/controller/rpi/alsc.cpp b/src/ipa/rpi/controller/rpi/alsc.cpp\nindex 8a205c60..8c0ae8eb 100644\n--- a/src/ipa/rpi/controller/rpi/alsc.cpp\n+++ b/src/ipa/rpi/controller/rpi/alsc.cpp\n@@ -496,8 +496,8 @@ void resampleCalTable(const Array2D<double> &calTableIn,\n \t * Precalculate and cache the x sampling locations and phases to save\n \t * recomputing them on every row.\n \t */\n-\tint xLo[X], xHi[X];\n-\tdouble xf[X];\n+\tint *xLo = (int*)alloca(X), *xHi = (int*)alloca(X);\n+\tdouble *xf = (double*)alloca(X);\n \tdouble scaleX = cameraMode.sensorWidth /\n \t\t\t(cameraMode.width * cameraMode.scaleX);\n \tdouble xOff = cameraMode.cropX / (double)cameraMode.sensorWidth;\n", "prefixes": [] }