Patch Detail
Show a patch.
GET /api/1.1/patches/19503/?format=api
{ "id": 19503, "url": "https://patchwork.libcamera.org/api/1.1/patches/19503/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19503/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240215132710.810-3-naush@raspberrypi.com>", "date": "2024-02-15T13:27:10", "name": "[v1,2/2] libcamera: formats: Add PiSP specific image and config buffer formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "394145a6fb3775f14c19078e128dd5145c8840b7", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19503/mbox/", "series": [ { "id": 4169, "url": "https://patchwork.libcamera.org/api/1.1/series/4169/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4169", "date": "2024-02-15T13:27:08", "name": "Raspberry Pi: PiSP image formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4169/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19503/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19503/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7521BC3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Feb 2024 13:27:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6546462809;\n\tThu, 15 Feb 2024 14:27:22 +0100 (CET)", "from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com\n\t[IPv6:2a00:1450:4864:20::52b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B64862801\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Feb 2024 14:27:20 +0100 (CET)", "by mail-ed1-x52b.google.com with SMTP id\n\t4fb4d7f45d1cf-562178003a1so1081394a12.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Feb 2024 05:27:20 -0800 (PST)", "from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tew14-20020a056402538e00b005607825b11bsm532283edb.12.2024.02.15.05.27.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Feb 2024 05:27:18 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"o6ESsUsH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1708003639; x=1708608439;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=dK3sYvk+h2g09CZpsWIaT7kzrLDBNhXyidVoRqp0nz0=;\n\tb=o6ESsUsHpJR5QlPBWmR/7J2fck6WVVUx99yOYX85hWSCXIqubMsh/NKTNgVah+2mQ8\n\tkiNR2TBklIUUorQVijBAAqytF2P4NHYhxL54n0sMvkIhydTVLni693bGHafieOu3WK90\n\twcHdxV+U2LQtHI3Veu1Qx+RdcQy7eUN9Sfhlyrrq55iz0litEfJR04IR2TTaEYbhUQSN\n\tEOIzgdOpgZqG5sRmqS9e0gCl3MOimTKVF4CkXpvRfcmcV/P93KxOIsOA1N6IZV8E7/+b\n\t688+kb8F7PRprE5yNo6+Z9sScaB/gouj1qou5gaF6r4ilIahYYtQ1G81p3yuk/ZfqAPP\n\topfA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1708003639; x=1708608439;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=dK3sYvk+h2g09CZpsWIaT7kzrLDBNhXyidVoRqp0nz0=;\n\tb=KRWqaaHRcP/jf0Lr2xyyFw14xd1WH15f43O+EENFUDlHn9ucYZniZerN4qwIHpJrpc\n\ti71S6Y2S/BvILLlgbIm9x6YZrk4rS9FuDLkfFJrX3o0uO+cwHYUqpNeiqWUEb8Ct9GiY\n\tZvelxHDEa7UtDJIox6vaDuGXpJYHqrRRc2P5+JAqbkIMr1ZneMRy8a7eUCdD8AeS6kwZ\n\tgUrac7DdkuhXj1nk9TBI6yEAveoX3jFLhoZec/yzhH62JrEmATXtvQdsBHJPginLd1Wr\n\tr9dAw2xoNS/FIdo6xhUPhCtsF3FzQc+bUdC7QPKFPKrNxCMvC3Dw/rZlcmqJEagDcOMM\n\tNOdw==", "X-Gm-Message-State": "AOJu0Yz1bDy5zf6nUr3HheiR39Ia3Oss5wDT4PxglENVQfu00l7UxBND\n\tMHCeKy7pHnnB/dnITuTQ72mgyzrdEKWog5OrMIXkG25jCVC1GYrn3/7fq9zPeAR2riq08DyFXJ/\n\tp", "X-Google-Smtp-Source": "AGHT+IHZVCbiQ/vRQP4TvTwhm6/MJsxzyzOGQc8Fc+renLBcXArB9ezi/4OuCb52+qANd88OjVt/rw==", "X-Received": "by 2002:a05:6402:120c:b0:561:adff:6acc with SMTP id\n\tc12-20020a056402120c00b00561adff6accmr1257305edw.26.1708003639251; \n\tThu, 15 Feb 2024 05:27:19 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 2/2] libcamera: formats: Add PiSP specific image and\n\tconfig buffer formats", "Date": "Thu, 15 Feb 2024 13:27:10 +0000", "Message-Id": "<20240215132710.810-3-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240215132710.810-1-naush@raspberrypi.com>", "References": "<20240215132710.810-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add the Raspberry Pi 5 PiSP specific compressed Bayer format types 1/2:\n- V4L2_PIX_FMT_PISP_COMP1_xxx\n- V4L2_PIX_FMT_PISP_COMP2_xxx\n\nAdd the Raspberry Pi 5 PiSP Backend config format:\n- V4L2_META_FMT_RPI_BE_CFG\n\nAdditionally, we also extend libcamera format handlers to support 16-bit\nBayer formats across the media bus.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n include/libcamera/internal/bayer_format.h | 2 +\n include/linux/drm_fourcc.h | 4 ++\n include/linux/videodev2.h | 15 +++++++\n src/libcamera/bayer_format.cpp | 18 ++++++++\n src/libcamera/formats.cpp | 51 ++++++++++++++++++++++-\n src/libcamera/formats.yaml | 16 +++++++\n src/libcamera/v4l2_pixelformat.cpp | 10 +++++\n src/libcamera/v4l2_subdevice.cpp | 4 ++\n 8 files changed, 119 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/bayer_format.h b/include/libcamera/internal/bayer_format.h\nindex 78ba3969913d..164743f7e9f6 100644\n--- a/include/libcamera/internal/bayer_format.h\n+++ b/include/libcamera/internal/bayer_format.h\n@@ -34,6 +34,8 @@ public:\n \t\tNone = 0,\n \t\tCSI2 = 1,\n \t\tIPU3 = 2,\n+\t\tPISP1 = 3,\n+\t\tPISP2 = 4,\n \t};\n \n \tconstexpr BayerFormat()\ndiff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\nindex 4ee421b95730..eff27fbe5a1e 100644\n--- a/include/linux/drm_fourcc.h\n+++ b/include/linux/drm_fourcc.h\n@@ -490,6 +490,7 @@ extern \"C\" {\n #define DRM_FORMAT_MOD_VENDOR_ALLWINNER 0x09\n #define DRM_FORMAT_MOD_VENDOR_AMLOGIC 0x0a\n #define DRM_FORMAT_MOD_VENDOR_MIPI 0x0b\n+#define DRM_FORMAT_MOD_VENDOR_RPI 0x0c\n \n /* add more to the end as needed */\n \n@@ -1670,6 +1671,9 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)\n */\n #define MIPI_FORMAT_MOD_CSI2_PACKED fourcc_mod_code(MIPI, 1)\n \n+#define PISP_FORMAT_MOD_COMPRESS_MODE1 fourcc_mod_code(RPI, 1)\n+#define PISP_FORMAT_MOD_COMPRESS_MODE2 fourcc_mod_code(RPI, 2)\n+\n #if defined(__cplusplus)\n }\n #endif\ndiff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\nindex ba48d2c89726..59af6f794680 100644\n--- a/include/linux/videodev2.h\n+++ b/include/linux/videodev2.h\n@@ -789,6 +789,18 @@ struct v4l2_pix_format {\n #define V4L2_PIX_FMT_IPU3_SGRBG10\tv4l2_fourcc('i', 'p', '3', 'G') /* IPU3 packed 10-bit GRBG bayer */\n #define V4L2_PIX_FMT_IPU3_SRGGB10\tv4l2_fourcc('i', 'p', '3', 'r') /* IPU3 packed 10-bit RGGB bayer */\n \n+/* The pixel format for all our buffers (the precise format is found in the config buffer). */\n+#define V4L2_PIX_FMT_PISP_COMP1_RGGB\tv4l2_fourcc('P', 'C', '1', 'R')\n+#define V4L2_PIX_FMT_PISP_COMP1_GRBG\tv4l2_fourcc('P', 'C', '1', 'G')\n+#define V4L2_PIX_FMT_PISP_COMP1_GBRG\tv4l2_fourcc('P', 'C', '1', 'g')\n+#define V4L2_PIX_FMT_PISP_COMP1_BGGR\tv4l2_fourcc('P', 'C', '1', 'B')\n+#define V4L2_PIX_FMT_PISP_COMP1_MONO\tv4l2_fourcc('P', 'C', '1', 'M')\n+#define V4L2_PIX_FMT_PISP_COMP2_RGGB\tv4l2_fourcc('P', 'C', '2', 'R')\n+#define V4L2_PIX_FMT_PISP_COMP2_GRBG\tv4l2_fourcc('P', 'C', '2', 'G')\n+#define V4L2_PIX_FMT_PISP_COMP2_GBRG\tv4l2_fourcc('P', 'C', '2', 'g')\n+#define V4L2_PIX_FMT_PISP_COMP2_BGGR\tv4l2_fourcc('P', 'C', '2', 'B')\n+#define V4L2_PIX_FMT_PISP_COMP2_MONO\tv4l2_fourcc('P', 'C', '2', 'M')\n+\n /* SDR formats - used only for Software Defined Radio devices */\n #define V4L2_SDR_FMT_CU8 v4l2_fourcc('C', 'U', '0', '8') /* IQ u8 */\n #define V4L2_SDR_FMT_CU16LE v4l2_fourcc('C', 'U', '1', '6') /* IQ u16le */\n@@ -818,6 +830,9 @@ struct v4l2_pix_format {\n #define V4L2_META_FMT_RK_ISP1_PARAMS\tv4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 3A Parameters */\n #define V4L2_META_FMT_RK_ISP1_STAT_3A\tv4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A Statistics */\n \n+/* Vendor specific - used for RaspberryPi PiSP */\n+#define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C') /* PiSP BE configuration */\n+\n /* priv field value to indicates that subsequent fields are valid. */\n #define V4L2_PIX_FMT_PRIV_MAGIC\t\t0xfeedcafe\n \ndiff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\nindex 20aedfa6d925..333b1117f531 100644\n--- a/src/libcamera/bayer_format.cpp\n+++ b/src/libcamera/bayer_format.cpp\n@@ -164,6 +164,14 @@ const std::map<BayerFormat, Formats, BayerFormatComparator> bayerToFormat{\n \t\t{ formats::SGRBG16, V4L2PixelFormat(V4L2_PIX_FMT_SGRBG16) } },\n \t{ { BayerFormat::RGGB, 16, BayerFormat::Packing::None },\n \t\t{ formats::SRGGB16, V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16) } },\n+\t{ { BayerFormat::BGGR, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::BGGR16_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_BGGR) } },\n+\t{ { BayerFormat::GBRG, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::GBRG16_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GBRG) } },\n+\t{ { BayerFormat::GRBG, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::GRBG16_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GRBG) } },\n+\t{ { BayerFormat::RGGB, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::RGGB16_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_RGGB) } },\n \t{ { BayerFormat::MONO, 8, BayerFormat::Packing::None },\n \t\t{ formats::R8, V4L2PixelFormat(V4L2_PIX_FMT_GREY) } },\n \t{ { BayerFormat::MONO, 10, BayerFormat::Packing::None },\n@@ -174,6 +182,8 @@ const std::map<BayerFormat, Formats, BayerFormatComparator> bayerToFormat{\n \t\t{ formats::R12, V4L2PixelFormat(V4L2_PIX_FMT_Y12) } },\n \t{ { BayerFormat::MONO, 16, BayerFormat::Packing::None },\n \t\t{ formats::R16, V4L2PixelFormat(V4L2_PIX_FMT_Y16) } },\n+\t{ { BayerFormat::MONO, 16, BayerFormat::Packing::PISP1 },\n+\t\t{ formats::MONO_PISP_COMP1, V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_MONO) } },\n };\n \n const std::unordered_map<unsigned int, BayerFormat> mbusCodeToBayer{\n@@ -209,6 +219,10 @@ const std::unordered_map<unsigned int, BayerFormat> mbusCodeToBayer{\n \t{ MEDIA_BUS_FMT_SGBRG16_1X16, { BayerFormat::GBRG, 16, BayerFormat::Packing::None } },\n \t{ MEDIA_BUS_FMT_SGRBG16_1X16, { BayerFormat::GRBG, 16, BayerFormat::Packing::None } },\n \t{ MEDIA_BUS_FMT_SRGGB16_1X16, { BayerFormat::RGGB, 16, BayerFormat::Packing::None } },\n+\t{ MEDIA_BUS_FMT_SBGGR16_1X16, { BayerFormat::BGGR, 16, BayerFormat::Packing::PISP1 } },\n+\t{ MEDIA_BUS_FMT_SGBRG16_1X16, { BayerFormat::GBRG, 16, BayerFormat::Packing::PISP1 } },\n+\t{ MEDIA_BUS_FMT_SGRBG16_1X16, { BayerFormat::GRBG, 16, BayerFormat::Packing::PISP1 } },\n+\t{ MEDIA_BUS_FMT_SRGGB16_1X16, { BayerFormat::RGGB, 16, BayerFormat::Packing::PISP1 } },\n \t{ MEDIA_BUS_FMT_Y8_1X8, { BayerFormat::MONO, 8, BayerFormat::Packing::None } },\n \t{ MEDIA_BUS_FMT_Y10_1X10, { BayerFormat::MONO, 10, BayerFormat::Packing::None } },\n \t{ MEDIA_BUS_FMT_Y12_1X12, { BayerFormat::MONO, 12, BayerFormat::Packing::None } },\n@@ -303,6 +317,10 @@ std::ostream &operator<<(std::ostream &out, const BayerFormat &f)\n \t\tout << \"-CSI2P\";\n \telse if (f.packing == BayerFormat::Packing::IPU3)\n \t\tout << \"-IPU3P\";\n+\telse if (f.packing == BayerFormat::Packing::PISP1)\n+\t\tout << \"-PISP1\";\n+\telse if (f.packing == BayerFormat::Packing::PISP2)\n+\t\tout << \"-PISP2\";\n \n \treturn out;\n }\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex a674f4179cc8..e603a7eda579 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -547,6 +547,16 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::MONO_PISP_COMP1, {\n+\t\t.name = \"MONO_PISP_COMP1\",\n+\t\t.format = formats::MONO_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_MONO), },\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \n \t/* Bayer formats. */\n \t{ formats::SBGGR8, {\n@@ -910,7 +920,46 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 25,\n \t\t.planes = {{ { 32, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n-\n+\t{ formats::BGGR16_PISP_COMP1, {\n+\t\t.name = \"BGGR16_PISP_COMP1\",\n+\t\t.format = formats::BGGR16_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_BGGR), },\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::GBRG16_PISP_COMP1, {\n+\t\t.name = \"GBRG16_PISP_COMP1\",\n+\t\t.format = formats::GBRG16_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GBRG), },\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::GRBG16_PISP_COMP1, {\n+\t\t.name = \"GRBG16_PISP_COMP1\",\n+\t\t.format = formats::GRBG16_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GRBG), },\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::RGGB16_PISP_COMP1, {\n+\t\t.name = \"RGGB16_PISP_COMP1\",\n+\t\t.format = formats::RGGB16_PISP_COMP1,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_RGGB), },\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t/* Compressed formats. */\n \t{ formats::MJPEG, {\n \t\t.name = \"MJPEG\",\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex bde2cc803b98..f6df721243d0 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -190,4 +190,20 @@ formats:\n - SBGGR10_IPU3:\n fourcc: DRM_FORMAT_SBGGR10\n mod: IPU3_FORMAT_MOD_PACKED\n+\n+ - RGGB16_PISP_COMP1:\n+ fourcc: DRM_FORMAT_SRGGB16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n+ - GRBG16_PISP_COMP1:\n+ fourcc: DRM_FORMAT_SGRBG16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n+ - GBRG16_PISP_COMP1:\n+ fourcc: DRM_FORMAT_SGBRG16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n+ - BGGR16_PISP_COMP1:\n+ fourcc: DRM_FORMAT_SBGGR16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n+ - MONO_PISP_COMP1:\n+ fourcc: DRM_FORMAT_R16\n+ mod: PISP_FORMAT_MOD_COMPRESS_MODE1\n ...\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex efb6f2940235..47baaf60199d 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -207,6 +207,16 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{\n \t\t{ formats::SGRBG16, \"16-bit Bayer GRGR/BGBG\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16),\n \t\t{ formats::SRGGB16, \"16-bit Bayer RGRG/GBGB\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_BGGR),\n+\t\t{ formats::BGGR16_PISP_COMP1, \"16-bit Bayer BGBG/GRGR PiSP Compress Mode 1\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GBRG),\n+\t\t{ formats::GBRG16_PISP_COMP1, \"16-bit Bayer GBGB/RGRG PiSP Compress Mode 1\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_GRBG),\n+\t\t{ formats::GRBG16_PISP_COMP1, \"16-bit Bayer GRGR/BGBG PiSP Compress Mode 1\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_RGGB),\n+\t\t{ formats::RGGB16_PISP_COMP1, \"16-bit Bayer RGRG/GBGB PiSP Compress Mode 1\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_PISP_COMP1_MONO),\n+\t\t{ formats::MONO_PISP_COMP1, \"16-bit Mono PiSP Compress Mode 1\" } },\n \n \t/* Compressed formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_MJPEG),\ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 6d0785b7b484..aea90abaf9ef 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -134,6 +134,10 @@ const std::map<uint32_t, V4L2SubdeviceFormatInfo> formatInfoMap = {\n \t{ MEDIA_BUS_FMT_SGBRG12_1X12, { 12, \"SGBRG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n \t{ MEDIA_BUS_FMT_SGRBG12_1X12, { 12, \"SGRBG12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n \t{ MEDIA_BUS_FMT_SRGGB12_1X12, { 12, \"SRGGB12_1X12\", PixelFormatInfo::ColourEncodingRAW } },\n+\t{ MEDIA_BUS_FMT_SBGGR16_1X16, { 16, \"SBGGR16_1x16\", PixelFormatInfo::ColourEncodingRAW } },\n+\t{ MEDIA_BUS_FMT_SGBRG16_1X16, { 16, \"SGBRG16_1x16\", PixelFormatInfo::ColourEncodingRAW } },\n+\t{ MEDIA_BUS_FMT_SGRBG16_1X16, { 16, \"SGRBG16_1x16\", PixelFormatInfo::ColourEncodingRAW } },\n+\t{ MEDIA_BUS_FMT_SRGGB16_1X16, { 16, \"SRGGB16_1x16\", PixelFormatInfo::ColourEncodingRAW } },\n \t/* \\todo Clarify colour encoding for HSV formats */\n \t{ MEDIA_BUS_FMT_AHSV8888_1X32, { 32, \"AHSV8888_1X32\", PixelFormatInfo::ColourEncodingRGB } },\n \t{ MEDIA_BUS_FMT_JPEG_1X8, { 8, \"JPEG_1X8\", PixelFormatInfo::ColourEncodingYUV } },\n", "prefixes": [ "v1", "2/2" ] }