Patch Detail
Show a patch.
GET /api/1.1/patches/19502/?format=api
{ "id": 19502, "url": "https://patchwork.libcamera.org/api/1.1/patches/19502/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19502/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240215132710.810-2-naush@raspberrypi.com>", "date": "2024-02-15T13:27:09", "name": "[v1,1/2] libcamera: formats: Add RGB48 formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1caa44193460af413868033e8937301345a5046d", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19502/mbox/", "series": [ { "id": 4169, "url": "https://patchwork.libcamera.org/api/1.1/series/4169/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4169", "date": "2024-02-15T13:27:08", "name": "Raspberry Pi: PiSP image formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4169/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19502/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19502/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49DB1BDE17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Feb 2024 13:27:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DB2C6280B;\n\tThu, 15 Feb 2024 14:27:21 +0100 (CET)", "from mail-lf1-x131.google.com (mail-lf1-x131.google.com\n\t[IPv6:2a00:1450:4864:20::131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE27561CB0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Feb 2024 14:27:19 +0100 (CET)", "by mail-lf1-x131.google.com with SMTP id\n\t2adb3069b0e04-511ac32ff36so956587e87.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Feb 2024 05:27:19 -0800 (PST)", "from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tew14-20020a056402538e00b005607825b11bsm532283edb.12.2024.02.15.05.27.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Feb 2024 05:27:18 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Ap7554da\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1708003639; x=1708608439;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=crpVpPOk2g+hz0+8zRQdstVqUMjcIwP6axfs16ih/z0=;\n\tb=Ap7554daavDh0RBLpxEgxuG2K+LB94vUeBduJIqO899D8uQFHQvUsKgX7gvGuu+CET\n\tWlqgoosjuX8nq0AZAtwSnxW+dYgD7Q4//T+Jo2PKj9j4wKqWdLBiDn7VEdPeyimiNZwe\n\twvj2ZAQ5VWpUZpBnSitgkQ+pmUBSIRqMX4tTk9LMyYP14B/g7tdI230+IKU2iq3Q1pF7\n\t9p42wuIOZLE4/qRS0ML7VPGS2PQ15H9ooQ+gC6xoEw7u8KiVA0EVekIuG6vCwy75o/yp\n\tlWBVCVycgUXDbZ+aYFlJBbYdKODFxBnENDgyyNAd6koXp7q7HQCIKreFjq4kGH/5Bf9M\n\t00CQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1708003639; x=1708608439;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=crpVpPOk2g+hz0+8zRQdstVqUMjcIwP6axfs16ih/z0=;\n\tb=SRNM5QbZ48TAT1qad9j5Jk9zkRNB4y81OHubZJUyi5Ki69p5PIPlsdqzGP9MdhjlYm\n\tuv2qQyUdgkpscRwxhyZecE1CC3H5ys/WAn/JCrpGIQQyw0g5ClF4ssLnlG84IWEjqh7k\n\t2Kv5A5b8SYwiJ/RENDOjl1lT9ZbWOCjuNVE+nzdIM7ye8lruY8kCNRpMH1cHOLI72m/p\n\t3Ikf/akFgE/QwTfNCmY0Twoh0MkPrp/VeV4VawRsuVNcMdQPp+TGs9NrMi90s/t32Tnn\n\tklIPX2QawdeMGbX+6hnrsp9tHqyJVZ8TRvs3ODQlQbTq7FUui7ae5UZno47E3QerR4Dq\n\tqiKA==", "X-Gm-Message-State": "AOJu0YxY5cs/6SStreyEzwJyOaG0clg0AnaFFwUdOqphcM1UsvIjc5ez\n\tCJ0Oj2RMaKAs9+2iwSPy5XPjWNPyTCHI1xnhjAmdZEmspuTjIV95FY7UjcTmmLgCbpZocAKj28J\n\tk", "X-Google-Smtp-Source": "AGHT+IHWcBxPHWmWjMLi3C5mm8AMCm2PqLUqcshTjsj8hpXRPcn/6OBc9+MoHLrWMehX0jTTraGIcw==", "X-Received": "by 2002:a05:6512:124c:b0:511:85ae:8985 with SMTP id\n\tfb12-20020a056512124c00b0051185ae8985mr1614890lfb.53.1708003638583; \n\tThu, 15 Feb 2024 05:27:18 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 1/2] libcamera: formats: Add RGB48 formats", "Date": "Thu, 15 Feb 2024 13:27:09 +0000", "Message-Id": "<20240215132710.810-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240215132710.810-1-naush@raspberrypi.com>", "References": "<20240215132710.810-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for 16-bps (48-bpp) RGB output formats. These new formats\nare define for the RGB and BGR ordering.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n include/linux/drm_fourcc.h | 4 ++++\n include/linux/videodev2.h | 4 ++++\n src/libcamera/formats.cpp | 20 ++++++++++++++++++++\n src/libcamera/formats.yaml | 5 +++++\n src/libcamera/v4l2_pixelformat.cpp | 4 ++++\n 5 files changed, 37 insertions(+)", "diff": "diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\nindex d6c83d9c49f4..4ee421b95730 100644\n--- a/include/linux/drm_fourcc.h\n+++ b/include/linux/drm_fourcc.h\n@@ -210,6 +210,10 @@ extern \"C\" {\n #define DRM_FORMAT_RGBA1010102\tfourcc_code('R', 'A', '3', '0') /* [31:0] R:G:B:A 10:10:10:2 little endian */\n #define DRM_FORMAT_BGRA1010102\tfourcc_code('B', 'A', '3', '0') /* [31:0] B:G:R:A 10:10:10:2 little endian */\n \n+/* 48 bpp RGB */\n+#define DRM_FORMAT_RGB161616\tfourcc_code('R', 'G', '4', '8') /* [48:0] R:G:B 16:16:16 little endian */\n+#define DRM_FORMAT_BGR161616\tfourcc_code('B', 'G', '4', '8') /* [48:0] R:G:B 16:16:16 little endian */\n+\n /* 64 bpp RGB */\n #define DRM_FORMAT_XRGB16161616\tfourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */\n #define DRM_FORMAT_XBGR16161616\tfourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */\ndiff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\nindex 7e556911c9e1..ba48d2c89726 100644\n--- a/include/linux/videodev2.h\n+++ b/include/linux/videodev2.h\n@@ -557,6 +557,10 @@ struct v4l2_pix_format {\n #define V4L2_PIX_FMT_BGR48_12 v4l2_fourcc('B', '3', '1', '2') /* 48 BGR 12-bit per component */\n #define V4L2_PIX_FMT_ABGR64_12 v4l2_fourcc('B', '4', '1', '2') /* 64 BGRA 12-bit per component */\n \n+/* RGB formats (6 bytes per pixel) */\n+#define V4L2_PIX_FMT_BGR48 v4l2_fourcc('B', 'G', 'R', '6') /* 16 BGR-16-16-16 */\n+#define V4L2_PIX_FMT_RGB48 v4l2_fourcc('R', 'G', 'B', '6') /* 16 RGB-16-16-16 */\n+\n /* Grey formats */\n #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8 Greyscale */\n #define V4L2_PIX_FMT_Y4 v4l2_fourcc('Y', '0', '4', ' ') /* 4 Greyscale */\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 8a606a7c37f1..a674f4179cc8 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -270,6 +270,26 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::BGR161616, {\n+\t\t.name = \"BGR161616\",\n+\t\t.format = formats::BGR161616,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_RGB48), },\n+\t\t.bitsPerPixel = 48,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::RGB161616, {\n+\t\t.name = \"RGB161616\",\n+\t\t.format = formats::RGB161616,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_BGR48), },\n+\t\t.bitsPerPixel = 24,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \n \t/* YUV packed formats. */\n \t{ formats::YUYV, {\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex d8a379923b56..bde2cc803b98 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -43,6 +43,11 @@ formats:\n - BGRA8888:\n fourcc: DRM_FORMAT_BGRA8888\n \n+ - RGB161616:\n+ fourcc: DRM_FORMAT_RGB161616\n+ - BGR161616:\n+ fourcc: DRM_FORMAT_BGR161616\n+\n - YUYV:\n fourcc: DRM_FORMAT_YUYV\n - YVYU:\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 731dc10f1d73..efb6f2940235 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -71,6 +71,10 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{\n \t\t{ formats::BGRA8888, \"32-bit ARGB 8-8-8-8\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGRA32),\n \t\t{ formats::RGBA8888, \"32-bit ABGR 8-8-8-8\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB48),\n+\t\t{ formats::BGR161616, \"48-bit RGB 16-16-16\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR48),\n+\t\t{ formats::RGB161616, \"48-bit BGR 16-16-16\" } },\n \n \t/* YUV packed formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUYV),\n", "prefixes": [ "v1", "1/2" ] }