Patch Detail
Show a patch.
GET /api/1.1/patches/19500/?format=api
{ "id": 19500, "url": "https://patchwork.libcamera.org/api/1.1/patches/19500/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19500/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240215082342.6437-1-naush@raspberrypi.com>", "date": "2024-02-15T08:23:42", "name": "[v1] utils: mojom: Fix build error caused by the mojom tool update", "commit_ref": "5e4dc46a0c6fc3138c887e9afbabfe7dfa6ebd98", "pull_url": null, "state": "accepted", "archived": false, "hash": "3edba91af1cad9656e0012ee422f7d570644728d", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19500/mbox/", "series": [ { "id": 4168, "url": "https://patchwork.libcamera.org/api/1.1/series/4168/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4168", "date": "2024-02-15T08:23:42", "name": "[v1] utils: mojom: Fix build error caused by the mojom tool update", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4168/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19500/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19500/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BD09BDE17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Feb 2024 08:50:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5702E62805;\n\tThu, 15 Feb 2024 09:50:25 +0100 (CET)", "from mail-ed1-x535.google.com (mail-ed1-x535.google.com\n\t[IPv6:2a00:1450:4864:20::535])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3551B61CAC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Feb 2024 09:50:23 +0100 (CET)", "by mail-ed1-x535.google.com with SMTP id\n\t4fb4d7f45d1cf-563b49a0f44so441148a12.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Feb 2024 00:50:23 -0800 (PST)", "from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tw24-20020a170906131800b00a3d22f53210sm322851ejb.188.2024.02.15.00.50.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Feb 2024 00:50:21 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"FKZTduAV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1707987022; x=1708591822;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=k66RVLFcJ68NNczCWSJKtTsoHqWlJbQNmNwHaUxKGXk=;\n\tb=FKZTduAVI0SAZHGobFwzJ1VHpPpsmr25bzKMLIQQYIASt+q5TG37sWEIU+noPG7oPi\n\te2GYirRq2eWzVZ/Q3xCU3IJl+gqAY+SpQRce3te0EkxBpAaspbB0DGSBSoNQGO3FNWTF\n\t+d2Itfenab4X6RkIlM9cKAkrSGAx3vzUI6n9+6Ij340EuGNTg3AXBXqeHVKC2fO0PvwK\n\twJxl98n89f/4eFTN1LOwtlxVylmZ76RIagL0vJ9u69hdz25QKoC8TT0hCt7Qh7OuxUGK\n\tD+EpDIEyw9CSN2Bm0HY8Yu5TNCJQYdBjL9hJQNfpKe9tmWHWIsyC92M773Vte0jiV/dg\n\t6vSA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1707987022; x=1708591822;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=k66RVLFcJ68NNczCWSJKtTsoHqWlJbQNmNwHaUxKGXk=;\n\tb=XViJ96EKcTkaFKp/t/ua+ItmdrIDimF3H2xG+kRoGAeamK9+qAnZldfhn2q2DBk5M4\n\ts1lr7GE0W7tG8GR8smBZAU/R0O8LE2LocW1fyethKvmiMX1sgSEgIDvoOcHE5USGKZZQ\n\tooQubNYXrVBW2yepMO2GMXw/0KKHQzyhqI+bZyhARoQahhtr0sF0/AiMteAOBHMCxQ4M\n\txTLKwoqRSwk2GEBcBmY/Jb/p2gpEghAD/MhYwTEZlNrfMEMdRA3qZisdbTe87wGFIk7t\n\tnojdBioYOG/WwnQRnyJTboCLrwiD6DG6bUFDhh3Hgr6ZLrgxdcECfBv+lWxdxkR/ftms\n\tQ4AQ==", "X-Gm-Message-State": "AOJu0YwbcUg07s/ER1L+XciMkg8GzI75VdptJdOjclHEWDR2cEg5BFn2\n\tvRl0kkt3XjTLIutj/2z0ROf4D3XaeHP9nlygwkMUyjDQL7pfDwbU4MpQUn6mYpf2Usxr1iLwhEO\n\t9", "X-Google-Smtp-Source": "AGHT+IHZ2QpUPjlOIDvappYRrZds1aEuPdYnGcbr8MtWZblSTRnbe3ijwuTGXbP2+5w4sLAnq8XDzw==", "X-Received": "by 2002:a17:906:e24e:b0:a3d:a74b:e3d5 with SMTP id\n\tgq14-20020a170906e24e00b00a3da74be3d5mr237745ejb.31.1707987022086; \n\tThu, 15 Feb 2024 00:50:22 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] utils: mojom: Fix build error caused by the mojom tool\n\tupdate", "Date": "Thu, 15 Feb 2024 08:23:42 +0000", "Message-Id": "<20240215082342.6437-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The update to the mojom tool in commit d17de86904f0 causes build errors\nwith gcc 12.2 release builds. One such error is:\n\nIn file included from src/libcamera/proxy/worker/raspberrypi_ipa_proxy_worker.cpp:18:\nIn static member function ‘static libcamera::ipa::RPi::ProcessParams libcamera::IPADataSerializer<libcamera::ipa::RPi::ProcessParams>::deserialize(std::vector<unsigned char>::const_iterator, std::vector<unsigned char>::const_iterator, libcamera::ControlSerializer*)’,\n inlined from ‘void IPAProxyRPiWorker::readyRead()’ at src/libcamera/proxy/worker/raspberrypi_ipa_proxy_worker.cpp:302:70:\ninclude/libcamera/ipa/raspberrypi_ipa_serializer.h:1172:32: error: ‘*(uint32_t*)((char*)&ret + offsetof(libcamera::ipa::RPi::ProcessParams, libcamera::ipa::RPi::ProcessParams::buffers.libcamera::ipa::RPi::BufferIds::bayer))’ may be used uninitialized [-Werror=maybe-uninitialized]\n 1172 | return ret;\n\nThe failure is caused by the new auto-generated IPA interface not\ninitialising POD types to a default value. This is because the updated\nmojom library uses a new mojom.ValueKind class to represent POD types,\nwhereas the interface generator script uses the mojom.Kind class, which\nis correct for the older mojom library.\n\nFix this breakage by switching the interface generator script to use\nmojom.ValueKind to test for POD types.\n\nFixes: d17de86904f0 (\"utils: ipc: Update mojo\")\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n utils/ipc/generators/mojom_libcamera_generator.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/ipc/generators/mojom_libcamera_generator.py b/utils/ipc/generators/mojom_libcamera_generator.py\nindex 582818c98b5f..99d905de456c 100644\n--- a/utils/ipc/generators/mojom_libcamera_generator.py\n+++ b/utils/ipc/generators/mojom_libcamera_generator.py\n@@ -72,7 +72,7 @@ def ParamsCommaSep(l):\n def GetDefaultValue(element):\n if element.default is not None:\n return element.default\n- if type(element.kind) == mojom.Kind:\n+ if type(element.kind) == mojom.ValueKind:\n return '0'\n if IsFlags(element):\n return ''\n", "prefixes": [ "v1" ] }