Patch Detail
Show a patch.
GET /api/1.1/patches/1946/?format=api
{ "id": 1946, "url": "https://patchwork.libcamera.org/api/1.1/patches/1946/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1946/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190905210940.32358-5-jacopo@jmondi.org>", "date": "2019-09-05T21:09:35", "name": "[libcamera-devel,v7,4/9] android: camera_device: Add missing tags in request template", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "65286e87189441e4d317f5dc898762c8d95dff11", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1946/mbox/", "series": [ { "id": 482, "url": "https://patchwork.libcamera.org/api/1.1/series/482/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=482", "date": "2019-09-05T21:09:31", "name": "android: Rework metadata tags", "version": 7, "mbox": "https://patchwork.libcamera.org/series/482/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1946/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1946/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B7DE61567\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Sep 2019 23:08:16 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id BCC58C0007;\n\tThu, 5 Sep 2019 21:08:15 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 5 Sep 2019 23:09:35 +0200", "Message-Id": "<20190905210940.32358-5-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20190905210940.32358-1-jacopo@jmondi.org>", "References": "<20190905210940.32358-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 4/9] android: camera_device: Add\n\tmissing tags in request template", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 05 Sep 2019 21:08:16 -0000" }, "content": "Add two missing tags from the request template generated by the HAL.\nThe tags are reported as missing by the cros_camera_test tool.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_device.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex bd69198ec482..969c8192c316 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -611,6 +611,17 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \t\t\t&faceDetectMode, 1);\n \tMETADATA_ASSERT(ret);\n \n+\tuint8_t noiseReduction = ANDROID_NOISE_REDUCTION_MODE_OFF;\n+\tret = add_camera_metadata_entry(requestTemplate_,\n+\t\t\tANDROID_NOISE_REDUCTION_MODE, &noiseReduction, 1);\n+\tMETADATA_ASSERT(ret);\n+\n+\tuint8_t aberrationMode = ANDROID_COLOR_CORRECTION_ABERRATION_MODE_OFF;\n+\tret = add_camera_metadata_entry(requestTemplate_,\n+\t\t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n+\t\t\t&aberrationMode, 1);\n+\tMETADATA_ASSERT(ret);\n+\n \tret = add_camera_metadata_entry(requestTemplate_,\n \t\t\tANDROID_CONTROL_CAPTURE_INTENT,\n \t\t\t&captureIntent, 1);\n", "prefixes": [ "libcamera-devel", "v7", "4/9" ] }