Patch Detail
Show a patch.
GET /api/1.1/patches/19368/?format=api
{ "id": 19368, "url": "https://patchwork.libcamera.org/api/1.1/patches/19368/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19368/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240104151548.2589-8-laurent.pinchart@ideasonboard.com>", "date": "2024-01-04T15:15:47", "name": "[libcamera-devel,7/8] utils: ipc: generate.py: Disable attributes checker", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fa15318cd0da8d4174c6c851a739244fa8ba1c5d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19368/mbox/", "series": [ { "id": 4132, "url": "https://patchwork.libcamera.org/api/1.1/series/4132/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4132", "date": "2024-01-04T15:15:40", "name": "libcamera: Update mojo and mojo updater", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4132/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19368/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19368/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9B3CC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Jan 2024 15:15:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85C1C62B67;\n\tThu, 4 Jan 2024 16:15:52 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85C4662B5B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jan 2024 16:15:49 +0100 (CET)", "from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C89322D8;\n\tThu, 4 Jan 2024 16:14:48 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704381352;\n\tbh=ZVjXpCa8iYp7upMBxrkhyGOLX0Ij7qQyzvW814Y/hdk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1sq78B1gtgvSiB4q2+XU/4jtaStiS7CM2MOnElXKRUVaKY2mkDH0ISw1BDEVN/Nim\n\ts0wiPDKFv2NQrPpvgRczEFLxM/tFkZGEtpoSOPSJKV1zID+OW3ppCt+b3QCXHMuSvK\n\tm0pcFweVhrFkCEAVO5EVG4R2CB9T6VWvLktrAgTlsPWo/pRy0zaSCd150BkFjhFDgk\n\tnI8Sru3CGFFpphwl7/WXwF3ZPz3qchrGRs3lyUQI/ml1RHJp4/k9UDpwYqhaorNbmC\n\tiN9RgEYXVxWPKZIcED26vhrTpqi1hmeVFnwBATY9OCyBJsKsAVD+12t1AfJSZoJRVM\n\tXGIbDAow7d+qg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704381289;\n\tbh=ZVjXpCa8iYp7upMBxrkhyGOLX0Ij7qQyzvW814Y/hdk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BLJcD95zGnlPtkjmaqVH63fzI2TJlOtuRN/Bxowp4k++XfBBiwbCZE7gcy3iMkP2I\n\tvY3P2xWhsRKC3iVDrWpKT7w0OtMM+UkQW1LYkOeA0xg3gf1kYjm3ydoC6e9sa+WcgT\n\tkYPZHicZJeInfR0PolXUNZfRYPiJ8ptZ0uIHgLD4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BLJcD95z\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 4 Jan 2024 17:15:47 +0200", "Message-ID": "<20240104151548.2589-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.41.0", "In-Reply-To": "<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>", "References": "<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 7/8] utils: ipc: generate.py: Disable\n\tattributes checker", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Khem Raj <raj.khem@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The attributes checker ensures that .mojom files don't contain unknown\nattributes. These check fail with the custom 'skipSerdes' and 'async'\nlibcamera attributes. Ideally the list of supported attributes should be\nextended, but that can't easily be done without modifying the mojo\nsources that we try to keep identical to the upstream version to make\nupdates easier. Disable the attributes checker completely for now to fix\nthis issue.\n\nWhile at it, fix an indentation issue reported by checkstyle.py.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/ipc/generate.py | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/utils/ipc/generate.py b/utils/ipc/generate.py\nindex afaf018b49d1..71bdee3b7545 100755\n--- a/utils/ipc/generate.py\n+++ b/utils/ipc/generate.py\n@@ -17,7 +17,15 @@ sys.path.insert(0, f'{os.path.dirname(__file__)}/mojo/public/tools/bindings')\n import mojo.public.tools.bindings.mojom_bindings_generator as generator\n \n def _GetModulePath(path, output_dir):\n- return os.path.join(output_dir, path.relative_path())\n+ return os.path.join(output_dir, path.relative_path())\n+\n+\n+# Disable the attribute checker to support our custom attributes. Ideally we\n+# should add the attributes to the list of allowed attributes in\n+# utils/ipc/mojo/public/tools/bindings/checks/mojom_attributes_check.py, but\n+# we're trying hard to use the upstream mojom as-is.\n+if hasattr(generator, '_BUILTIN_CHECKS'):\n+ del generator._BUILTIN_CHECKS['attributes']\n \n # Override the mojo code generator's generator list to only contain our\n # libcamera generator\n", "prefixes": [ "libcamera-devel", "7/8" ] }