Patch Detail
Show a patch.
GET /api/1.1/patches/19330/?format=api
{ "id": 19330, "url": "https://patchwork.libcamera.org/api/1.1/patches/19330/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19330/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231218141313.29898-1-laurent.pinchart@ideasonboard.com>", "date": "2023-12-18T14:13:13", "name": "[libcamera-devel] libcamera: camera: Fix unused variable compiler warning", "commit_ref": "4843f72b131388b3da1d4cbb8dc48800b8b0559e", "pull_url": null, "state": "accepted", "archived": false, "hash": "542f349bacca53c29da8aa1191259c6f621bafc8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19330/mbox/", "series": [ { "id": 4121, "url": "https://patchwork.libcamera.org/api/1.1/series/4121/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4121", "date": "2023-12-18T14:13:13", "name": "[libcamera-devel] libcamera: camera: Fix unused variable compiler warning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4121/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19330/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19330/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0B09C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 18 Dec 2023 14:13:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 07F2A62B32;\n\tMon, 18 Dec 2023 15:13:09 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9924E61D93\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Dec 2023 15:13:06 +0100 (CET)", "from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58E1157E;\n\tMon, 18 Dec 2023 15:12:17 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702908789;\n\tbh=D7nNueHVX+YCX+0yqOkSt3pzs9Bazc8fsWoAehPPl7E=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=2CPkcXRDbWl7TIz4Yq7/myNvPGTzcj9NYU/5BARqj7DO6PX9XU1gHa7RpPba+uXuv\n\tAamMaF2R2qXk35pjlkSfFgFqlu3/TUJRaIouTt+VkwfCs5+QZiGTPeez+mRUDv6gd5\n\tzYiokpO4t6YW1vUl0u+BQntE5HcOYTlbPF3QTDCPC46q8EQq5lRlY9X3fMi30XKPAJ\n\tqflLFvErtE7G88c5zUicm4XFKw8DHLpoLnqAuZZthpOoOjlY94KUmcmb2HbtWQyGfQ\n\tArcdDOpjHz3hrZLIvJh200sKTDQeiL4LWjaTrUXXSF+w8B2nmnf4F3dOOWC+zwDPlt\n\twp0Mryet0ZeXw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1702908737;\n\tbh=D7nNueHVX+YCX+0yqOkSt3pzs9Bazc8fsWoAehPPl7E=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=PqSAgvmeKb/RxobfPxvZnj3Lu2JA1fyNedBK9CWqKLNzf09IkK35dBQ0AJOyVhkR7\n\tx52JcTx8YfQ4EUh51V1LAAML0MBxxUQ01TwPqs7HRJLfWLADhPkqvFog/QFWZJPqzT\n\t8HqDRpok/wqDUEB/ab+6rr8bRRUhopik+eTHK1fA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PqSAgvme\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 18 Dec 2023 16:13:13 +0200", "Message-ID": "<20231218141313.29898-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.41.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: camera: Fix unused variable\n\tcompiler warning", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "inimcoder@gmail.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When compiling with gcc 8.4.0, the compiler throws an unused variable\nwarning:\n\n../src/libcamera/camera.cpp: In member function ‘libcamera::CameraConfiguration::Status libcamera::CameraConfiguration::validateColorSpaces(libcamera::CameraConfiguration::ColorSpaceFlags)’:\n../src/libcamera/camera.cpp:497:19: error: unused variable ‘i’ [-Werror=unused-variable]\n for (auto [i, cfg] : utils::enumerate(config_)) {\n ^\n\nWhile the code compiles fine with 8.3.0 and 8.5.0, gcc is right here,\nthe 'i' variable is unused. It turns out that the code can be\nsimplified, as the commit that removed usage of the variable kept the\nnow unneeded utils::enumerate() call.\n\nSimplify the code and fix the warning in one go.\n\nFixes: 13986d6ce3ab (\"libcamera: camera: Fix validateColorSpaces to choose \"main\" colour space\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 41d6e6e5c166c267e7a15a7b0c1d930bddcbc6b8", "diff": "diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 0ad1a4b50447..a71dc933b911 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -494,7 +494,7 @@ CameraConfiguration::Status CameraConfiguration::validateColorSpaces(ColorSpaceF\n \tstd::optional<ColorSpace> colorSpace;\n \tSize size;\n \n-\tfor (auto [i, cfg] : utils::enumerate(config_)) {\n+\tfor (StreamConfiguration &cfg : config_) {\n \t\tif (!cfg.colorSpace)\n \t\t\tcontinue;\n \n", "prefixes": [ "libcamera-devel" ] }