Patch Detail
Show a patch.
GET /api/1.1/patches/19313/?format=api
{ "id": 19313, "url": "https://patchwork.libcamera.org/api/1.1/patches/19313/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19313/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<ZXiaHtJPfB/znr6p@duo.ucw.cz>", "date": "2023-12-12T17:36:30", "name": "[libcamera-devel] cam: Support RGB888 texture in sdl sink", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "88079072c60d1f077a195beecaa3de02b607af67", "submitter": { "id": 49, "url": "https://patchwork.libcamera.org/api/1.1/people/49/?format=api", "name": "Pavel Machek", "email": "pavel@ucw.cz" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19313/mbox/", "series": [ { "id": 4115, "url": "https://patchwork.libcamera.org/api/1.1/series/4115/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4115", "date": "2023-12-12T17:36:30", "name": "[libcamera-devel] cam: Support RGB888 texture in sdl sink", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4115/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19313/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19313/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57EA8C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 12 Dec 2023 17:36:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17D3662B32;\n\tTue, 12 Dec 2023 18:36:33 +0100 (CET)", "from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F05E629BD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Dec 2023 18:36:31 +0100 (CET)", "by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 476871C006F; Tue, 12 Dec 2023 18:36:31 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702402593;\n\tbh=asjbcICJpQmziGzEPJcpTG5VbXkzK/GaaGtVXUNU+JI=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=iUReS/3K1luV7v6ojaXsGrW0GRWH+OOdIbNxJM+bwLP+MQULkOfYRg+RhS0Dydd+b\n\tlUJhi7a2MKzlI0L4SxyTj99OxDwsa/U5xrXCVONXWT1MAMPHte+/UJU0TH9HnYtizn\n\tq+aittSRRrMnGFFYNVpZ0nU3UnkFqOzX+Q/Y/T54n9KfOCC6k/cdl4sf44IxrBqDeE\n\tqcwr7MtU67FJhlM/313tG9SAGlXMflq5FjS2rUu+C3z9IzpyISTYBOyqvxJEsbx3X7\n\twfhLkReLRcOR6Eav4OVTkZibuYbc7v2yWZmpWjuG+Z3f+W32GwerZYNBF67/ZxY0W7\n\tJLH/SKOhBuWcw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1702402591;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type;\n\tbh=MWPoHTCR6MsqC6PNiRzS0XfCXTSOYTY+Bfgbje+TrCU=;\n\tb=cH1kz3kfvnv1S+3psua1oglk7o5Eg0U2qFcZeplI5S+GwxgIaUonoqUJyQOCZppeXTtflx\n\thZt13qD+fJE+OCSvDCU1QJCMgxxBP487TdL/+fsweMCOJpCUXoDXPW+fgvPezgFEttPxjm\n\tvamO7Q8iltDUQmPPSHrrIwI2uIoJurs=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"cH1kz3kf\"; dkim-atps=neutral", "Date": "Tue, 12 Dec 2023 18:36:30 +0100", "To": "kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org", "Message-ID": "<ZXiaHtJPfB/znr6p@duo.ucw.cz>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"KR1OjZRfbN3nXtRc\"", "Content-Disposition": "inline", "Subject": "[libcamera-devel] cam: Support RGB888 texture in sdl sink", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Pavel Machek <pavel@ucw.cz>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Briefly tested on PinePhone, it is useful for SoftISP testing.\n \nSigned-off-by: Pavel Machek <pavel@ucw.cz>", "diff": "diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp\nindex a2f4abc1..105fa781 100644\n--- a/src/apps/cam/sdl_sink.cpp\n+++ b/src/apps/cam/sdl_sink.cpp\n@@ -76,6 +76,9 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config)\n \tcase libcamera::formats::YUYV:\n \t\ttexture_ = std::make_unique<SDLTextureYUYV>(rect_, cfg.stride);\n \t\tbreak;\n+\tcase libcamera::formats::RGB888:\n+\t\ttexture_ = std::make_unique<SDLTextureRGB888>(rect_, cfg.stride);\n+\t\tbreak;\n \tdefault:\n \t\tstd::cerr << \"Unsupported pixel format \"\n \t\t\t << cfg.pixelFormat.toString() << std::endl;\ndiff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\nindex b29c3b93..bb066540 100644\n--- a/src/apps/cam/sdl_texture_yuv.cpp\n+++ b/src/apps/cam/sdl_texture_yuv.cpp\n@@ -31,3 +31,13 @@ void SDLTextureYUYV::update(const std::vector<libcamera::Span<const uint8_t>> &d\n {\n \tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n }\n+\n+SDLTextureRGB888::SDLTextureRGB888(const SDL_Rect &rect, unsigned int stride)\n+\t: SDLTexture(rect, SDL_PIXELFORMAT_BGR24, stride)\n+{\n+}\n+\n+void SDLTextureRGB888::update(const std::vector<libcamera::Span<const uint8_t>> &data)\n+{\n+\tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n+}\ndiff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\nindex 310e4e50..0df6b445 100644\n--- a/src/apps/cam/sdl_texture_yuv.h\n+++ b/src/apps/cam/sdl_texture_yuv.h\n@@ -24,3 +24,10 @@ public:\n \tSDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n \tvoid update(const std::vector<libcamera::Span<const uint8_t>> &data) override;\n };\n+\n+class SDLTextureRGB888 : public SDLTexture\n+{\n+public:\n+\tSDLTextureRGB888(const SDL_Rect &rect, unsigned int stride);\n+\tvoid update(const std::vector<libcamera::Span<const uint8_t>> &data) override;\n+};\n", "prefixes": [ "libcamera-devel" ] }