Patch Detail
Show a patch.
GET /api/1.1/patches/19307/?format=api
{ "id": 19307, "url": "https://patchwork.libcamera.org/api/1.1/patches/19307/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19307/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231212115046.102726-3-andrey.konovalov@linaro.org>", "date": "2023-12-12T11:50:41", "name": "[libcamera-devel,RFC,v2,2/7] libcamera: internal: Move SharedMemObject class to a common directory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b0d827579a1b32a3fe8b546d266405adc49904ef", "submitter": { "id": 25, "url": "https://patchwork.libcamera.org/api/1.1/people/25/?format=api", "name": "Andrey Konovalov", "email": "andrey.konovalov@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19307/mbox/", "series": [ { "id": 4114, "url": "https://patchwork.libcamera.org/api/1.1/series/4114/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4114", "date": "2023-12-12T11:50:39", "name": "libcamera: introduce Software ISP and Software IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4114/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19307/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19307/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C0F1BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 12 Dec 2023 11:51:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C3CD62B49;\n\tTue, 12 Dec 2023 12:51:23 +0100 (CET)", "from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42E93629E1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Dec 2023 12:51:21 +0100 (CET)", "by mail-ej1-x632.google.com with SMTP id\n\ta640c23a62f3a-a00cbb83c80so636150566b.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Dec 2023 03:51:21 -0800 (PST)", "from Lat-5310.. ([87.116.161.153]) by smtp.gmail.com with ESMTPSA\n\tid\n\ttx17-20020a1709078e9100b00a1b75e0e061sm6213188ejc.130.2023.12.12.03.51.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 12 Dec 2023 03:51:20 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702381883;\n\tbh=oRBIY8kOi0gKYV5IPe6DVH6UPAc8qzG43Lgmf4uwB34=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=stA0/DEGFaa8f6XMcomT0hlegGMZls1wo2kavHX3rdz7CtVIy3lCgRsRHOPL1MsDX\n\tdIo8b2LyKGErGFwhygJAfQmYNJmz0S4KWmhJ5zoOSqLzOn+dZPm4eGmK/GISiygxN7\n\tSmFSKpWYC2qTsTo+WaFXmu5poKQbp6L2s1ChNeO33hP479VXT/L7picyEJ5whCNeai\n\taRYD+a5OMv3nwpx3nFVOhrz2QfHbT4miFglyJFyZK28zLSLjEM/wPqC4nyFAs89hB3\n\tBf/k0gJpGo/+46ZPqIGCABdOuFb0xvlmmxGr4Zo2bq0jtravqJzy5AmySVTeSA8KPd\n\t9Emyn33TBlSJA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1702381881; x=1702986681;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=pFJAoSA9Nwu/bV7xUFK2GgTlAP4DOK35M5GoMj00EiU=;\n\tb=iRu61vP9BuGQLeQvrp10obvknYuPYoHW8BrZKmERHEJlXAoS46+x7X1oy7rG7oTiB2\n\tA1d4x6/1EFwc4RJZHrI0hOc6JQOgD1f/ow7TVECITU9xYppUsx0MHi214XagIQnPbuTy\n\t9UtxNmFS/rCjrLVhv7JrKWzMnEyaNfsxK7Nbai8j8vZTzYVcyP1NmOYoCkV37NGIkhGg\n\tQPop0EWA53W7xuaeAt7ITHRz+wlq46eytS02ruyejfd44CXrXP2gpoORUS40r4SaMqOh\n\tZfFuMQ8IoARxMuwOfF8ETOW7xjOW4EdULEhcnV69/uktT+QCUZLps87XrRkhRCj/8IPu\n\tH49w==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=linaro.org\n\theader.i=@linaro.org header.b=\"iRu61vP9\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1702381881; x=1702986681;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=pFJAoSA9Nwu/bV7xUFK2GgTlAP4DOK35M5GoMj00EiU=;\n\tb=oSfCHWDzM8e8rY6AeAvHUZ5eTZlORgOVqwvnyw86j7wiWScfK+w+JYfRdWGaOQi6WF\n\tuzhfKo+nO9Rs67bgT1auwbUHRlE4FULW0mFpySbWyOyY40YVTaJysNOvsCtJ1bXJrm9c\n\tIeMvGddrdjMygzEDqJeqdWhka3wcZUbXBQ336wCEv0Pvo+oaHnRJaG6NsDxGzke0g5If\n\tKtN2N/bW2VnUtody2SVeaFFX9dF3mohh8gV5nKwaRtcEtymJDYezkEsxrp8Nej+guzP2\n\tVYut1xXPJ4/FjLMGDTZgxfOjZvtr0smBJ94c9TBZ51CTRJ9pKgWyO6bZX6hvkP1H9lUB\n\tARGQ==", "X-Gm-Message-State": "AOJu0YypRrqflg/fPu9nexmWNtVSeh8LWAk0ROs2vxvbmBEY3GzQA3WP\n\ta9XI/ADyvEUhQIT52YLD5fA3z5HVPDLTjY4C63Y=", "X-Google-Smtp-Source": "AGHT+IGUcWnaflIsAT1p4lLw8JO6YrriyT5HqbBf0QqyopyLHQ+Z7pLu0DV+AM24kZb05DUk/xosYw==", "X-Received": "by 2002:a17:907:7f88:b0:9be:7b67:1674 with SMTP id\n\tqk8-20020a1709077f8800b009be7b671674mr3384289ejc.3.1702381880873; \n\tTue, 12 Dec 2023 03:51:20 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 12 Dec 2023 14:50:41 +0300", "Message-Id": "<20231212115046.102726-3-andrey.konovalov@linaro.org>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231212115046.102726-1-andrey.konovalov@linaro.org>", "References": "<20231212115046.102726-1-andrey.konovalov@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v2 2/7] libcamera: internal: Move\n\tSharedMemObject class to a common directory", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Andrey Konovalov via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Andrey Konovalov <andrey.konovalov@linaro.org>", "Cc": "mripard@redhat.com, g.martti@gmail.com, t.langendam@gmail.com,\n\tsrinivas.kandagatla@linaro.org, pavel@ucw.cz,\n\tbryan.odonoghue@linaro.org, admin@dennisbonke.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move SharedMemObject class out of RPi namespace and put it into\ninclude/libcamera/internal so that everyone could use it.\n\nSigned-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>\n---\n include/libcamera/internal/meson.build | 1 +\n .../common => include/libcamera/internal}/shared_mem_object.h | 4 ----\n 2 files changed, 1 insertion(+), 4 deletions(-)\n rename {src/libcamera/pipeline/rpi/common => include/libcamera/internal}/shared_mem_object.h (98%)", "diff": "diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex 0f725cfd..b780777c 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -38,6 +38,7 @@ libcamera_internal_headers = files([\n 'process.h',\n 'pub_key.h',\n 'request.h',\n+ 'shared_mem_object.h',\n 'software_isp.h',\n 'source_paths.h',\n 'sysfs.h',\ndiff --git a/src/libcamera/pipeline/rpi/common/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nsimilarity index 98%\nrename from src/libcamera/pipeline/rpi/common/shared_mem_object.h\nrename to include/libcamera/internal/shared_mem_object.h\nindex aa56c220..bfb639ee 100644\n--- a/src/libcamera/pipeline/rpi/common/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -19,8 +19,6 @@\n \n namespace libcamera {\n \n-namespace RPi {\n-\n template<class T>\n class SharedMemObject\n {\n@@ -123,6 +121,4 @@ private:\n \tT *obj_;\n };\n \n-} /* namespace RPi */\n-\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "RFC", "v2", "2/7" ] }